closes odoo/odoo#119134

Signed-off-by: William André (wan) <wan@odoo.com>

This commit allows the exact search of a text that is searched between dashes.
Examples:   0EUM      => VAT 0% EU M.
            21M       => 21% M , 21% EU M, 21% M.Cocont and 21% EX M.
            21 M"    => 21% M and 21% M.Cocont.
            21" M"co  => 21% M.Cocont.

Part-of: odoo/odoo#119134

before this commit, when deleting a product
category from a db where expense category
is already deleted before this commit [1]
is raising exception

after this commit, exception wont be shown
in existing db where expense category is
deleted.

1 https://github.com/odoo/odoo/commit/09e4b2fb586ac83adb984672e027ce6dd62affb2



closes odoo/odoo#118763

X-original-commit: 7c1a96eb
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Task: 30336

Description of the issue/feature this PR addresses:
In a payment when selecting checks it is allowed to select checks belonging to different companies but it is necessary to allow only to select companies from the same company (the company of the payment).

Current behavior before PR:
In a payment when selecting checks it is allowed to select checks belonging to different companies.

Desired behavior after PR is merged:
In a payment not allow to select checks belonging to different companies

closes odoo/odoo#118683

Signed-off-by: Josse Colpaert <jco@odoo.com>

Previously, when a clipboardData contained both files and html content,
we prioritised files. This is correct when the original content is an
image (in which case the clipboard html may contain an image tag or be
empty, depending on the source). This is however incorrect in at least
one known case: copying a table from a spreadsheet app, as those usually
generate an image of the table alongside the actual html table. In that
case, we would rather keep the table.

This commit differentiates the specific case where the HTML represents a
table from other cases. In the former, priority is now given to the HTML
content. In the latter, we keep the files as we did before.

task-3165757

closes odoo/odoo#118324

X-original-commit: a1e358a9
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Steps to reproduce:
- put the currency of the bill to eur
- change the partner with a partner with no purchase currency set

Issue:
The bill is re-set to usd

Note:
addendum to https://github.com/odoo/odoo/pull/116852



opw-3233527

closes odoo/odoo#117939

Signed-off-by: Cedric Snauwaert <csn@odoo.com>

Steps to reproduce:
- company currency = USD
- set a partner P with a `property_purchase_currency_id` in EUR
- create a bill with Azure partner and set an bill line
- change to partner P
issue -> the currency of the line has not been change
- change to Azure
issue -> no change about the currency

Cause:
- We update the move.currency_id but not the line_ids.currency_id
- after setting Partner P, we try to set a partner that no `property_purchase_currency_id`, we do not enter in the condition

opw-3233527

X-original-commit: 8985426b
Part-of: odoo/odoo#117939

Odoo 16 has new feature *Comparison Price*. It allows to show striked price
after the main price. E.g. `$555 -$666-`.

It doesn't work well however on using RTL languages because of *Unicode
Bidirectional Algorithm*. For example, in Egyptian localizations it shows some
mess of striked and not striked characters: `LE -LE-666- 555`. The correct
display should be `-LE-666- LE 555`. (Examples are even more complicated with
symbol E£ that is currently used by default for EGP).

As a solution, use `<bdi>` element to isolate stiked value. Also we have to use attribute
`dir="inherit"` to avoid changing direction for currencies that use LTR
characters, otherwise the result would be `-666-LE- LE 555`.

STEPS:

- Go to settings > website: Activate *Comparison Price*
- Go to Sales > Pricelist: add extra pricelists with EGP currency and mark it
as **Selectable**
- Go to Setting > Languages: activate the Arabic language and add it to the website.
- Go to the product form: add **Compare to Price**
- Go to the website > products, select pricelist EGP

opw-3188129
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/bdi



closes odoo/odoo#113261

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

This commit adds a basic tour for creating a mailing from a campaign's
"Mailing" tab, via the list view of the `mailing_mail_ids` one2Many field.

closes odoo/odoo#116403

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The campaign's "Mailing" page displays the one2Many `mailing_mail_ids` field
in a list view. When creating a new mailing from this view, a new record is
created with the fields from the comodel(`mailing.mailing`)'s form view, which
does not have the necessary "body_html" field.

This resulted in a traceback when attempting to save changes to the newly
created record, as `MassMailingHtmlField.commitChanges` calls `Record.update`
for such field.

This commit ensures the `body_html` field is present by adding it as a
dependency of MassMailingHtmlField.

Task-3225211
OPW-3204686

Part-of: odoo/odoo#116403

Current behavior:
When a fiscal position is applied on an order in the PoS, the change of
price was interpreted as a discount. This shouldn't be the case.

Steps to reproduce:
- Create a tax that is included in the price (e.g. 10%)
- Create a fiscal position that match this tax and change it to no tax
- Change the pricelist option to show discount
- Create a product with a price of 100€
- Open the PoS and add the product to the order
- Apply the fiscal position
- Pay the order, and go to the receipt screen
- There is a discount showed on the receipt

opw-3154499

closes odoo/odoo#118841

X-original-commit: 2fa37b32794f7efc058c6ab13b8bbd9a533b6d28
Signed-off-by: Heinz Robin (rhe) <rhe@odoo.com>
Signed-off-by: Engels Robin (roen) <roen@odoo.com>

1. Install [Timesheet], [Sales]
2. Settings > Time Encoding > Encoding Method > Days/Half-days
+ Make sure the company has more than 1 employee from Employee app
3. On Products, edit Service product type to have:
- invoicing policy: based on timesheets
- create on order: project
- uom: Days
4. On Sales app, create a SO and add a service with a price
- automatically a project will be created
5. On Timesheet app, create a project linked to the SOL
6. Create a task and set timesheet 1 day
7. Go to [Timesheet] > [Reporting] > [By Employee]
8. Group by SOL and dipslay the MEASURE 'Timesheet Revenues'

Issue: Revenue is multipled by the unit measure of day in hours

Impacted version: 16-master
opw-3255928

closes odoo/odoo#118718

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Since [1], some bus tests were failing in a non-deterministic
way. This PR fixes the issue.

[1]: https://github.com/odoo/odoo/pull/119525


Fixes runbot errors: 20755, 20756, 19933.

closes odoo/odoo#119615

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

There was an issue before this commit where some flags (basically all
the ones which are not tribands) would appear "broken".
This is the case for the China one where the symbol on the flag would be
squashed.
Using `object-fit` css property will keep the original flag ratio.

task-2929438

closes odoo/odoo#119560

X-original-commit: 32aca111
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

We can send service product details if there are any one goods in the Invoice.

task - 3276398

closes odoo/odoo#119517

X-original-commit: 32b65ffc
Signed-off-by: Josse Colpaert <jco@odoo.com>

Before some translations didn't work in the point_of_sale because in owl
you can't use t-set to manage translations. In cashMovePopup, _t was
used at a time when loading translations is not yet guaranteed.

Now we have changed _t to _lt to ensure that the translation is done
correctly. For the t-set, we have added the translations in static
properties of the concerned components.

closes odoo/odoo#119291

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

On some mobile devices (eg Samsung Galaxy S22), the datepicker
immediately closes when trying to apply a custom date filter

Steps to reproduce:
1. Install Sales
2. Open Sales
3. Click on the search icon then on the filter icon
4. Click on 'Filters' and add a custom filter on field creation date
5. Click on one of the dates
6. The datepicker opens and then closes immediately

Solution:
Do not hide the datepicker when a scroll is made on mobile devices

Problem:
When opening the datepicker, the keyboard would show up, scrolling the
view which triggers the closing of the datepicker

opw-3166801

closes odoo/odoo#118951

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

Since we've changed Bootstrap version from 4 to 5 the way to create a
popover has changed.

So we adapt it to the new way to declare popovers in the website form

closes odoo/odoo#118938

Signed-off-by: Masereel Pierre <pim@odoo.com>

All figures coming from the accounting dashboard should be, by default, excluding the unposted entries since this is the default filter when opening the reports.

opw - 3268676

closes odoo/odoo#119513

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Co-authored-by: LucasLefevre <lul@odoo.com>

- Import bank statement from the file not having label/partner
- Access an existing reconciliation model and add a partner mapping
- Try to reconcile bank statements

Traceback

```
[...]
File
"/home/odoo/src/odoo/16.0/addons/account/models/account_reconcile_model.py",
line 855, in _get_partner_from_mapping
match_payment_ref = re.match(partner_mapping.payment_ref_regex,
st_line.payment_ref) if partner_mapping.payment_ref_regex else True
File "/usr/lib/python3.10/re.py", line 190, in match
return _compile(pattern, flags).match(string)
TypeError: expected string or bytes-like object
```

opw-3235015

closes odoo/odoo#118820

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Prior to this commit, after [1], when a user is trying to visit or view
their website from a domain that is not their current website, a
traceback would appear if the redirect took too long.

This is because when redirecting, we do not set any URL as the iframe
iframe source, so it loads the `about:blank` page. When trying to push
that page into the history (done to change the name and url displayed in
the browser), the browser crashes and displays a CORS error.

On top of that, it seems some users do not understand what is happening
and feel like they are being logged out if they're not logged into their
custom domains.

This commit prevents replacing the history state if the page displayed
in the iframe is `about:blank`.

It also displays a dialog before redirecting, explaining to the user why
it is necessary.

Steps to reproduce:
- Go to website settings
- Set a domain for your website that's different from the one you are
currently using to access Odoo (Could be anything but for a realistic
setup, if accessing from localhost, use 127.0.0.1 or the other way
around, or use different 127.0.0.X ips)
- Toggle a slow network mode from your browser's dev tools
(This is to ensure the traceback appears as it does not if the network
is quick enough with its redirect)
- Go on the website app
=> A traceback appears (and disappears as the page is unloaded)

[1]: https://github.com/odoo/odoo/commit/59b96b0742fe8da31eecf896f7a6157811d49de5



opw-3250663

closes odoo/odoo#118228

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Before this commit, when uploading an attachment on a draft record,
there was the following crash.

This happens because the file uploader in use was the one from when
the record was in draft. The file uploader is changed when the
record is no longer in draft, so the new file uploader should be used
instead.

This commit fixes the issue by delaying slightly saving of record in
chatter model, so that we are sure the chatter record is no longer
temporary (= record not longer in draft), which in consequence create
a new file uploader that actually works.

opw-3280676

closes odoo/odoo#119515

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

This release only contains a bug fix:

[FIX] t-out: does not crash when outputting null

See https://github.com/odoo/owl/releases/tag/v2.1.2

 for more details.

closes odoo/odoo#119537

Signed-off-by: Samuel Degueldre <sad@odoo.com>

Current behaviour:
In the project update section, if the project has only draft
invoices linked to the analytic account of the project, the invoices
smart button isn't present. But once we have at least 1 posted
invoice, the button is shown, and when triggering the action, we see
both the posted invoice and all the draft invoices that were not
shown previously.

Expected behaviour:
The button should be visible, even if the only invoices linked to
the analytic account of the project are only in draft.

Steps to reproduce:
- Install Project, Sales, Accounting
- Activate Analytic Accounting in the Settings
- Create a Project and make sure it has an analytic account linked to it
- Create a new invoice in draft, make sure on the line you have set
  the analytic account of the project we just created. Save.
- Go to the project update page, there is no smart button that will
  go to the invoice we just created.

Reason for the problem:
The Invoices smart button is shown only when the `invoice_count` is > 0.
`invoice_count` is a related field to the same field name of the
analytic account, which is a compute. In that compute we explicitly
only take invoices that are posted, since in the context of an
analytic account, it only makes sense to take actually posted
invoices, since those are real revenues. So the button is shown only
when we have at least 1 posted invoice. The action itself is just
fetching all the `in_invoice, out_refund` invoices that are linked to
this analytic account.

Fix:
Transform the `invoice_count` in `sale_project` module from a
related to a regular compute and do a query with the same heuristics
for the action of the invoice smart button.

Affected versions:
- 16.0
- saas-16.1
- saas-16.2
- master

opw-3227421

closes odoo/odoo#119190

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit, the bus service was starting worker at page
load, regardless on whether the user interacts with chat features.

This commit starts bus worker only when it's really useful, e.g.
when adding a new channel to subscribe. Functionally, on livechat,
the worker does not start before the livechat is open.

Task-3266973

closes odoo/odoo#119525

Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>

This commit put the same field description between 'sale.order.template.line'
and "sale.order.line"

closes odoo/odoo#119509

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Some tags were not correct on taxes
IVA 0%.

closes odoo/odoo#119422

X-original-commit: 3ac980d4
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>

This commit fixes the property field tag components and sub-components by
ensuring that the ".bind" function of the component always receives a function.

As the "checkDefinitionWriteAccess" prop is optional, it could crash because
OWL would try to call ".bind" on an undefined function.

The new code will pass an empty function instead as a fallback.
(When it's not passed, it's never called, as it is in a display context and we
do not create tags, e.g: when showing the tags in a kanban view).

Task-3280847

closes odoo/odoo#119309

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:

- Open any listview (e.g Sales order listview)
- select records from the listview, go to Favorites, and click on 'Insert list in spreadsheet' option
- Once the spreadsheet is created, Reload your browser.

Current behavior:
- Spreadsheet goes to an infinite loading.

opw-3284058

closes odoo/odoo#119488

Related: odoo/enterprise#40180
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

closes odoo/odoo#113379

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

This commit adds unit tests for cases where the cursor is placed at the
editable root (which is corrected by the Editor).

Part-of: odoo/odoo#113379

Some of the Editor methods relies on not having inline elements at
the editable root. For this reason, the cursor should never be placed
at the editable root, but always inside a block element.

Before this commit, in some situations (notably around tables and
horizontal separators), the cursor could be placed having its anchorNode
at the editable root, allowing the user to insert inlined text at it.

This commit fixes the selection range in such cases, and an empty paragraph
is inserted in cases where there would be no other way to insert text before
or after an existing block.

task-3128747
opw-3106752

Part-of: odoo/odoo#113379

The `isVoidElement` utility function has a misleading name, and the need
for an actual list of void elements arose.

This commit replaces the `isVoidElement` utility by two functions:
- `isArtificialVoidElement`: returns true for elements that we decided to
treat as if they were void elements. This method is used to decide whether
they should have their "isContentEditable" attribute set to false.
- `isNotAllowedContent`: actual void elements + the ones above.

The `isVoidElement` function is kept on stable for compatibility
reasons.

Part-of: odoo/odoo#113379

Before this PR, the filter on account root was present 2 times in the journal
items views. By removing one of the two, the problem is solved.

opw-3275279

closes odoo/odoo#119481

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Steps to reproduce:
- create a time off type;
- select 'Extra Days Requests Allowed' for 'Employee Requests';
- select 'Approved by Time Off Officer' for Approval;
- choose a Responsible Time Off Officer;
- change the select for 'Employee Requests' and select 'Not Allowed';
- create an allocation for an employee with this type.

Issue:
The allocation is blocked at step 'TO APPROVE'.

Cause:
Even if we choose `no` for `employee_requests`,
the `allocation_validation_type` always contains `officer`.

Solution:
We have to test the `employee_requests` field during the
validation action

opw-3264758

closes odoo/odoo#119013

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Like here https://github.com/odoo/odoo/blob/14.0/addons/payment/views/payment_templates.xml#L69

, if the acquirer have display_as, it is more logical to shpw everywhere this field.

closes odoo/odoo#119469

X-original-commit: 8be706e0
Signed-off-by: Valentin Chevalier <vcr@odoo.com>

In V14 this case is managed : https://github.com/odoo/odoo/blob/14.0/addons/website_sale/controllers/main.py#L1075



closes odoo/odoo#119403

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: vfe-odoo <Feyensv@users.noreply.github.com>

Before this commit:

After selecting the text of shift+enter which is styled and pressing any key
the new hideous child gets born.

After this commit:

Now, The new input will replace the selected text.

Task-3209969

closes odoo/odoo#119262

X-original-commit: 56a57f7c26b4c0598840b82fab909d21113aa572
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

this commit removes unnecessary modal that does not let users create
a new users from apps like crm, sale, etc. Now instead of giving requests
that lack email redirectWarning, we open user creation form where user must
set email up.
Reason behind this change is the fact that login is required at the model level,
so the manual checks for this value is not necessary anymore.

task-3262468

closes odoo/odoo#117757

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

The Scheduled Date field is in readonly depending on the MO state, but
the `close` state does not exist, use the `done` state instead to match
the decoration-* attributes

closes odoo/odoo#119372

X-original-commit: a12ba467
Signed-off-by: Adrien Widart <awt@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>