When selecting the "Continue shopping" option after adding a
configurable product from the products page with "Add to Cart" enabled
the top navbar was not updated.

Part of https://github.com/odoo/odoo/pull/37132

task-2070507

closes odoo/odoo#38538

X-original-commit: https://github.com/odoo/odoo/commit/9e58f0659e21d0f7e63b127d7a84b505e6aa1fb5


Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The animation was not waiting for the target to be displayed.

Part of https://github.com/odoo/odoo/pull/37132

task-2070507

X-original-commit: https://github.com/odoo/odoo/commit/b7f2dd4d56537fb06682419fa75fb7c671160243

When you try to delete a floor, an error is raised if a pos config has
an opened session. Even if the floor is not used in the opened pos
config.

The real goal of this constraint is to avoid deleting a floor plan
linked to a pos config having an opened session.

Github issue: https://github.com/odoo/odoo/issues/38581



closes odoo/odoo#38674

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Creating a location without name does not make sense, it is the only
field of the model
Fixes odoo/odoo#38571

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The RUT is the Registro Único Tributario;
the NIT is the Número de Identificación Tributaria.

The number that is used is thus the NIT.

opw 2082599

closes odoo/odoo#38526

X-original-commit: 1db209ac
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Go to hr.applicant view form, Edit and change something.
Each time you change a field, the Attachment box in the chatter is toggled
(as if you were clicking on the small attachment button each time).
This a wrong behavior of the `open_attachments` option of the `mail_thread`
widget.
Opening the attachment box should be done at the widget initialisation,
not at every render.

closes odoo/odoo#38519

Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

Before this commit, some images would display incorrectly orientated.

This typically happens for images taken from a non-standard orientation
by some phones or other devices that are able to report orientation.

The specified transposition is applied to the image before all other
operations, because all of them expect the image to be in its final
orientation, which is the case only when the first row of pixels is the top
of the image and the first column of pixels is the left of the image.

Moreover the EXIF tags will not be kept when the image is later saved, so
the transposition has to be done to ensure the final image is correctly
orientated.

closes odoo/odoo#37448

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Before this commit, in base we use bus to notify the user but bus module
is not always installed and so we can't call it.

After this commit, now we use a client action to notify the success test.

Steps to reproduce:
* install a Odoo with no apps
* go in debug mode
* go to "Outgoing Mail Servers" technical settings
* create a valid SMTP record
* click on "Test Connection" button (BUG)

closes odoo/odoo#38276

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit, it was not possible to show a message using a client
action. (e.g. show a success message only with core in Python)

Now, it's possible using a client action. This client action call
displayNotification and so we can use the same options also.

A test is added to be sure that this action do not change the current action

Note: in the future a custom registry may be created in a refactoring
to specific function action registry.

Before this commit, if we use some client action like: reload, logout, ...
in the console a warning is show, because the action are function and not
AbstractAction.

After this commit, if the client action is not an function and not
a AbstractAction the warning is show.

-Define "g" as the default UoM for a product.
-Make a purchase order with that product.
-Select the "kg" UoM in the order line and a price of 50.
-Check the Purchase tab of the product.

Before this commit:

the UoM of the price created is the default UoM for the product, "g".
This is because it's a related field.
However, the price wasn't converted to the default UoM, it's still 50.

After this commit:

the price is converted to the default UoM, it's 0.05 per "g".

closes odoo/odoo#38522

Opw: 2076722
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Fixes https://github.com/odoo/odoo/issues/38233



New Invoices shouldn't be created from Payment screen.

closes odoo/odoo#38240

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Fixes #38574
Assigning default value for non-stored compute fields is required in
13.0

closes odoo/odoo#38583

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- If the Timesheet entries all belong to the same project, the report
  title should be
  "Timesheet Entries for the name of the project Project" and here in
  this case no need to show the project column.
- Split the Project - Task column into two separate ones: one for the
  Project and one for the Task

task-2027729

closes odoo/odoo#38504

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>

OPW 2082843
The communication on the register payment took the vendor reference or
the invoice name by default. Now, it first looks at the payment reference
value.

closes odoo/odoo#38478

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

-Import a subscription with end date beyond 200 in the future (ex: 2500-01-01).
-Open the subscription and click the Edit button.

Before this commit:

A stacktrace appears indicating that a date is not valid. It's not possible to
edit the subscription.

After this commit:

The maxDate of the date picker has been increased to 31/12/9999, allowing the
user to edit subscriptions whose end date is that far in the future.

A test `toggle datepicker far in the future` for this case has been created.

closes odoo/odoo#38521

Opw: 2079696
X-original-commit: 32b6131c04fef7a542a0ccbdb924d177627bfe38
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, if you archive a blog, you will have a 500 instead of 404.
Serve page to show the 404 use request.website, so we need to force controller
with website=True to bind website on the request.

Probably need to check all controllers in website_* module.

opw-2066725

closes odoo/odoo#38534

X-original-commit: 74341c4f
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Fixes #38313

closes odoo/odoo#38535

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

We didn't check the status of the response of the server when getting
the url of the display. If the status was different from 200, we tried
to use the error response as URL.

closes odoo/odoo#38512

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Go on the portal with a portal user
Drop a message in the chatter

The message is logged in the chatter from the right partner
Before this commit however, the email that was sent had
its address from of the OdooBot

After this commit, the mail is sent with the partner's email from

OPW 2074154

closes odoo/odoo#38507

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

It seems the grouping feature was lost during the accountpocalypse.

Add a test as long as I'm at it.

closes odoo/odoo#38500

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

If two snippet options are declared using the same data-js="..." and
that they end up targeting the same snippet in some cases, only one of
those two snippet options was shown.

This case occurred in a theme (avantgarde) for the map snippet.

closes odoo/odoo#38498

X-original-commit: https://github.com/odoo/odoo/commit/5ee0147c1ab9903d97d5409c972910eecd688fc7


Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Example of workflow to reproduce the issue:
- Add a selection field 'Test' to `project.task` with Studio
- Go to Projects > Planning > By Project
- Switch to list view
- Add the newly created field to the view 'Task > Test'

The interface loops indefinitely because the server is stuck in an
infinite loop.

The loop is the following:

https://github.com/odoo/odoo/blob/89270ee39c0daa46ae8e2e3e57d7e512a1a65ddf/odoo/models.py#L5624-L5625



The root cause of the issue comes from an incorrect object ID added in
the list of fields to recompute. Since the method is set in a
`post_init`, the object `field` is different from `recs[field_name]`.

To prevent the error, we retrieve the object directly in the
`mark_fields_to_compute` method.

opw-2083852

closes odoo/odoo#38497

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Denis Ledoux <dle@odoo.com>

Since https://github.com/odoo/odoo/commit/ea3a2ab6788980a8961d9b9a3f88bc13c15a3c46
the website name appears in the view names if the user has the multi
website group or in special cases on some form views.

We don't want it to be displayed in snippet names in the editor UI.

Part of https://github.com/odoo/odoo/pull/38495


task-2083198

closes odoo/odoo#38495

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

When an option group is opened, all the other opened option groups were
closed. The problem is that an option group may contain other option
groups, so when trying to open a sub-group the main parent group was
closed first.

Note: this case only occurs for one option in themes for now.

Part of https://github.com/odoo/odoo/pull/38495
task-2083198

* website_form

To support old theme options, a hack had to be made to allow access to
left panel UI. This will be improved in master.

Part of https://github.com/odoo/odoo/pull/38495
task-2083198

closes odoo/odoo#38492

X-original-commit: 1e012dda
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Only invoices/bills should create their equivalent credit notes when reversed (with tax tags coming from the related repartition lines), other kinds of journal entries should be reversed as misc entries, to negate them entirely in the accounting

closes odoo/odoo#38476

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

We should always ensure to assign something in a compute method

Since sms_template_id is not required, we have to check that it is set
before trying to render the template

Also make sure to have a default value in case you don't have a res_id

closes odoo/odoo#38463

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

sms_composer could crash in case you didn't pass it the active_id,
active_ids context keys or don't call the default_get

In that case it would try to access `self.env[False]` which would crash
in the `_compute_recipients_count`

We also have to ensure that we have a default value for `self.res_ids`
because `literal_eval(False)` will crash

closes odoo/odoo#38461

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Fields created with Studio are case-sensitive, so we need to properly
quote the query.

opw-2083852

closes odoo/odoo#38460

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Test case;
The user as edition rights on the website
Install quotation builder
Have a sale order with many lines
Click preview > you end up on the portal view

Before this commit, there was a blank space just before the
sale order lines per se
This was because the sale order's lines website description
were in the dom and took some fixed space, which is a feature
meant for the edit mode by using the class oe_no_empty

After this commit, we restrict the effect of that class concerning
the fixed height only to edit mode
There is no more gaps in the sale order preview

In master, one should check whether the class / rule is still relevant

OPW 2082267

closes odoo/odoo#38429

X-original-commit: 4b177412
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Initially a forward-port of 5aecd365, which needed f407e60a to work.

The do_in_onchange was removed inbetween, but it is not needed anymore here.
The issue was caused by the fact that the cache values given for each
environment, whereas in the new ORM the values are now shared across all.

The other potential issue caught by this test was that the company of the taxes
could be incorrect. This is problematic for the end user, since relational that
violates inter-company rules mean that they won't be able to read or write
the records without sudo. However the model now has _check_company_auto,
handled by the ORM, so the issue should not arise anymore.

closes odoo/odoo#38377

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

- Install timesheets and studio.
- In timesheets add a time of -0.5 (minus half an hour).
- Enter studio
- Switch to the Reports tab, and click Timesheet Entries.

Before this commit:

The time is displayed as 00:30.

After this commit:

The time is displayed as -00:30.

closes odoo/odoo#38354

Opw: 2036188
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Because of 4b1cb41c, we might try to read
the field 'active' on a record on which we can't read fields besides the name.
This thus triggers an access error where there should not have been.

In particular, this is the case for portal users: most often the records they
can access point to records that they can't read
(e.g. the partner of the internal user assigned to the ticket).
As a result, clicking on any link creates an ACL, and thus redirects to the
home page.

It turns out that filtered_domain was primarily used on already loaded records,
typically for the write, so it was assumed that the records could be read
in the first place.
However in the use-case of the portal, there is an explicit check on the read
rights with the portal user, explaining the discrepancy.

Since in the general case filtered_domain should be able to read all fields
to evaluate the domain, we put it in sudo.

fix co-authored with @rco

closes odoo/odoo#38198

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Computed fields need to always be assigned a value now.

The way the active_id(s) were retrieved made the wizard only take care
of one active_id. This prevented from reverse multiple invoices at the
same time.

closes odoo/odoo#37681

Fixes: #35759
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Computed fields that depend on the context now have to be declared as such.

To reproduce the issue:
- go on the form view of any view
- update the arch of the view
- save
- click on action "reset view architecture"
- select hard reset
- no diff is shown

Expected: a diff should be shown

`arch_base` depends on `arch`, so even though no current flow actually uses it
when the context is changed, update its `depends_context` as well to be safe.

closes odoo/odoo#37363

Pr: #37363
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

This is necessary when writing view fields from a page record because the
generic page will put the given values on its cache but in reality the values
were only meant to go on the specific page. Invalidate all fields and not only
those in vals because other fields could have been changed implicitly too.

PR: #37363