Add the id of the current company to the evaluation context for ir.rule
domains

closes odoo/odoo#40035

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Commit 5fcf891e introduced optimizations for
name_search in several models.  However, that produces some counter-intuitive
searches.

In a DB with project and custom data:

    >>> Project = self.env['project.task']
    >>> Project.search([('user_id', 'ilike', 'demo')]).mapped('user_id.name')
    ['Marc Demo']

    >>> Project.search([('user_id', 'not ilike', 'demo')]).mapped('user_id.name')
    ['Marc Demo']

The projects returned with 'not ilike' are a super-set of those returned with
'ilike':

    >>> Project.search([('user_id', 'ilike', 'demo')])
    project.task(22, 21, 20, 16, 14, 13)

    >>> Project.search([('user_id', 'not ilike', 'demo')])
    project.task(22, 21, 29, 28, 27, 26, 25, 20, 16, 14, 13, 31, 30)

This commit fix this behaviour by choosing '!=' instead of '=' whenever the
operator is a negation operator.

The 'res.users' is more exposed than the other models touched by
5fcf891e, because user may search for 'Created
by' in the web client.

closes odoo/odoo#40130

X-original-commit: b3c539b0
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When assigning a default value to a computed monetary field, if self
contains records with different currencies, the assignation will fail
when trying to round the value (because self[currency_field] is a
recordset of multiple currencies).

Globally, assigning a monetary value to records in different currencies
should never happen.  The only case we want to support is defaulting a
computed monetary to 0.0.

Add clear error when trying to set monetaries in multi-currency.

closes odoo/odoo#40128

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Raphael Collet <rco@odoo.com>

In IE Edge async and await are supported, but guardedCatch is added to
polyfilled MyPromise object and async methods return original Promise so
depending of chain guardedCatch can cause en error or not.

It seems that historically, the MyPromise patching has also had issue in
firefox with it sometimes working or not.

In this changeset we completely remove it (which will have the drawback
of more error shown in console in firefox).

opw-1964486
opw-2116839
closes #39953

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When using the flamegraph module from a parent directory of odoo, the
dirname method returns a relative path, leading to a traceback.

With this commit, the odoo_path is enforced to be an absolute path.

closes odoo/odoo#40124

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

commit 89f20d2c removed thumbnail but didn't adapt the views that used it.

Adapt the view and directly use the datas and not the thumbnail.

Close #38747

closes odoo/odoo#40122

X-original-commit: e73b468135d27ce8c1e84c3ecf2d0b3af176d760
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Fixes https://github.com/odoo/odoo/issues/39358


Before this commit Internal user (With no other Rights) cannot perform any activity on Reminder Popup due to missing rights to set calendar_last_notif_ack field.
With this fix, we are now using sudo to write calendar_last_notif_ack

closes odoo/odoo#40101

X-original-commit: 91560fae
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#40000

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The self don't contain 'interface_protocol'.
The 'interface_protocol' is in self.dev because we add this in 'supported' function.

closes odoo/odoo#40118

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

In 12.3 there was a number of changes in source mode. This was reverted
before 13.0 and somehow it seems the source mode was lost between the
12.3 editor changes and its revert.

With this changeset, we introduce back source mode as it was in 12.

opw-2091649
opw-2116960
closes #40026

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Reproduce this issue

    - Install CRM & Sales
    - Create 2 sales team in CRM settings
    - Create some invoices and register payments for the 2 teams
    - Go in CRM > Sales > Team pipelines

    The invoicing amount is still 0 for both teams.

Cause

    - The `_compute_invoiced` method in `CrmTeam` models use a SQL
    query to retrieve the invoices lines but it returns an empty
    recordset because the dates are not right ordered.

    - The line balance are negatives values, doing a SUM() will always
      returns 0

This commit re-order the dates and invert the sign of line.balance.

OPW-2119819

closes odoo/odoo#40093

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- fixed some tax report lines by showing correct amounts
- corrected account types
- set default receivable/payable/advance tax accounts for tax groups

closes odoo/odoo#39191

Task: 1917932
Closes: 39191
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Purpose
=======

Steps to reproduce:

- Configure a product of type service to create a task on a
  sales order validation, without configuring a project template
- On the SO confirmation, the project is generated without any stages

Additional issue:
- go to the Kanban view of the Project
- filter on something that doesn't give any result
- The kanban switches to edit mode, even if there is
  a task

This commit solves both issues.

closes odoo/odoo#40056

X-original-commit: e2de6331f7f75c9c9b086e57b88f6d25a2cd303d
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

In case of a multi-record and multi-page (i.e. 2 pages per PDF) report
the assertion is triggered b/c we have 4 pages and only two records with
a PDF of 2 pages each, so the outline_page needs to be unique before
assertion.

len([0, 0, 2, 2]) != len([record_id1, record_id2])
len([0, 2]) == len([record_id1, record_id2])

closes odoo/odoo#40075

X-original-commit: 573e5777
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

A patched method was not unpatched. Which triggered issues in a staging
master branch trying to untie a bit mail tests.

closes odoo/odoo#40046

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Install stock and sale. Create a sale with 2+ products, save and
confirm.
Look for the created picking.

There will be no source doument, because of
cb618e9a
the behavior has changed when there are multiple source
document, possibly to avoid displaying the wrong source if they
differ.

Adding the possibility to display multiple source documents, eventually
truncating the list

opw-2117886

closes odoo/odoo#39957

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The icon of the 'Vendor Bills' stat button isn't displayed
so fix the icon class.

Task-2115206

closes odoo/odoo#40006

Closes: #40006
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#40034

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Firstly bd49f9fd did some fixes that removed a bunch of code containing 'install_mode_data'. Later, 627292f7 replaced 'install_mode_data' for 'install_filename'. Finally, 43dd9ecd reverted bd49f9fd (including 'install_mode_data' remnant).

closes odoo/odoo#40022

X-original-commit: 0c3d9256
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#40028

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Prerequisites

    - Configure a mail server (incoming)
    - Enable leads in CRM app
    - Create a sales team with a mail alias (ex: testcrm@odoo.com)
      and check "Pipeline" and "Leads"
    - Set a partner email with one of yours (ex: bob@odoo.com) /!\
    - Send a mail from bob to testcrm
    - In the incoming mail server click on "Fetch"

Reproduce the issue:

    - Convert the generated lead to an opportunity
    - Choose "Existing customer" and set another one than the actual
    - The opportunity is created but the customer is the old one

Cause:

    The given partner_id is overriden by the old one in the
    `handle_partner_assignation` method.

This commit gives the priority to the new partner_id.

OPW-2089404

closes odoo/odoo#40023

X-original-commit: e1833936
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

The third parameter to assertAlmostEqual is a precision (places), not the
assertion message. This goes unnoticed when using two objects which are
strictly equal because assertAlmostEqual shortcuts if the two inputs are equal,
before falling back on approximation.

Since the parameters here are two integers, they're always going to be either 
identical or completely different, therefore the issue is only visible if the assertion 
fails, hiding the assertion error.

* pass the message by keyword
* replace assertAlmostEqual by assertEqual as the inputs are integers and integers
  can't really be "almost" equal

closes odoo/odoo#40015

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Since the deployement of the forward-port bot, chances to merge code
with conflict markers has greatly increased.

With this commit, a new test is added to grep for those markers in most
common code files.

closes odoo/odoo#39994

X-original-commit: 80f22f98
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Updates to the customer display were sent too often:
 - Twice when creating a new order
 - Twice when removing a payment line
 - Every time the status of a payment line with a terminal changed

closes odoo/odoo#39179

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

closes odoo/odoo#40008

Signed-off-by: Fabien Pinckaers <fpodoo@users.noreply.github.com>

Usecase to reproduce:
- Create a purchase requistion with type Call For Tender
- Update a line and set the price to zero.

UserError 'You cannot confirm the blanket order without price.' raised.
It happens because the write don't process the same check than create
and don't check if the purchase_requistion is a blanket order or a call
for tender. It also doens't check the current state of the
purchase_requisition.

closes odoo/odoo#39973

Task: 2120211
X-original-commit: 7d69f014
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When the user changed the parallax option, it was only updated on save.
So, the user was not able to have a preview of what he chose.

Note: this commit is made in saas-12.3 but does not fully solve the
problem there... and unfortunately I don't know why. It fully solves
the problem in 13.0 though and this is more important.

closes odoo/odoo#39991

X-original-commit: 4b633949cd4fd1cae807b95d233879ac4adc01ce
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

- Create 2 companies A & B
- Create a website A
- Create a user U with access to company B only
- Connect as U and go to the website

An internal server error is raised.

This is due to 7bfcb53d which verifies if the user isn't
granted access to companies he is not supposed to access.

This is exactly what was done before this commit: the website is in a
company not allowed to the user.

opw-2116539

closes odoo/odoo#39921

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#39700

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Fix the displayed end date weekday on an event's registration page. See #39698

Activate Google Synchronization, create on OE a recurrent event,
synchronize the calendar, then delete an event of the recursion on GC,
sync again on OE.

The event will be deleted from GC but not from OE after sync.

This appens because of this "rewrite" rule
https://github.com/odoo/odoo/blob/12.0/addons/calendar/models/calendar.py#L918


that occur on event creation from OE, altering the event parameters when
is marked "allday".

When an "allday" event is deleted from GC the unlink is triggered in OE with the
default time "00:00:00". During the creation of the exclusion '
_inverse_dates' will be called altering start and stop datetime but not
recurrent_id_date, so the new record will not match the event generating
the recursion and the exclusion will not occur. The problem require
particular carefulness because when a recurrent event is fetched from
google the '_inverse_dates' is not called, so in that case the default
time is fine.

opw-2060526

closes odoo/odoo#39653

X-original-commit: a468464c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In the contacts app, you can select 2 partners and merge them.

Before this commit:

    - If a partner was added by a SQL query and not directly on Odoo,
      the create_date will be empty. This causes a crash because the
      merge wizard try to sort the partners by date

After this commit:

    - If a partner do not have a create_date, it will be considered
      as 01/01/1970. The merge wizard will sort the partners by IDs too.

OPW-2091925

closes odoo/odoo#39758

X-original-commit: df09f2f73ddf917304906e98725324319c309939
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

In editable list view, moving to next cell using TAB key crash when the
following field is read-only (i.e non-focusable) and an onchange() event
is triggered.

Consider an editable tree view like this:

<form>
   <field name="o2m" onchange="1">
       <tree>
          <field name="description"/>
          <field name="date" readonly="1"/>
          <field name="type"/>
       </tree>
   </field>
</form>

1. Adding a new line will give focus to `description` field widget
   (currentFieldIndex is 0)

2. issuing a TAB keypress, will call _onNavigationMove which calls
   _selectCell() with fieldIndex of 1

3. The _selectCell() method set widget currentFieldIndex to the new value
   (currentFieldIndex is 1) add call _activateFieldWidget() to activate
   on the corresponding widget.

4. _activateFieldWidget() will fail to activate the `date` field as it's
   readonly, then try for next ones and succeed to activate the `type` field
   cell

5. When focus is given a `type`, the `description` field is blurred which
   trigger an onchange() and the controller apply those changes to the
   editable list rendererd using the confirmUpdate() method.

   The confirmUpdate() will try to get the current selection, but that
   field is actually set to the `date` field (currentFieldIndex = 1),
   which is readonly and so has no focusedElement - triggering the crash.

This commit ensure we don't try to call getSelectionRange() it current widget
has no focusable element.

OPW-2075229

closes odoo/odoo#39972

X-original-commit: 93c7ae9ba5309810c41c58fc8f2fafb3c3dac76e
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Follow up on https://github.com/odoo/odoo/commit/ac5469646cdea7c0990fbd5092eae26e7e0768ae#diff-04174b6f17e548b9a79222ae09c573db


Before this Commit, upgrade_boolean was applied on sale_coupon module while this has been moved to the community version from v13, so upgrade_boolean is not needed now

closes odoo/odoo#39985

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

closes odoo/odoo#39987

X-original-commit: 75b1d412
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Commit 775e8a9f forced channel guidelines to be sent directly. It seems
safer to use the cron queue as we do not see any evidence of daily use of
channel guidelines requiring immediate sending.

Task ID 2121319
PR #39978

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

When an incoming email on a channel is rejected, an email is sent to the
original author to inform him of the rejection. This email contains the
original email content added in a generic rejection email.

This original content was however considered as plaintext and escaped. Result
was quite hard to read. As content is sanitized we can safely append it to
the rejection email as valid html.

Task ID 2121319
PR #39978

From Sale create a new (or edit) SO. Add a note to the order with a log
line without dash or whitespace (i.e. a url). Click on "Preview".

The sale portal will try to display the long line which will overflow
the standard size of the column creating an ugly overflow with a very
long horizontal scrollbar.

Adding a "break-all" rule to fix the sale portal case.

opw-2088589

closes odoo/odoo#39966

X-original-commit: 28afbaf5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Fixes https://github.com/odoo/odoo/pull/39583


This commit adds a default value for  event_count
Assigning default value for non-stored compute fields is required in 13.0

closes odoo/odoo#39611

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>