steps to reproduce:
- enable analytic
- open journal items in list view
- select one item, set an analytic account
- select the same item, click on the analytic account, click on the save button (floppy disk)
- pop up opens
- close it

Issue:
Traceback

Cause:
In multiEdit mode, the main element cannot be focused in

opw-3463911

closes odoo/odoo#135141

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

Steps to reproduce:
1. Install hr_attendance
2. Go to attendances
3. Select any line
4. Change the check-out date to next day
5. Change the check-out time to 00:00:00
6. Export that line, file format xlsx
7. Favorites > import records
8. Upload the exported file > Test
9. Column check_out contains incorrect values.
Error in line 2: unconverted data remains: 2023-06-11

Cause of the issue:
options.get('date_format') is empty

opw-3374883

closes odoo/odoo#136393

X-original-commit: 973af585
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>

[Problem]
Before this commit, depreceted accounts were visible in the suggestions.
To reproduce:
- run odoo 16.0 (onward) with modules: account,account_accountant
- deprecate all, but 3 accounts (UPDATE account_account SET deprecated=true WHERE id>3;)
- go to: invoicing app -> Vendors -> Bills -> New
- pick a vendor -> add a line -> click on dropdown in the Account column
- see the deprecated accounts are showed in suggestion (we don't want deprecated accounts in suggestions)

[Solution]
Modified SQL query, such that only not deprecated accounts will appear.

[Testing]
Created test in test_account_account:
It runs function with modified sql query twice:
- with certain account not deprecated -> extected that this account appears in the results
- with the same account deprecated    -> extected that this account won't appears in the results

opw-3485768

closes odoo/odoo#135884

Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>

Currently, errors occur when generating the e-invoicing for
ZATCA (Saudi Arabia). This is because currently, users create invoices without
a tax, but in Saudi Arabia, the invoice line must require at least one tax.

The validation error is present at Line [1], but due to recent changes in
Code [1], the validation is not working. As a result, the user can create an
invoice line without tax.  see https://github.com/odoo/odoo/pull/130034.

This commit fixes the above issue by filtering invlocice line ids
that have display_type 'product'.

Line [1]-https://github.com/odoo/odoo/blob/d2f0a0f2c9a18a7a6cef8ca3be52324ad2a1dad6/addons/l10n_sa_edi/models/account_edi_format.py#L406


Code [1] odoo@d8d47f9#diff-78f3e1847de8ca0acf28d72a412947a549acdb08142d1dadf7646363d7972cb0R268-R280

sentry-4467808485, 4467794808

closes odoo/odoo#135737

Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>

To reproduce
============
- create a purchase order and confirm it
- create a Bill, set its Bill date and Accounting date to different dates
to today
- save it, then choose the created PO in autocomplete field
the Accounting day will be changed to today

Problem
=======
when calling the autocomplete, some values will be updated on the record,
where `move_type` is one of them, and updating this field will trigger the
compute of accounting date.

Solution
========
if the value of `move_type` on the record is the same as the one of the update,
it should not be taken into account which will avoid uneeded recompute.

opw-3381530

closes odoo/odoo#132841

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:
- Enable product packaging
- Create a Package for product P and set the barcode
- Delete product P
- Create a new Package with the same barcode

Bug:
barcode already exists

Fix:
delete Package when associated product is deleted

opw-3507931

closes odoo/odoo#136305

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

*: website_event

Without this, the seo saving would not forward the current website in
the context. It's especially bad in this case as it's writing on views
which are not triggering the COW due to the lack of a website_id in the
context.

Step to reproduce:
- Go to /shop (if you didn't do anything, this will be bound to the
  `website_sale.products` view which has no website_id set and is called
  a generic view)
- Open "Optimize SEO" dialog and type something in the title
- Save
- It saved the change on the mentioned view, without duplicating it
  (COW) before writing on it. The title you added is now applied to
  every websites and not only the one you edited, which is against the
  website holy grail rule: only the website you edit should be changed.

Technically, this is because we refactored that part of the code in Odoo
16: the website is now editable in the backend.

Note that this fix also revealed that a test for events (which has been
introduced with [1]) was relying on the bug: it tested the meta title of
a view that should (and will after this fix) have been COW'ed. This test
will now indirectly protects this bug from re-happening, although we
might want to write a dedicated test in the future as the behavior for
events might need some refactoring.

[1]: https://github.com/odoo/odoo/commit/2072a7739eb9a9ee87c8b3c7b0d43a82a7e2375f



opw-3499285

closes odoo/odoo#136084

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

payment_stripe was missing in .tx/config, resulting in the module not
being available for translation on Transifex.

closes odoo/odoo#136380

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

This is just a typo XD

closes odoo/odoo#135608

Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit:

-With selection on checklist, on unchecking it toolbar is not updating.

After this commit:

-Now toolbar is updated when list unchecks.

task-3504398

closes odoo/odoo#135422

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit:

Indenting list using tab inside a table used to switch to the next cell.

After this commit:

Indenting list using tab inside a table now indents a list instead of switching
to the next cell.

task-3470092

closes odoo/odoo#132508

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit:

when selected cell is clicked, its selection collapses yet toolbar is visible.

After this commit:

Now toolbar is removed when selection collapses.

task-3458048

closes odoo/odoo#131339

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Report footer is sometimes misplaced in settings preview.
We change the css to always stick to the bottom of the preview,
no matter the content height.

Task-3145445

closes odoo/odoo#128552

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Report body size was too narrow to render bootstrap .col as column,
the media query consider the report as a mobile view.
We unlock this limitation to let customer add column in the footer.

Task-3145445

Part-of: odoo/odoo#128552

Before this commit:

When we load some themes without installing website the social media icons look
weired and margin between those icons is also weired.

After this commit:

Now when we load mass_mailing themes without installing website the social media
icons same as before and margin between those icon is also same.

Task-3347902

closes odoo/odoo#125527

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Upgrade (aka migration) scripts are a core part of Odoo, allowing
database manipulations for modules during version changes.

Any module, including custom ones can run upgrade scripts, even if the
`--upgrade-path` flag (and with it, the `odoo.upgrade` sub-module) is
not present. Currently only the "standard" modules benefit of easy
upgrade script testing. Any custom modules that want to run tests of
their upgrades have to import the tests in the usual `tests` folder,
which is not ideal.

Therefore, to allow TDD and programmatic testing of upgrade scripts in
custom modules, the test discovery is here modified to also parse the
module's `migrations` and `upgrades` sub-modules for tests.

closes odoo/odoo#136201

X-original-commit: e8683726
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Steps:

In a website forum post without any previous scrolling, select some
text. A traceback appears due the fact that there's no .o_action_manager
element in website forum.

This commit uses the document body as a fallback for the scroll
container when the .o_action_manager element is not present.

task-3506312

closes odoo/odoo#135785

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Update of right state key for rerender the image on record change from OWL

Included tests from commit 94db69453616131f6913b65a58b76df712ede35d by @FrancoisGe

Fixes #134454

closes odoo/odoo#134477

Signed-off-by: Francois Georis (fge) <fge@odoo.com>

1. Backport of [1].
2. Steps to reproduce:
- Install website_crm
- Connect as Admin and remove the sales rights for Demo
- Check the website on a private window (to create an anonymous visit)
- Connect as Demo on the normal window
- Go to Website > Reporting > Visitors
=> It triggers an access error due to lead_ids being restricted to
sales_team.group_sale_salesman.
(Note: the error sometimes isn't triggered at that point. In that case,
click on the visitor: the same error will trigger.)

Considering the computed field doesn't do anything critical as it just
retrieves the email and phone number, the restriction is overridden on
the field.

[1]: https://github.com/odoo/odoo/commit/7de453477d7c23e607a15e0d60613080857e3371



opw-3475301

closes odoo/odoo#136353

X-original-commit: 70faf9bb
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Robin Lejeune (role) <role@odoo.com>

After commit [1], the check that the target url is different from
the current page's url has been removed thus leading to error that anchor
link always scroll down to element that have data-anchor enabled.

Steps to reproduce (the easiest way):
- Install Website Blog
- Turn on customize comment on post
- Go incognito then access any blog post, scroll down and click the
`Sign in to leave a comment` button
- Holy, the page scrolls down to the discussion section but doesn't go
to the login page

[1]: https://github.com/odoo/odoo/commit/fb087dbec96f5e533d1fdd9c2b0c2e00296c83de



closes odoo/odoo#136043

X-original-commit: f5fca171
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>

closes odoo/odoo#136040

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#33682

Signed-off-by: bve-odoo <bve@odoo.com>

Prior this commit:
The mail scheduler of the event notifies the attendees even when the event is
no longer active.

After this commit:
Inactive events no longer notify attendees.

Task-3381876

closes odoo/odoo#136324

X-original-commit: d23566c3594454c62bb5c177db1d28a8c29a59ca
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

In the din5008, there has been problem in the display of the paper format either
in the pdf or the preview.

In the preview we had a part of the page on the right that wasn't used caused by
the negative margin and the width of 180mm. But by removing that the pdf is
broken, the header is hiding some information.

To deal with that, we will add the width and negative margin only for the pdf
by adding a conditional css classes.

Also,it seems the footer with the company details can go out of page, by adding
a text-wrap on it, it solves this issue.

(In this commit, we override part of those commit:
https://github.com/odoo/odoo/commit/481f442f4ef176072edf3261415dbb06f8a3bc6f
https://github.com/odoo/odoo/commit/f7812ae848e0a79adcd11f936f6cd7890da00112

)

closes odoo/odoo#136367

X-original-commit: 3f7ca1baba444d5e0c4c92274d7095c5916918a5
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

If somehow there is no selection but the `_handleShortcuts` handler still gets
called with `CTRL+A`, `container` would be a JQUERY object instead of an
element leading to a crash in `selectNodeContents` which expects a `Node`.

task-3506666

closes odoo/odoo#136319

X-original-commit: 4feaca67
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Damien Abeloos (abd) <abd@odoo.com>

The method get_resource_path is redundant with file_path but without
all the checks.
The method will be deprecated in master but make it use file_path in
stable.

closes odoo/odoo#136206

X-original-commit: 64ab4a69
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#136246

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

On Database having a postgresql server version superior or
equals than 14.0, a feature called memoization is caching
result of the lateral join made in this query.
This cache creates an issue that results that customers
have the same result for their bank journals.

By adding a LIMIT 1 at the end of the lateral join query,
the memoization is not enabled (according to query plan).
Another solution could be to change the condition of this
lateral join (currently ON True) for a condition on the
journal id but it was less efficient.

opw-3422495

closes odoo/odoo#136161

Signed-off-by: William André (wan) <wan@odoo.com>

Problem
---------
When you go in the settings -> layout (debug mode) -> select external
layout --> preview document a traceback appears due to infinite looping
in the view definitions.

Solution
---------
This field is highly technical and should not be fiddled with by users.
For such reason, we set it as `readonly`.

task-3479152

closes odoo/odoo#133790

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

This commit updates the web.pot file following changes in https://github.com/odoo/odoo/pull/135294

.

closes odoo/odoo#135523

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/229c5635 [REL] 16.0.19
https://github.com/odoo/o-spreadsheet/commit/c02066a3 [FIX] header_size: decouple added row from base row Task: 3510863
https://github.com/odoo/o-spreadsheet/commit/ee39dbb7 [REF] drag&drop: stop using CUT/PASTE commands Task: 3502194
https://github.com/odoo/o-spreadsheet/commit/d7806c0a [FIX] deepEquals: fix simple type comparison Task: 3479451
https://github.com/odoo/o-spreadsheet/commit/5a2ee636 [FIX] clipboard: copy/paste of CF in another sheet Task: 3479451
https://github.com/odoo/o-spreadsheet/commit/def91b6c

 [FIX] GridOverlay: Hovering over a figure should not open popovers Task: 3475001

closes odoo/odoo#136237

Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

Before this commit:
In the survey, when you start a live session and click on the URL the `copied`
popover appears but doesn't go away.

After this commit:
Now that popover will close automatically.

Reason:
There was already a `tooltip` instance on the element and we try to add the
`popover` on that element which causes an issue.

Task- 3458901

closes odoo/odoo#132956

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Current behavior:
When refunding an order, the lot_id of the original order was not set
on the refund order.

Steps to reproduce:
- Create a product with tracking by lot
- Open the POS and add the product to the order
- Set a lot on the product
- Pay the order
- Refund the order
- Check the lot on the refund order, there is no lot set

opw-3485740

closes odoo/odoo#136162

X-original-commit: 218c8d519e1a78cf2e15b556a4f298cf1ef0231d
Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>

When you are using a different currency in a PoS config, invoicing
a POS order that was created in a previous session, causes an
unbalanced entry error. Because the amount_currency and balance of
the payment moves are incorrect.

Steps to reproduce:

- Create POS config with currency other than company currency
- Create order in a session
- Close the session
- Open a new session
- Load paid orders
- Try to invoice the created order

opw-3479292

closes odoo/odoo#135280

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

If the currency_id and cost_currency_id is different for a product, the cost in the purchase order is wrong. The purchase order should use cost_currency_id instead of currency_id.

Steps to reproduce on runbot:
-Set the currency of main company as Dollars (USD).
-Choose in runbot the company "My Belgian Company" as its currency is Euro.
- Add the currency rate of today between EUR and USD
- Take a product and edit the cost to 100 EUR - as the cost field is linked with the currency of the company
make sure on the tab purchase there is no information - so the vendor pricelist is not present.
- Go inside the purchase module and start a request for a quotation
leave the currency as EUR
- Select the product to purchase

Current Behavior:
The unit price will be (100*currency rate). If you do the same but take the currency as USD the product unit price on the purchase order line will be 100

Expected Behavior:
The unit price should have been 100 Euros. And when dollar is chosen as currency, the exchange should have been applied.

OPW-3460551

closes odoo/odoo#133024

Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>

Use the same method and date used to compute the rate on aml field currency_rate

closes odoo/odoo#134709

Signed-off-by: Josse Colpaert <jco@odoo.com>

Steps to reproduce
==================

- Use a mobile viewport
- Create a quotation
- Add an order line
- Set a packaging
-> The Packaging Quantity field is missing

The same happens on purchase orders

---

opw-3504829

closes odoo/odoo#136163

X-original-commit: c5d665cc2b43a0040c3f5644265e74048c3d5ded
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

Steps to reproduce:
1. Have 2 companies, and select the one w/ the highest ID
2. Create a new product tracked by lot + expiration date
3. Receive product
4. Set the received lot's expiration and alert dates in the past
5. Inventory > Operations > Run scheduler

Before this commit:
An activity is created on the lot for OdooBot,
despite the product's responsible set to the current user.
It happens because the default value for `responsible_id` is the current
user, but the value is only set for the current company. When the
scheduler runs, it doesn't set the company; therefore, it takes the
product's responsible user for the company with the lowest ID, which is
not set.

After this commit:
The activity is created for the product's responsible user using
the lot's company.

opw-3489340

closes odoo/odoo#136125

X-original-commit: dacfa844
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Walravens Mathieu (wama) <wama@odoo.com>

closes odoo/odoo#103864

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>