Skip to content
Snippets Groups Projects
  1. Jul 09, 2018
    • otakuto's avatar
      [CLA] Tact Yoshida signs Odoo CLA · 9bce0361
      otakuto authored
      Done at #25662
      9bce0361
    • qsm-odoo's avatar
      [FIX] *: fix some side-effects of... · 2c966909
      qsm-odoo authored
      [FIX] *: fix some side-effects of https://github.com/odoo/odoo/commit/9de1bc0eef6f5bfaa2a8d745431caa361ae91548
      
      - JS Modals were not correctly built anymore, their .modal-body element
        was duplicated and many without-effect JS lines were introduced (as a
        side effect, the form view design was broken when inside modals)
      
      - Tests were changed to make bugs go unnoticed. For example, the media
        dialog functionnality was entirely broken because the .modal-dialog
        element was not receiving the correct class anymore.
      
      - The JS translation function is _t, not _
      
      - Do not use the <title/> tag as a regular DOM element, it is meant to
        be unique, in the <head/> section
      
      - CSS rules were added to the utils.scss file, which is meant to contain
        functions and mixins, otherwise, the rule is duplicated in every asset
      
      - Some icons were still broken, as missed by https://github.com/odoo/odoo/commit/f90cf060a3cfeb37a67bec83264c0aaab8892b56
      
      - Tests were changed to use [role="dialog"]/footer/header in their
        selectors without any reason, this commit restores some of that to
        avoid rebase conflicts with the BS4 work.
      
      - ...
      
      Note: other elements should still be discussed, like the direct use of
      the 'o_form_label' class in views definition... but those do not cause
      direct problems.
      2c966909
    • Fabien Pinckaers's avatar
      49a90532
    • Olivier Colson's avatar
      [REF] account: recipient bank account available in payments · a33961f2
      Olivier Colson authored
      This field is somewhat generic, as anyone could want to specify it and as it is used by several batch payment methods. It is thus now factorized in the core module.
      Enterprise module 'hr_expense_sepa' is thus not needed anymore as its code can be put in hr_expense
      
      Was part of task 33323
      Was PR #25562
      a33961f2
  2. Jul 06, 2018
  3. Jul 05, 2018
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      45329c0c
    • wangting's avatar
      [CLA] signature for tanghulu0608 · d4578794
      wangting authored
      Closes #25625
      d4578794
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
    • Martin Trigaux's avatar
      [FIX] mail: multi-company access to TZ · a978a364
      Martin Trigaux authored
      - Create 2 Companies A & B
      - Set User B in Company B
      - Record some `mail.activity` for User B on a lead belonging to Company
        B.
      - With a manager user in Company A, go to Kanban view of leads and
        remove filters => all leads, including leads in Company B, are
        displayed
      
      An access error occurs.
      
      `read_progress_bar` method, tries to access the field `activity_state`
      which is: `states = record.activity_ids.mapped('state')`. The state of
      a `mail.activity` is using the tz of the partner. To read the
      `activity_state` of a lead, one needs to access
      `record.activity_ids.user_id.partner_id.tz`
      => multi-company security rules raised
      
      opw: 1850984, 1859470
      a978a364
    • Quentin De Paoli's avatar
      73d664f7
    • Christophe Simonis's avatar
      92e5da6b
    • len-odoo's avatar
      [FIX] web: handle onchange on a on2many with an embedded one2many on multiple pages · 7764db7a
      len-odoo authored
      Suppose there is a one2many field embedded in a one2many,
      (say we are viewing record A with one2many field B itself with a one2many C).
      Furthermore, there is a second page of the one2many field B.
      If an onchange is applied on B, then the server replies with a 1 command for all
      B records attached to the currently viewed object A.
      This includes a list of commands [[5], [4, C_id]*] for each B record,
      in particular B records that are on the second page.
      Since they are on the second page, they might not have been fetched by the
      frontend; in that case the corresponding C_ids are thus unknown.
      As a consequence, on save the frontend sends a command 0 to create the records
      for all unknown C_ids.
      Since it doesn't have any value to give to the 0 command, the row creation
      usually crash in the backend.
      
      Another wrong behaviour is fixed at the same time: if the server sends an update
      on the list of C ids with 4 commands.
      In that case, if the record has not been prefetched, we have no way to know
      if the list changed or not.
      
      To solve this, when we receive the 4 commands by the server, we send back 4
      commands.
      
      coauthored by @aab-odoo
      
      opw 1835936
      7764db7a
    • Christophe Simonis's avatar
      26e7d5d8
    • Géry Debongnie's avatar
      [FIX] web: make the kanban view wait on async field widgets · a1778ed5
      Géry Debongnie authored
      Before this commit, the kanban view ignored the fact that a field widget
      could be asynchronous.  Worse, some preliminary support was done in
      kanban record, but this would crash if an async widget was used.
      
      With this commit, we properly synchronize the kanban
      records/columns/renderer.  If for some reason a widget needs to be
      added to the DOM before it is ready, it can simply returns an empty
      value in the willStart/start methods.
      a1778ed5
    • Alexandre Kühn's avatar
      [FIX] web: no concurrent reload on basic model · 7af09db8
      Alexandre Kühn authored
      Before this commit, there was a traceback in the following scenario:
      
      Let's have a kanban view with groupby and a domain.
      If we clear the domain then clear the groupby, there could be a crash.
      
      This crash occurs because when we clear the groupby, it performs a `reload`,
      and assumes that the datapoint contains grouped data. However, if this
      computation takes some time, it is possible to overwrite the datapoint so that
      there is no longer grouped data.
      
      This commit fixes the issue by enforcing at most 1 execution of the method
      `reload` active at any time. Consequently, successive reloads operations are
      now much slower.
      
      Note that it uses the single non-reentrant mutex on the basic_model to enforce
      this rule, which means:
      
        - No more concurrent `reload` and `save`.
        - If an execution having the mutex in `reload` come accross the same mutex,
          it is blocked forever. This is hopefully not the case at the moment,
          however a reentrant mutex should be considered in the future.
      7af09db8
    • Nicolas Lempereur's avatar
      [FIX] barcodes: documentation in description · b27d009a
      Nicolas Lempereur authored
      The barcodes modules had documentation only available on apps.odoo.com,
      following a recent change, odoo modules are not displayed on
      apps.odoo.com anymore.
      
      Thus this commit merges the documentation onto the module description so
      it is available on the module page.
      
      opw-1846035
      closes #25621
      b27d009a
    • Romain Derie's avatar
      [FIX] website: new content links not triggered · 21f1a593
      Romain Derie authored
      Clicking outside the new content options should close the overlay.
      Every options are triggering a JS event (mostly opening a modal) that works
      fine.
      
      But the 'New Job offer' options is simply a href link which is not going
      through anymore since there was a call to `preventDefault`.
      
      opw-1860196
      21f1a593
    • Christophe Simonis's avatar
      [FIX] core: set up registry before running migration scripts · b5c50fa8
      Christophe Simonis authored
      As `pre-` migration scripts may use the registry, we must ensure that
      all fields are set up before execution in order to have a consistent
      registry.
      
      This is required when loading a registry which contains modules to
      install/upgrade without `-u` flag. In this case, the setup was only done
      *after* module loading.
      b5c50fa8
    • Pierre Masereel's avatar
      [FIX] stock: fix api multi method · 6bdc6541
      Pierre Masereel authored
      Method was using self instead of line in the loop for.
      
      introduced in rev: https://github.com/odoo/odoo/commit/ba5918ffcbe5fe9155308c53e014e5e93c588ca6
      6bdc6541
    • Jérome Maes's avatar
      [FIX] hr_timesheet: dynamic domain when encoding timesheet · ceaa6562
      Jérome Maes authored
      To have a better encoding timesheet, we want for the user:
      1/ when selecting project first, the task proposed will be
      the ones in the project. When changing project, it reset the
      task to empty.
      2/ when selecting the task first, the project will be the
      one from the task
      ceaa6562
    • Gert Pellin's avatar
      [imp] fleet: Allow to filter/group by Make on vehicles · b7bcbddc
      Gert Pellin authored
      Add grouping possibility on model make for vehicles in the fleet.
      Deleted redundent controll on make image for vehicles if model changed.
      fixed _name_search for FleetVehicle
      
      project : RD for Dummies
      task : [Fleet] Allow to filter/group by Make on vehicles
      b7bcbddc
    • Fabien Pinckaers's avatar
      [IMP] product: Unify/Clean product demo data · bed29a4a
      Fabien Pinckaers authored
      PURPOSE
      =======
      
      1. Unified product demo data
      2. Less demo: one per use case
      3. Demo data for all models
      
      Specification
      =============
      
      1. Refactor all the brol in the demo data
      2. Adapt the tests to make them green, as some products are
         renamed, removed, created in python instead of as demo data
         ...
      bed29a4a
Loading