closes odoo/odoo#106385

Signed-off-by: Kevin Baptiste <kba@odoo.com>

hr_*:
- hr
- hr_contract
- hr_work_entry
- hr_work_entry_contract

Fixes multiple visual issues in various models

task-3002444

closes odoo/odoo#102922

Related: odoo/enterprise#32638
Signed-off-by: Kevin Baptiste <kba@odoo.com>

The res.users model functions a bit uniquely since it should allow a user to
modify their own parameters but turns off model edition priviledges by default.
See "SELF_WRITEABLE_FIELDS".

This implies that ir_ui_view#_postprocess_access_rights method will by default
turn off record edition, by automatically adding a 'edit="false"' attribute on
the form node when the frontend calls 'get_views'.

This will in turn prevent the user from modifying its preferences as it will
set the form view in readonly mode.
(It was apparently ignored pre-OWL, hence why we only have this issue now).

To fix the issue, we force the edition by manually setting 'edit="1"' on our
"view_users_form_simple_modif" form.
Allowing the end-user to modify their own settings again.

A tour was added to ensure this behavior.
Note that tour steps need to be adapted in the 'hr' module, as this module
changes the flow of modifying user preferences.

Task-3067001

closes odoo/odoo#106125

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Detailed Reason field in hr_departure_wizard view is now wrapped in a group for better organization.

task-3002105

closes odoo/odoo#101743

Related: odoo/enterprise#32087
Signed-off-by: Kevin Baptiste <kba@odoo.com>

The job_title field was too narrow and misaligned on mobile.
Removed the help text for the Contacts smartbutton.

task-3070980

closes odoo/odoo#106223

Signed-off-by: Kevin Baptiste <kba@odoo.com>

The goal of this commit is to avoid the execution of code depending
on the validity of the save of a Record.

Before this commit, several override save functions in Record execute
code after the record's save without checking if the record's save has
taken place.

Override before:
export class NewRecord extends Record {
    async save() {
        const isSaved = await super.save(...arguments);
        // doAction
        return isSaved;
    }
}

Override after:
export class NewRecord extends Record {
    async save() {
        const isSaved = await super.save(...arguments);
        if (isSaved) {
            // doAction
        }
        return isSaved;
    }
}

How to reproduce the problem:
    Go to a form view with a Record having its save override function.
    Edit a record in such a way to have an invalid field
    Click on the save button

Before this commit:
The doAction is executed

After this commit:
The doAction is not executed

Real use case
- Go to the form view of a lead in CRM
- Change stage
- Clear the name field
- Click on save button

Before this commit:
A call to get_rainbowman_message is made

After this commit:
No call to get_rainbowman_message is made.

closes odoo/odoo#105468

Related: odoo/enterprise#33817
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The presence bubble on the employee form is hidden while it is shown on the kanban view of the employees.
This commit fixes the presence bubble to have a consistent behaviour between the employees kanban view and the employee form.

task-2945615

closes odoo/odoo#103779

X-original-commit: 809715958f7165aef328faf99a1d7bc7c81f9329
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: phwa-odoo <phwa@odoo.com>

Remove the call to `t-on-click` in the arch of form/kanban views as it
crashes when the view is opened in studio.

Instead use a dedicated `<widget>`.

closes odoo/odoo#103741

Signed-off-by: Kevin Baptiste <kba@odoo.com>

The label was above the profile picture and the employee name below it.

closes odoo/odoo#103664

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#103255

X-original-commit: 5ba7d6b0
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Task-3013832

closes odoo/odoo#102965

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

closes odoo/odoo#102902

Related: odoo/enterprise#32633
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

*: hr, hr_holidays, project, purchase, point_of_sale, rating,
spreadsheet_dashboard, stock, survey

This commit adapts modules and components in order to correctly handle
color-scheme variations.

task-2710677

Part-of: odoo/odoo#99755

Steps to reproduce:
- set demo to receive notifs in Odoo
- go to employees
- click "launch plan" for demo user
- login as demo user
- Click on the link for the activity that is sent in discuss

Issue:
There is no chatter in the view

Explanation:
the view of en employee coming from messaging is always
hr.employee.public that does not contain the chatter.

opw-2990577

closes odoo/odoo#102803

X-original-commit: 918ea972c74e563bf8ef3db13f3a1b9c610bca37
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Fockedey Martin (mafo) <mafo@odoo.com>

Steps :
- On a new DB (no demo data). Say created at 15:00. - Go to planning.
- Add a shift for today.
- Set the dates from 08:00 to 17:00.

Issue :
The 'Allocated Time' = 02:00.

Cause :
We used to count from the resource creation min to the departure max. So, in this case, not from 08:00, but from 15:00.
While this might seem logical, it confuses users in onboarding.

Fix :
Calculate the whole time, regardless of the resource lifespan.

Notes :
- Similar issues solved with this commit :
> Once the shift validated, the avatar progress bar uses
the same allocated time.
> Same in Project Task gantt view.
- When contract is installed, if the resource does not have a contract, the Allocated Time = 0. Now, it is calculated from the resource calendar.

task-2983993

closes odoo/odoo#102392

Related: odoo/enterprise#32378
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

The current homeworking module doesn't answer the standard of quality.
For now It will be removed from the settings and app store so it is not visible
to any users. It will return after it has been reviewed and  improved.

task-2995332

closes odoo/odoo#101093

Related: odoo/enterprise#31762
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit, only when using the save button on the profile, the
context is reloaded with the new language. If we use the breadcrumb to
exit the profile view, the new language is saved, but the context is not
reloaded.

closes odoo/odoo#102419

Related: odoo/enterprise#32396
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The "Reporting" title was not properly displayed (stuck to the left of
the dropdown) and the Timesheets entry was not displayed as a proper
dropdown item.

task-3001445

closes odoo/odoo#101744

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#102045

Related: odoo/enterprise#32243
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The goal of this commit is to fix the behaviour of clicking on a field
with the "many2one_avatar" widget in a list view.

Expected behaviour when clicking on a field with the "many2one_avatar" widget:
- Editable list view: switch row to edit
- Multi_edit list view with selected record: switch row to edit
- Other case: open the many2one_avatar record in a form view

Before this commit, clicking on a field with the "many2one_avatar" widget always
opens the record in a form view.

After this commit, the expected behaviour when clicking on a field with
the "many2one_avatar" widget is respected.

closes odoo/odoo#101737

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Model patches are now defined using the `registerPatch` function. This
function takes an object as argument which keys match those of a model
definition.

Benefits:
+ More consistent shape between model definitions and patch definitions
+ No need to import one function to each type of patch
+ No need to repeat the model name for each type of patch
+ No need to import the original definition

Task-2998282.

* = calendar, crm, hr, im_livechat, note, rating, sms, snailmail,
    website_livechat, website_slides

closes odoo/odoo#101282

Related: odoo/enterprise#31866
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

closes odoo/odoo#101288

Related: odoo/enterprise#31850
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Also clarify messages

Part-of: odoo/odoo#101288

Since commit ae7bd570e13fe19367f86a1519b23747b3b0b73e, the size of
`o_work_employee_main` has been reduced.

This commit fixes this issue.

task-2918464

Part-of: odoo/odoo#98911

The domain of `work_location_id` requires the company_id and address_id
which were missing from the tree view, showing a traceback when trying
to change that field.

closes odoo/odoo#101182

X-original-commit: 8376adc1
Signed-off-by: Kevin Baptiste <kba@odoo.com>

This commit does multiple things:
- The readonly mode of form view is removed but not for the fields.
  it means that the fields in the view are always in edit mode except
  if we force them to be readonly.
- The control panel is revamped to take less vertical space and shows now
  the record editing (dirtiness)/validity status after editing the record.
- The record is saved only when leaving the view or by clicking the save
  button when hovering the record status in the control panel.
- The record can still be discarded by clicking the discard button when
  hovering the status text in control panel.

task id: 2822553

Part-of: odoo/odoo#100570
Co-authored-by: luvi <luvi@odoo.com>

closes odoo/odoo#100958

Related: odoo/enterprise#31696
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Some views still use them.

closes odoo/odoo#100884

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Since commit [1], we use base.main_company as default value for the
address of the admin employee. This is not correct as base.main_company
is referring to res.company model while address_id is expecting a
res.partner id.

This works in most default situations as id = 1 is the same for both
res.company and res.partner, but not anymore in case we have merged
the initial partner with another one.

We should use base.main_partner instead of base.main_company.

[1]:https://github.com/odoo/odoo/commit/c0ca736193df42814389151956eb07c28c77d18e



closes odoo/odoo#100866

X-original-commit: 16316705
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Alex Thuyls (alt) <alt@odoo.com>