closes odoo/odoo#67198

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

[REF] models: use stock to implement location_out_id into the Putway Rules Menu

Description of the issue/feature this PR addresses:

On the Location/Location-ID/PutwayRule we have the fields:

location_in_id = When Product Arrives

locatio_out_id = Store To

As the products arrives in the WH/STOCK location and due the putaway rules goes to other location then we have the fields populated like:

location_in_id = WH/Stock

location_out_id = location opened in the view.

Due this domain setup the list is returning empty, and then the solution that I applied is to check if we have the location selected in the location_in_id or location_out_id and show the entries.

Current behavior before PR:

Only looking for the from into the location_in_id

After PR merged :

Looking for the values from the location_in_id or location_out_id.

--

TaskID: N/A
Fixes : PR 67198
Closes : PR 67198

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#70519

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

What are the steps to reproduce your issue ?

    1. Go to Account/Journal Items
    2. Open a posted item
    3. Change product

What is currently happening ?

    The product is changed in the account move

What are you expecting to happen ?

    The account move lines cannot be changed when the status is posted

How to fix the bug ?

    Make the field read-only when the status is posted

opw-2517325

closes odoo/odoo#70383

Signed-off-by: William André (wan) <wan@odoo.com>

BEFORE this commit query "invoices is not set" was tranformed to
query "order_line.invoice_lines.invoice_id is False", which doesn't make sense,
because invoice_id is required fields and hence always set. Hence, result of
the query was always empty.

AFTER: just check that there is no invoice_lines. Strictly speacking, is not the
same as checking result of compute method, but because invoice_lines are
supposed to be lines for invoices of out_* type, the result should be the same.

---

opw-2516124

closes odoo/odoo#70449

X-original-commit: 9accf63d
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

Before this commit there would be trackback (TypeError: unsupported operand type(s) for -: 'datetime.datetime' and 'NoneType') when you will try to remove field Start date as we are using the field to compute duration.

With this commit, we compute duration when Both fields are present.

closes odoo/odoo#59693

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

Before this commit, field`product_uom_category_id` was related to `product_id` which is not required and will be visible when Variants are not enabled so on such conditions no `Unit of Measure` was displayed. (As product_uom_category_id is False )

With this commit, we make this field related to `product_tmpl_id` which sets correct `product_uom_category_id` which thus we can see correct list of  `Unit of Measure`.

closes odoo/odoo#48687

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

* IMPACTED VERSIONS

  12.0+

* HOW TO REPRODUCE

locale :  Locale is en_US (or other SUNDAY based)
view:     CRM - My Pipeline - Kanban view
groupBy:  date_deadline:week (Expected closing)
records:  one record with a planned activity, on date_deadline = 2021-05-02 (SUNDAY)
          one record with no planned activity, on date_deadline = 2021-05-09 (SUNDAY)
remark:   don't keep any other record in MAY for better visibility

* PROBLEM

The progressbar of the week containing 2021-05-09 displays information about the record
from the week containing 2021-05-02

* CAUSE

1. PostgreSQL `date_trunc` function follows ISO8601 which essentially means that
  the start of a WEEK is always MONDAY. There is no argument to change this.

2. _read_group_format_result
  https://github.com/odoo/odoo/blob/27da86a138089c1838e4b94f8a6976995b9c1fff/odoo/models.py#L2210-L2219

  - Computes a label for a group of records.
  - Follows the locale for the label of the week, based on a date which is
    always a MONDAY because of `date_trunc`.

3. read_progress_bar
  https://github.com/odoo/odoo/blob/88957afca09662af7eaa19df1e40b3699e45e79e/addons/web/models/models.py#L167-L175



  - Associates a group label to a record.
  - Follows the locale for the label of the week, based on the date of a record
    which can be any day of the week. If the record is related to a SUNDAY and
    SUNDAY is the first day of the week, it would have been in a group with a
    different label in (2.) than in (3.) prior to this change.

* FIX

In 3., before associating a label to a record, we truncate the date to the
ISO start of the period, so that the label is determined for a record in the
same conditions than in 2. The locale is still used to get language-dependent
outputs with babel, but the grouping will always follows ISO8601 (date_trunc).

* TEST

Added a test for this problem case

TASK-ID : 2517848

closes odoo/odoo#70417

X-original-commit: d429573a1b9da91d627f84ecf44a1513fefae24c
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

It may be a recordset in case of partner duplicates. The variable
bounced_partner is simple search by email:

https://github.com/odoo/odoo/blob/72b5a17fc0e6f439d462647a7b55c9a26235a8df/addons/mail/models/mail_thread.py#L1349



closes odoo/odoo#69445

Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

Steps:
- Have a local V13 with pos_cache
- Just open a session and click anywhere

Analysis:
When trying to get the display price of the products,
it fails because the `pos` is undefined on the product.

This commit adds `pos` on product to match what was done in b4f305aa.

opw-2522293

closes odoo/odoo#70409

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When the user creates a new account analytic line, he should not be able
to create a new journal item.

To reproduce the error:
(Use demo data)
1. In Settings, enable "Analytic Accounting"
2. Accounting > Configuration > Analytic Accounts > Administrative >
Cost/Revenue
3. Create a new one
4. Click on "Journal Item" list

Error: the list contains the "Create and Edit..." option. Such an action
should not be possible.

OPW-2481197

closes #69881

closes odoo/odoo#70376

X-original-commit: f3ef533ed18c996f7f87c9596135e450479a8c19
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Have in a purchase order a first row with unit price 0
Export the PO adding unit price in the list of fields to export
The unit price is not reported

This occur because the first line of the order lines is meld with the
purchase order line but in the process the 0.0 values is discarded

opw-2510917

closes odoo/odoo#70353

X-original-commit: 242bf502
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

Display the default name (the one displayed in the kanban view) for followers replacing
the False value for "other address" partners, this way the user won't get
confused, furthermore, this fix won't require the name to be mandatory for this
type of contacts.

Task-2514244

closes odoo/odoo#70340

X-original-commit: 759054a6fe9a8583574c80fe41cb3287ce6fa147
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Some aria attributes were missing or incorrectly set on these new
buttons:
- The button "Export All" was missing an `aria-label` attribute
- The button to show/hide optional columns was also missing an
  `aria-label` attribute, and its menu items (checkboxes to show/hide
  columns) were missing a proper role
- Ever since the debug manager was added in frontend on 73327db0,
  the `aria-label` attribute was not being rendered correctly on the
  button to open developer tools

closes odoo/odoo#67803

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Description of the issue/feature this PR addresses and current behavior before PR:
There is a discrepancy in the wording of the error message provided. The error reads that an 'internal user' is linked but really its a 'portal user.'.

Desired behavior after PR is merged:
The wording of the error is clearer, and it now says 'portal user' instead of 'internal user'.

OPW: 2498139

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#69916

X-original-commit: cdd94cdd
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: Kamen Zhekov <kzhekov@users.noreply.github.com>

Using a fiscal position to map a tax to a price-included tax doesn't work.

closes odoo/odoo#68997

Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>

Scenario:

- add a file in mass mailing editor => an icon is added linking the file
- save
- edit => the icon is replaced by a generic icon
- save
- send mail => no icon is shown in email received

The system is using eg. `data-mimetype="pdf"` to show the icon, before
12.0 this worked but in saas-12.3 the system uses mailing.mailing
body_arch's field that is sanitizing attributes and remove it on save,
so the icon is only working in received email if you save one and only
one time after adding file inside the mass mailing.

opw-2474053 (ticket for similar issue in 14.0)

closes odoo/odoo#70042

X-original-commit: 7e14515b84d8081557517df7e9dc7d8c0d17f2be
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The only purpose of the module `test_documentation_examples` is to test
a few of the code examples shown in the developer documentation.

As 6709e1a9794 removes the documentation sources from the repository,
the test module is removed as well.

DOC PR: https://github.com/odoo/documentation-user/pull/945



task-2352371

closes odoo/odoo#70174

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Victor Feyens <vfe@odoo.com>
Co-authored-by: Antoine Vandevenne <anv@odoo.com>

In odoo/documentation-user#945, the developer documentation is merged
with the user documentation in a single repository and build config.

This commit then removes source files for the developer documentation
from the odoo/odoo repository.

DOC PR: https://github.com/odoo/documentation-user/pull/945



task-2351938
task-2352371
task-2205684
task-2352544

Co-authored-by: Victor Feyens <vfe@odoo.com>
Co-authored-by: Antoine Vandevenne <anv@odoo.com>

We moved the function compute_all in 13.0, but didn't let it
retrocompatbile for external modules.

closes odoo/odoo#70327

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

In 13.0 and above, when looking at a quiz that was completed while not published, it would incorrectly show 2 XP awarded, when 0 XP should be awarded.
With this commit, we show instead the correct 0 XP awarded.
opw-2480343

closes odoo/odoo#70253

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When adding a product to a repair order, the module automatically adds
all product's taxes, even if some taxes belong to other companies.

To reproduce the error
(Need 2 companies C01 and C02. Let C01 be the current company)
1. Create a product P
    - Must have a tax T_C01
2. Switch to C02
3. Edit P
    - Add a tax T_C02
4. Activate C01
5. Create a Repair Order
    - Add a customer
    - Add a line with product P

Error: Both T_C01 and T_C02 are added. However, since C02 is the current
company, T_C01 should not be added.

(Similar issue possible with `repair.fee`)

OPW-2486791
closes #68079

closes odoo/odoo#69975

Signed-off-by: Steve Van Essche <svs-odoo@users.noreply.github.com>

What are the steps to reproduce your issue ?

    1. Go to helpdesk/configuration/stages
    2. Add rating email template to Solved
    3. Change state of a ticket to Solved
    4. Go to Technical/messages and open the sent message

What is currently happening ?

    The template is not displayed correctly

opw-2476485

closes odoo/odoo#70294

X-original-commit: 9d9c5da5
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

In eg. 13.0 when refreshing sales analysis action of a product, we would
get an error because we have a single active_ids which is not expected
by the code.

With this commit, we use .toString() on the jQuery BBQ parsed active_ids
as it was done before 32b8cec5 refactoring (january 2018).

The added test with the fix fails with an error:

  TypeError: state.active_ids.split is not a function
  at Class.loadState (/web/static/src/js/chrome/action_manager_act_window.js)

opw-2471982

closes odoo/odoo#70226

X-original-commit: a8c731092b7aa95bca46f56f6c069e1c1a8a2292
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Co-authored-by: Nicolas Lempereur <nle@odoo.com>

Before this commit, the routing map generated and used would be the one from
the website the request is performed, instead of the one from the `fw` website
ID which will be the one we redirect the user to.

This issue was introduced with the routing map by website, be8fc229 and is
restricted to a single case: a publisher using the website switcher, and it
won't happen on next page naviguation/refresh as the `fw` website id will be
the same as the current website's ID. Thus there won't be any routing map
mismatch.

Step to reproduce:
  - Create a page on website 2, set it as homepage
  - Naviguate to website 1 on '/' url
  - Naviguate to website 2 on '/' url
This will raise a werkzeug error about `EndPoint not iterable`.

----- Technical analysis ------

This is the current flow:
1. `_dispatch()` is setting `website_routing` to `get_current_website()` -> 2
2. `_dispatch()` is calling `_match()`
3. `_match()` is calling `routing_map()` with key = `website_routing`, which
   was set to 2 in step 1.
4. `routing_map()` is calling `_generate_routing_rules()` which generate the
   rules based on `website_routing`, which was set to 2 in step 1.
5. `_dispatch()` authenticate the user by calling `_authenticate()`
6. `_dispatch()` is calling `_add_dispatch_parameter()`, where URL param `fw`
   is forced in session, so `get_current_website()` now return the correct
   `website_id` -> 1

The issue: in order to handle the `fw` URL parameter (step 6.), we need to
check the rights to ensure we can allow the website switch.
To check rights, user need to be authenticated (step 5.), which is done after
generating the routing map (2. & 3. & 4.).
The routing map is generated based on the current website (step 1.)

Step 6 depends of steps 5 which depends of steps 2/3/4 which depend of step 1,
but step 1 should depend of step 6, which is an impossible cycle.

closes odoo/odoo#69416

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Issue

	- Install 'Survey' app
	- Enable "es_VE" language and activate on main website
	- Create a survey:
	- Add a question of type 'Date' then save
	- Click on "TEST" button
	- Start survey and add a date with the datepicker
	- Submit survey

	Error message / traceback.

Cause

	The date format is wrong because since locale params
	only after page survey widget is loaded.

Solution

	Use 'session.load_translations()' to load translation.

opw-2452237

closes odoo/odoo#69507

Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

This "depends context" was missing fields and the compute of the stock qty's were not correct in several cases.
We add the same as the fields "force_company".

closes odoo/odoo#68046

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

When selling a tracked product that comes from a specific place in the
warehouse, the module will ignore this information and set the parent
warehouse as source location.

To reproduce the error:
(Use demo data)
1. In Settings, enable "Multi-Warehouses"
2. Create a product P:
    - Product Type: Storable Product
    - Available in Pos: True
    - Tracking: By Unique Serial Number
3. Update its quantity:
    - Location: WH/Stock/Shelf 1
    - Serial Number: USN01
    - Qty: 1
4. Start a POS session
5. Sell P
    - Enter the same serial number
6. Go back to quantity update page for product P

Error: The quantity for "WH/Stock/Shelf 1, USN01" is still 1, it should
be 0. Moreover, a new line appeared: "WH/Stock, USN01, -1" which is
incorrect. The POS module considered that the product sold came from
WH/Stock instead of WH/Stock/Shelf 1.

OPW-2473002

closes odoo/odoo#70165

X-original-commit: dd62f84e
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Make translation work for "Visitor" that was appearing in livechat
session to the visitor.

opw-2504461

closes odoo/odoo#70139

X-original-commit: 738ef4ce8040abc7c11a578b6208162d39a686f7
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

While a listen backlog of 1 isn't needed, removing the entire listen
call was too much, because accept needs it to be there.

closes odoo/odoo#70120

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Make translation works for "Website Visitor" that was appearing when a
logged-out user open a livechat session.

note: list comprehension has to be removed since translation only search
language in direct calling method closure.

opw-2504461

closes odoo/odoo#69439

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Give a coherent group as otherwise we could have access errors. Simple
case: an Admin Rights user goes into a mail message form which is only
available in debug mode which sets `group.no_one` into such user. This
model is only readeable by `base.group_sytem` so an AccessError will
raise.

closes odoo/odoo#70102

X-original-commit: 8930e082
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before the tests were using data from the demo data. Now the data used for the test are declared before the test starts.

closes odoo/odoo#61631

Related: odoo/enterprise#14705
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

This fix displays the price with tax included on the product screen and not only on the order.

When changing the product price precision, this can lead to incorrect
stock valuations.

To reproduce the error:
(Enable debug mode)
1. Go to Settings > Technical > Database Strucutre > Decimal Accuracy
2. Edit Product Price:
    - Digits: 4
3. Create a Product Category PC:
    - Costing Method: FIFO
4. Create a Product P:
    - Product Type: Storable Product
    - Product Category: PC
5. Create a RfQ with product P:
    - Quantity: 1000
    - Unit Price: 0.035
6. Confirm Order, Receive Products, Validate
7. Click on Valuation

Error: The total value is equal to $40 instead of $35. The calculation
was done after rounding the unit price: $0.035 becomes $0.04, then
1000*0.04=$40.

When confirming the RfQ, a stock move is created. To do so, the method
`_get_stock_move_price_unit` is called. When validating the delivery, it
recomputes the unit price thanks to method `_get_price_unit`. In both
situation, and if the line has taxes, the method `compute_all` is called
like this:
```python
price_unit = line.taxes_id.with_context(round=False).compute_all(price_unit,
	currency=line.order_id.currency_id, quantity=1.0)['total_void']
```
But here is the problem. In this method, total amount is computed with
this line:
```python
base = currency.round(price_unit * quantity)
```
However, `quantity` is equal to 1 and the multiplication is rounded
using the currency precision. As a result, `base` is equal to $0.04.
Then, all computations will use this value and will be incorrect.

This fix applies the real quantity so `base` will have the correct
value:
```
base = currency.round(price_unit * quantity)
     = currency.round(0.035 * 1000)
     = 35
```

OPW-2472192

closes odoo/odoo#69297

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

This can happen if the terminal had a power reset, or a network cable
was unplugged temporarily on the terminal or IoT box. It will try to
reconnect, but the box wasn't aware the first connection was gone and
would ignore the second connection. So the terminal was waiting for
a response on the second connection and the IoT box was waiting for
data on the first connection resulting in a deadlock.

This solution closes the first connection and replaces it with the
second.

opw-2432864

closes odoo/odoo#65456

Related: odoo/enterprise#16099
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Now we try to open a socket every 3 secondes
It generate some issue for connection of Ingenico
Terminal.

Now we open a socket in the initialization of the socket
interface and listen all devices that send request to
Iot.

opw-2432864

Steps to reproduce the bug:

- Let's consider a project P set with analytic account AA and company C
- Allow timesheet on P
- Let's consider a task T belonging to P
- Set AA with comapny = False
- Try to encode a timesheet on T

Bug:

A UserError was raised because the field company_id on account.analytic.line is required

opw:2486034

closes odoo/odoo#69841

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>