**Steps to reproduce**

* Define "Purchase Order" sequence for using date ranges checking "Use subsequences per date_range".
* Change sequence prefix to "PO/%(year)s/".
* Create a purchase order with order date in 2020 (a different year than current one).

**Current behavior**

Got a purchase order with 2019 (current year) number.

**Expected behavior**

Got a purchase order with 2020 number.

closes odoo/odoo#37762

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

**Steps to reproduce**

* Define "Sales Order" sequence for using date ranges checking "Use subsequences per date_range".
* Change sequence prefix to "SO/%(year)s/".
* Create a sales order with order date in 2020 (a different year than current one).

**Current behavior**

Got a sales order with 2019 (current year) number.

**Expected behavior**

Got a sales order with 2020 number.

This issue is relevant for MX Localization because Cash Basis is created
with the rate of the payment, and not with the rate of the invoice as is
done for odoo core.

closes odoo/odoo#38386

X-original-commit: 10bb81c8
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When pos_hr was installed, `load_models` was called twice for res.users
and calls to `load_fields` were not processed correctly.

closes odoo/odoo#38374

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

A scrollbar appeared every time a receipt was printed. To fix this,
we put a height of 0 to the div that contains the receipt.

html2canvas then had trouble computing the height of the background.
There's a `height` option that can be given to the library but if the
logo on the receipt was not loaded yet, the size we computed was wrong.
We then compute the height only once the images have been loaded, in
the `onparsed` method.

We also remove a CSS class that wasn't used anymore.

Install the website, install a second language.
Switch the language on the website: error 500.

The function opened a new cursor, to update website_visitor.
It did so at the end of the query dispatch.
However when switching the language of the website, the lang is written on the
website visitor. This is done at the flush, done at the end (exit) of the query.
This is done on the cursor that was used for all the transaction.
Therefore that write would systemically fail on a
ERROR: could not serialize access due to concurrent update

opw 2080986

closes odoo/odoo#38372

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Variants are generated depending on the configuration of attributes
and values on the template, so copying them does not make sense.

For convenience the template is copied instead and its first variant is
returned.

closes #38151

closes odoo/odoo#38303

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

if partner_ids and template_id are set, a traceback happens.

Indeed, some mail fields are not taken from the res_ids when partner_ids
is set.

When trying to update the values with the one from the template, the
existing values are popped, which raised an error as those keys weren't
set.

closes odoo/odoo#38427

X-original-commit: c8ad6147
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

In the backend, when a mailing popup was being edited, it was not
centered in the edition area (and went under the editor UI) and was not
using the correct style.

task-2083465

closes odoo/odoo#38421

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Variants are generated depending on the configuration of attributes
and values on the template, so copying them does not make sense.

For convenience the template is copied instead and its first variant is
returned.

closes #38151

Part of https://github.com/odoo/odoo/pull/37135


task-2070507

closes odoo/odoo#38342

X-original-commit: a273a53d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Part of https://github.com/odoo/odoo/pull/37135
task-2070507

X-original-commit: b289170f

The product count was not returned in the product page thus the search
count feature that you can enable in the customize was broken.
Now we reset the search in the product page.

Part of https://github.com/odoo/odoo/pull/37135
task-2070507

X-original-commit: db5447f8

Fixes https://github.com/odoo/odoo/issues/38308


payment_term_id has been replaced by invoice_payment_term_id

closes odoo/odoo#38309

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce:

- Export a partner with country set to False, using EXCELL
- Try to import it with the xls file

Bug:

It raised: "No matching record found for name 'False' in field 'Country' at row 2"

opw:2080376

closes odoo/odoo#38370

X-original-commit: 01caf1e4
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#38368

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#37846

Signed-off-by: Josse Colpaert <jco@openerp.com>

It is possible to select "System (English)" as chosen language,
or False in v12 or earlier versions.
However, if the language has not been activated,
then record_lang is an empty recordset, so record_lang.date_format is False,
(respectively time_format), and so the formatting crashes.

Note that if this happens, the calendar notification mechanism generates a crash
at each page load.

Instead we use get_lang which defaults to the most appropriate activated
language: the one given in argument if it exists, or the company one.

co-authored with @mart-e

closes odoo/odoo#38357

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When recruitment is duplicated, `emp_id` should not be copied for obvious reason.

closes odoo/odoo#38136

Signed-off-by: Romain Libert (rli) <rli@odoo.com>

Since https://github.com/odoo/odoo/pull/34297

, sudo() allows to keep
current user information when creating/modifying records.

There is no need anymore to use with_user(SUPERUSER_ID) to have sudo rights.

This commit ensures the user information is kept when creating pos sessions,
instead of having OdooBot as create_user.

closes odoo/odoo#38062

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

If there is no product in the recently viewed product snippet, it will
simply not be shown. It appears only if there are products (with some
flickering we may decide to improve in future versions).

Also fix the behavior when the last product of the snippet is moved to
the cart.

task-2076271

closes odoo/odoo#37371

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

Reconcile the stock output lines of the pos.order invoice
for products with real-time valuation. This is to be more
consistent with the sales module.

closes odoo/odoo#35901

Task-id: 2048668
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Since 5cf9d55b, attachments are always records.
Before, they could also be named tuples, so helpers were needed.
Since they are now useless, we can remove them to clean up things.

closes odoo/odoo#38164

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

In fact, "not filename.endswith('.pdf')" does not
"Check if the attachment is a pdf".
Some pdf files have filenames with a pdf extension, but .PDF, .Pdf
work generally just as well, and it's also possible to live without a file
extension.
In any case, it doesn't prevent from crashes because of corrupted files,
or files that are not pdf files but have the extension.

opw 2075933

If a field does not exist, writing it creates a warning in the logs.
This would for example prevent a valid test to pass.
This is needed because extract_state is a field from account_invoice_extract,
which is not a dependency of account_facturx.

When there are many events at the same moment in a calendar,
events are thin and on mouse hover the event take all the width.

Before this commit, when we drag or we resize a event in calendar,
the event returns to the state thin.

After this commit, the width event stay width during resizing and
draging.

closes odoo/odoo#37334

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

This fix is similar to 80200333; both are workarounds for the bug (limitation)
introduced by 9d87d15d.
In this case, the currency_field is a related field, and these fields are only
computed after scalar values are written in database.
As a result, this value is not rounded at creation.

It is a problem since typically accounting reports are written directly in SQL,
and thus reuse the values directly.
Anyway even in the ORM the convert_to_cache optimised this away using the
assumption that 'the value should have been rounded in convert_to_column'.
It follows that in the report, errors can be accumulated
to the point where the report is not balanced.
This needs to be fixed in database by going through every existing line.

Of note: the limitation that was readily acknowledged has not been worked around
anywhere, in fact almost every single currency_field is a related one.
Also of note, commit afef71d6 should "Always round monetary values in database"
while it explicitly checked for the presence of the currency_field in the values
and while not introducing a mechanism to make sure it would always be in the
values.

opw 2066849

closes odoo/odoo#38341

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Allow the edition of Lead Time only when the SO is not confirmed yet
since the modification of the scheduled date on an existing picking is
not expected.

opw-2083070

closes odoo/odoo#38337

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

* web_editor

The purpose is to force our dropdown style in our UI so that themes do
not break it anymore (same way all the other elements are forced (cards,
headings, etc)).

task-2059538

closes odoo/odoo#38297

X-original-commit: 4ef0eac5
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

This controller never really worked in the last 3 versions.
It was fixed in 11.3 with e9350993 but broken with refactoring in 12.0 at a
higher level with 19eacf7d.

It was even worse in 13.0 as it was leading to a traceback: `view_type` field
got removed with 3cd7ed07 but this controller was still reading that
field.

closes odoo/odoo#38173

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Avoid trailing space:
In translation content, these tends to be skipped during translation,
making the message inconsistent. There is already a translation for
the term without the space so can reuse it.

Merge "setup"
Use the same writing to avoid having two similar messages

Remove unnecessary comma

Merge PayPal and Paypal

Courtesy of Primesh on Transifex

closes odoo/odoo#38154

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Courtesy of primes2h on Transifex

Install both Sale Management and Invoicing. Create an invoice without
any line, save it and cancel the entry. Print the canceled invoice,
traceback.

The python's `max` function requires an non-empty iterable to retrieve
the maximum element. For line less invoices, the value must be None.

closes #38175

closes odoo/odoo#38197

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

On l10n_latam_invoice_document, if a sales/purchase journal use documents, then the journal sequences are not used, with this improvement the user don't see fields that are no needed (Credit Notes Next Number) and also it avoids the creation of the refunds sequences that is not going to be used

closes odoo/odoo#38312

Signed-off-by: Josse Colpaert <jco@openerp.com>

* Ensure compute always sets partner_id.
* Don't show "to" when partner_id is not set

closes odoo/odoo#38264

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

closes odoo/odoo#38306

Signed-off-by: Christophe Simonis <chs@odoo.com>

The replenish action shouldn't be accessible through the action dropdown 
(it makes no sense to replenish consumables or services).
It is already accessible on the product/template form when applicable.

Closes https://github.com/odoo/odoo/issues/38238



closes odoo/odoo#38239

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Group the upgrade of upstream dependencies with the installation of a
new theme into a single install/upgrade operation.  This fixes cache
misses occurring when accessing the state of a module after having
upgraded other modules.

closes odoo/odoo#38209

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Co-authored-by: Sébastien Theys <seb@odoo.com>

We update the version of the build for IoT Box

closes odoo/odoo#38293

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>