closes odoo/odoo#67237

X-original-commit: 42291b95
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Missing line in 24c32607 forward-port (only for 14.0).

opw-2451571

closes odoo/odoo#67240

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Before this commit, if we replaced an icon of the showcase snippet
with an image, this image was streched depending on title size (if too
long and on 2 lines). Its because the align-self default value of a
flex item is strech.

task-2447087

closes odoo/odoo#67234

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

The fleet vehicle_id must be visible on vendor refund

opw:2471784

closes odoo/odoo#67130

Signed-off-by: William André (wan) <wan@odoo.com>

A previous commit (8dbd1efe) fixed a
part of the basicmodel that used _.each to iterate on an object with
field names as keys, which does not work when a field is named "length".
To fix it, I simply used a native for ... in statement.  However, I
missed the fact that there was a second 'return' statement in the body
of the closure given to _.each, so the onchange method returned
prematurely.

The fix is to simply use the continue statement in that case.

closes odoo/odoo#67228

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Field vehicle_id is missing on the account.move.line view of refunds.
This fix updates the domain to make visible the field in in_refund.

Task ID: #2466914

closes odoo/odoo#66892

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

This reverts commit a59f255ef33c47449d028930e15c5390c62e39ed.

github issue: 67098

closes odoo/odoo#67179

X-original-commit: 882a6b2a
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

- don't show Electronic Invoicing field on account.move view if no EDI require web-service
Backport of https://github.com/odoo/odoo/pull/64493

 (TASK ID: 2439258)

- don't show account_edi_format field on account_invoice_send

closes odoo/odoo#67049

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Before this commit:
In a mass mailing, the action buttons such as 'put_in_queue' (Send) and
'action_schedule_date' (Schedule) are visible in 'sending' state, which
is not correct because users should not be able re-launch it in sending
state.

After this commit:
We hide those action button in 'sending' state to prevent user from
re-launching mass mailing when it's already in queue.

Task-Id : 2469352

closes odoo/odoo#67031

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Display notification to give feedback to user.
And reload the view with the params "next".

closes odoo/odoo#59274

Taskid: 2344276
Related: odoo/enterprise#13846
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Steps to reproduce the bug:

- Let's consider an included tax T (10%) and a product P (11€) with invoicing policy based on delivery
- Create a sale order SO with one line L with 2 P and T
- Confirm SO and deliver it

Bug:

The untaxed_amount_to_invoice was 40€ on L instead 20€

opw:2457660

closes odoo/odoo#67181

X-original-commit: 56d92277
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

The color_picker widget, that can be seen for example in the track form
view for event tracks, had an issue: if the user clicked on it, then
pressed TAB, a traceback was displayed.

The problem comes from the fact that the color picker widget inherits
from FieldInput, but is not a fieldinput, so many expectations made by
the FieldInput code do not hold, such as the code run when handling
navigation (by TAB and such keypress). Because of that, the code in
_onNavigationMove crashed, because it expected an input.

Since this is a bug fix, I simply disabled the navigation in that case,
so no crash happens.  Sadly, this widget has still a big issue: it
clearly does not work as most users would expect: pressing TAB or arrows
should update the selection.  But this would be a more complicated
refactoring, for a bug which is clearly not critical, therefore this
commit implements the simple and safe solution.

Also, we disable the focus outline to minimize the wrong expectation.
Seeing them kind of implied that one could update the selection with the
keyboard.

Note that the widget color_picker was moved from another addon to web/, without
any tests nor documentation.

OPW 2467369

closes odoo/odoo#67174

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

task-2438828

closes odoo/odoo#65183

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Convert the override of method `power_on()` to an `@autovacuum` method.

closes odoo/odoo#67145

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Fine tuning of 2d63fff1

closes odoo/odoo#67150

Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>

The underscore (_) library has a bug in which the _.each method does not
work with object which contains a "length" property. This is because it
does look for that key and if it is a number, it will assume that it is
an array with that length value.  Nicely done...

If that length value is set to 0, then it will just do nothing, since it
thinks that it is dealing with an empty array.

Note that if the value is set to an object, _.each is smart enough to
notice that it cannot be an array, and will do the correct thing in this
case.

Usually, our _.each calls are safe, since we usually iterate on arrays,
or on object with safe keys, or on object with values that cannot be a
number.

But there was 2 unsafe calls in basic_model, which leads to strange
bugs: some code is skipped, and the form view is then confused.  The
motivation for this fix is the fact that onchanges are not applied at
all, if there is a length field set to 0.

To fix this, we can just avoid using _.each.  Note to every Odoo JS
developers reading this: new Odoo code should avoid using the _ and $
libraries, because we do not really need them, and we want to keep our
dependencies to the strict mininum.

OPW: #2465808
closes odoo/odoo#66126

closes odoo/odoo#67138

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

This line was an hack to manage the custom register payment wizard of hr_expense.
Since this wizard is gone and 'payment_id' is a related stored field in account.move.line, we should not write such data explicitely.

closes odoo/odoo#67127

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

opw-2451571

closes odoo/odoo#67119

X-original-commit: 24c32607
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

partial revert of 45fad70e
digits=0 does nothing except define the colum type as numeric
or float8.

closes odoo/odoo#67129

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

Have a user [DEMO] with just user permission on POS
Have a POS configured with advanced cash control
With user [DEMO] open POS session

Traceback will occur because [DEMO] cannot access the relevant model

opw-2464150

closes odoo/odoo#67068

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

This commit makes the product's value computation in sudo mode in order
to be performed even by stock users.

closes odoo/odoo#67108

X-original-commit: a87c7fba
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Before this commit, the non_allow_billable field is always display in
the 'All Timesheets' tree view. This field is used when a timesheet is
non billable and the user wants to render this timesheet as billable
timesheet, he can uncheck this field.

This commit hides this field by default in this view.

closes #67055

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit, when the project is employee rate and the user sets
the sale order item to False in a task with this project, the linked
timesheets should have the sales order item to False, but if a
employee mapping is matched for this timesheet, the sales order item of
this mapping is given to the timesheet.

This commit checks if the sales order item in the task linked to the
timesheet and if no sales order item in the task then the sales order
item in the timesheet should also be empty (False).

closes #67055

The `clicks_ratio` field was computed outside of its compute method,
this is illegale as the ORM cannot protect the field from being included
in the "towrite" structure.

Backport of 7acc035

closes odoo/odoo#67097

X-original-commit: ca1f2e9d
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>

This is used in mail and sale_timesheet but wasn't an openerp-web
translation there.
Similar to 5caa0f0c

closes odoo/odoo#67096

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Description of the issue/feature this PR addresses:
- Fix tends to fix reserved_qty if the precision of product_uom_qty is higher than 0.5

Current behavior before PR:
- If the precision of product_uom_qty is higher than 0.5 reserved_qty (components availability) appears to be not available although there is enough qty in the stock.

Desired behavior after PR is merged:
- Unless there's no enough qty in the stock, reserved_qty is available.

opw-2425473
opw-2459650
opw-2448443
opw-2446985
opw-2440853
opw-2464507

closes odoo/odoo#67067

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

As a user accessing only the purchase module, create a request for
quotation, add a line with a tax and a cost > 0.
Confirm the RfQ to create the purchase order.

Before this commit, the user get a access error on account.account.tag
This patch add read access on this model for purchase users

opw : 2466688

closes odoo/odoo#67072

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Previously, when we find out subcontracted productions of moves, we get
all production_id from the origin moves of the moves. When user use
multple steps manufacturing, moves may also have their move_orig_ids.
In this case, we will consider its production_id as subcontracted
production.
To fix, we filered the moves, consider only move that is_subcontract is
true.

closes odoo/odoo#67066

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Some characters were not rendered properly, this commit restores the display
as it was in v13.0.

closes odoo/odoo#67065

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Before this commit:
While trying to duplicate a mailing contact within particular
mailing list, it  throws an user error saysing that 'A mailing
contact cannot subscribe to the same mailing list multiple times.'

After this commit:
User can duplicate a mailing contact from a mailing list without
the user error. In this case, we simply remove the default_list_ids
from the context, because all the mailing lists will be simply be
copied over from the existing contact and so we don't have to
re-add the default ones.

closes odoo/odoo#66827

Task-id: 2431344
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Problem
-------
Since
https://github.com/odoo/odoo/commit/d3b18979bfb5496fa4370fdf03a806c469127730

,
when a visitor register for an event, the fields in the POST are checked against a list of allowed fields.

The list is hardcoded inside the method _process_attendees_form.

Solution
--------
Move this list in a specific method that can be easily overidden by
another module

closes odoo/odoo#66757

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

When we search for a name in the chat window having a very long name
of the user will overflowing the screen. The autocomplete dropdown list is
overflowing and rendering out of the screen.

With this commit, we have resized the width of autocomplete dropdown list with
the width of the outer element's width as it's standard behavior.

Task : 2449115

closes odoo/odoo#66238

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

The condition on computation of `l10n_ch_isr_number_spaced` was not in line anymore with
`l10n_ch_isr_number` computation.
With fixes on the ISR number the use of `l10n_ch_isr_postal` is rightly not
mandatory anymore.

This lead to an empty field, visible on the ISR report.

closes odoo/odoo#66921

X-original-commit: fcc06f7d
Signed-off-by: Josse Colpaert <jco@openerp.com>

Tests are crashing when the number of months between the data date and today is higher than 18 months due to the 'past_months_limit' field on account.reconcile.model.

closes odoo/odoo#67033

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Since this old commit 73592487, the files that are packaged are
chosen by a list of allowed extensions. This list have to be maintained
each time that a developer adds a new kind of file in a module. This is
error prone [0] as most developer are not aware of that and it's difficult
to monitor.

Moreover, there is no reason to have a different list of installed files
when one install from the git repo instead of the source package.

With this commit, all [1] odoo sources files are included in the source
packaging and the only thing to maintain is a small black-list of file
extensions like for Python bytecode files and for version control files.

[0] see commit d33c05b6 that fix `.json` missing files.
[1] graft command: https://docs.python.org/3/distutils/commandref.html



closes odoo/odoo#67016

X-original-commit: 9c2ce1f1
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Purpose
=======
Some computed stored editable fields are computed in the same method.

In that case, when one of the value is provided in a create / write call,
the computed method is not called and other fields computed in the same
method do not have the right value.

Task 2377119
COM odoo/odoo/pull/65772
ENT odoo/enterprise/pull/16221

closes odoo/odoo#65772

Related: odoo/enterprise#16221
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose
=======
Some computed stored editable fields are computed in the same method.

In that case, when one of the value is provided in a create / write call,
the computed method is not called and other fields computed in the same
method do not have the right value.

Task 2377119
COM odoo/odoo/pull/65772
ENT odoo/enterprise/pull/16221

Purpose
=======
Some computed stored editable fields are computed in the same method.

In that case, when one of the value is provided in a create / write call,
the computed method is not called and other fields computed in the same
method do not have the right value.

Task 2377119
COM odoo/odoo/pull/65772
ENT odoo/enterprise/pull/16221

The field partner_id on model payment.transaction is not required
So in some cases if the field partner_id was not in the values
It raised a traceback.

opw:2467971

closes odoo/odoo#66980

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

The following warning is very long in absolute position. The following
text: "Calendar Mismatch : The employee's calendar does not match its
current contract calendar. This could lead to unexpected behaviors."
is invisible but takes a lot of width on the same line.

Now, the item is a block of 0px height and doesn't take space.
This avoids the horizontal scroll on mobile.

Note that the item is displayed at the wrong place anyway.
This will be fixed in master.

Steps to reproduce:
- Payroll / Employees / All contracts
- Change "Working Schedule" field

closes odoo/odoo#66944

Task-id: 1929043
X-original-commit: af81ac1a
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>