- Oct 21, 2020
-
-
Christophe Monniez authored
With this commit, the executions bits are fixed on some xml, csv and ttf files. The fix was initialy made at the Debian packaging level. As xlwt is now in Debian buster, the overide is removed. The linked fonts in Debian package are now removed in one line to simplify the code. closes odoo/odoo#60114 Signed-off-by:
Christophe Monniez (moc) <moc@odoo.com>
-
- Oct 22, 2020
-
-
Denis Ledoux authored
Skip the computation of the field `l10n_latam_document_type_id` at the module installation. The case has been detected during an upgrade from Odoo 12.0 to Odoo 13.0, but the case could really well happen outside the context of an upgrade, for instance when you create a new subsidiary in Chile or Argentina while you already have a lot of accounting entries in your other subsidiaries (e.g. Odoo S.A. opens a new office in Chile and has to install `l10n_cl`) Without this, at the module installation, it would call `_compute_l10n_latam_document_type` on all existing records which can take quite a while if you already have a lot of moves. It can even fail with a MemoryError. In addition, it sets `_compute_l10n_latam_document_type = False` on all records because this field depends on the many2many `l10n_latam_available_document_type_ids`, which relies on having records for the model `l10n_latam.document.type` which only happens once the according localization module is loaded. (e.g. `l10n_cl/data/l10n_latam.document.type.csv`) The localization module is loaded afterwards, because the localization module depends on this module, (e.g. `l10n_cl` depends on `l10n_latam_invoice_document`, and therefore `l10n_cl` is loaded after) and therefore there are no records for the model `l10n_latam.document.type` at the time this fields gets computed on installation. Hence, all records' `_compute_l10n_latam_document_type` are set to `False`. In addition, multiple localization module depends on this module (e.g. `l10n_cl`, `l10n_ar`) So, imagine `l10n_cl` gets installed first, and then `l10n_ar` is installed next, if `l10n_latam_document_type_id` needed to be computed on install, the install of `l10n_cl` would call the compute method, because `l10n_latam_invoice_document` would be installed at the same time, but then `l10n_ar` would miss it, because `l10n_latam_invoice_document` would already be installed. Besides, this field is computed only for drafts invoices, as stated in the compute method: `for rec in self.filtered(lambda x: x.state == 'draft'):` So, if we want this field to be computed on install, it must be done only on draft invoices, and only once the localization modules are loaded. It should be done in a dedicated post init hook, filtering correctly the invoices for which it must be computed. Though I don't think this is needed. In practical, it's very rare to already have invoices (draft, in addition) for a Chilian or Argentian company (`res.company`) before installing `l10n_cl` or `l10n_ar`. ``` Traceback (most recent call last): File "/src/odoo/13.0/odoo/service/server.py", line 1190, in preload_registries registry = Registry.new(dbname, update_module=update_module) File "/src/odoo/13.0/odoo/modules/registry.py", line 86, in new odoo.modules.load_modules(registry._db, force_demo, status, update_module) File "/src/odoo/13.0/odoo/modules/loading.py", line 423, in load_modules loaded_modules, update_module, models_to_check) File "/src/odoo/13.0/odoo/modules/loading.py", line 315, in load_marked_modules perform_checks=perform_checks, models_to_check=models_to_check File "/src/odoo/13.0/odoo/modules/loading.py", line 202, in load_module_graph registry.init_models(cr, model_names, {'module': package.name}, new_install) File "/src/odoo/13.0/odoo/modules/registry.py", line 364, in init_models env['base'].flush() File "/src/odoo/13.0/odoo/models.py", line 5458, in flush self.recompute() File "/src/odoo/13.0/odoo/models.py", line 5875, in recompute process(field) File "/src/odoo/13.0/odoo/models.py", line 5859, in process recs.mapped(field.name) File "/src/odoo/13.0/odoo/models.py", line 5266, in mapped recs = recs._mapped_func(operator.itemgetter(name)) File "/src/odoo/13.0/odoo/models.py", line 5225, in _mapped_func vals = [func(rec) for rec in self] File "/src/odoo/13.0/odoo/models.py", line 5225, in <listcomp> vals = [func(rec) for rec in self] File "/src/odoo/13.0/odoo/models.py", line 5690, in __getitem__ return self._fields[key].__get__(self, type(self)) File "/src/odoo/13.0/odoo/fields.py", line 2329, in __get__ return super().__get__(records, owner) File "/src/odoo/13.0/odoo/fields.py", line 995, in __get__ self.compute_value(recs) File "/src/odoo/13.0/odoo/fields.py", line 1109, in compute_value records._compute_field_value(self) File "/src/odoo/13.0/odoo/models.py", line 3968, in _compute_field_value field.compute(self) File "/src/odoo/13.0/odoo/fields.py", line 579, in _compute_related record[self.name] = self._process_related(value[self.related_field.name]) File "/src/odoo/13.0/odoo/models.py", line 5699, in __setitem__ return self._fields[key].__set__(self, value) File "/src/odoo/13.0/odoo/fields.py", line 1070, in __set__ self.write(protected_records, value) File "/src/odoo/13.0/odoo/fields.py", line 2564, in write cache.update(records, self, [cache_value] * len(records)) File "/src/odoo/13.0/odoo/api.py", line 768, in update field_cache.setdefault(record_id, {})[key] = value MemoryError ``` Upgrade request 49495 closes odoo/odoo#60572 X-original-commit: f2a08faa1e65cb381315cbd5d1a359901e8b7deb Signed-off-by:
Denis Ledoux (dle) <dle@odoo.com>
-
Thanh Dodeur authored
Before this commit, archived and deleted partners had not their im_status being updated automatically. There were some issues with this, notably: - odoobot 'bot' status was not displayed in chatter - im_status of partners becoming archived were not updated. This commit fixes both issues. task-2329591 closes odoo/odoo#60398 Signed-off-by:
Sébastien Theys (seb) <seb@odoo.com>
-
- Oct 21, 2020
-
-
qsm-odoo authored
On editor start, "the cursor enters editable text" at a "random" time thus switching immediately to text tools or not depending on the fact text tools switching was initialized or not. We now only allow to do so after some fixed delay after the editor is ready, to prevent any automatic switching on editor start (which may break tours). Part of https://github.com/odoo/odoo/pull/60383 task-2352339 closes odoo/odoo#60383 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
qsm-odoo authored
Do not switch to text tools if the cursor is in an empty oe_structure (to encourage using snippets there and actually avoid breaking tours which suppose the snippet list is visible). Part of https://github.com/odoo/odoo/pull/60383 Related to task-2352339
-
- Oct 22, 2020
-
-
Antoine Prieels authored
The alignment of quantity and product name was off when the product name was split into multiple lines. opw-2360424 closes odoo/odoo#60545 X-original-commit: 58404f29 Signed-off-by:
pimodoo <pimodoo@users.noreply.github.com> Signed-off-by:
Antoine Prieëls <aprieels@users.noreply.github.com>
-
Jeremy Hennecart authored
Cron holds a lastcall field and context key allowing to compute an accessible range of processable records based on last execution. This lastcall value is updated when cron runs automatically. Manual call currently does not update. It makes sense to do the same update in manual call than with automated calls. Moreover lastcall context key is also updated. It is used notably in calendar. Otherwise only mails linked to "today" are taken into account, leading to reminder issues. Task ID-2331999 closes odoo/odoo#60537 X-original-commit: 6c34d199 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
Victor Feyens authored
Ensure the code works fine even if countries are deleted. Also consider "re"-created countries after deletion, by only considering the country code, not the data reference. This should reduce support requests related to deleted countries, and ease the resolution of such problems by the users themselves. TASK ID - 2368842 closes odoo/odoo#57837 Related: odoo/enterprise#13275 Signed-off-by:
Victor Feyens (vfe) <vfe@odoo.com>
-
Alexandre Kühn authored
task-2359991 closes odoo/odoo#60535 Signed-off-by:
Sébastien Theys (seb) <seb@odoo.com>
-
Goffin Simon authored
Steps to reproduce the bug: - Let's consider a sellable product P published on the shop - Let's consider a portal user PU adding P in his wishlist W - Set P with sale_ok = False (meaning unsellable) - With PU try to see W Bug: A 430 error was raised because the product P was not sellable opw:2362184 closes odoo/odoo#60523 Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
Michael Mattiello (mcm) authored
Before this commit, when sub widget replaced its el, the ComponentAdapter parent kept the previous el. This caused some issues as in the ActivityRecordAdapter which lost its event listeners when re-rendered. This commit forces the ComponentAdapter to keep the new sub widget el after being patched. task id: 2360021 closes odoo/odoo#60517 X-original-commit: 393b5fd4cfba254ad054a526996e82922f9057e2 Signed-off-by:
Aaron Bohy (aab) <aab@odoo.com> Signed-off-by:
Michaël Mattiello <mcm-odoo@users.noreply.github.com>
-
Aurélien Warnon authored
This commit fixes a small issue with the modal displayed when the user wants to manage his subscription to a course. When pressing the "Save" button, if no modification was made, the modal would not close and nothing would happen (which seems strange on a user POV). Now the modal correctly destroys itself and closes. Task 2363028 closes odoo/odoo#60504 X-original-commit: 32d0b108 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
qsm-odoo authored
When the overlay covers a snippet, if that snippet is at the top of the page, the options at the top of the overlay are hidden. A system was made to make them change position in that case but this was broken by [1], leaving the toggling of a class for that case but without its related scss. This commit restores that scss and also improves the detection of that problematic case. [1]: https://github.com/odoo/odoo/commit/4f27e52cabb77b8b1a9637a11185ddf882adc9af closes odoo/odoo#60464 X-original-commit: 97f11571f9e3deacc9b9e1dc0d2cc8fc6b93f15c Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
Benjamin Vray authored
This commit align vertically the copyright text and the inline language switcher items. This commit also add a padding on list-inline-item in the language selector. Because before this commit, there was no space between lines if the list was to be displayed on multiple lines. Part of #59581 task-2312878 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
Benjamin Vray authored
Before this commit, the add language separator was visible at the end of the inline language switcher even if the add language link was not displayed. Part of #59581 task-2312878
-
- Oct 13, 2020
-
-
Bruno Zanotti (ADHOC) authored
closes odoo/odoo#59030 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
- Oct 22, 2020
-
-
wan authored
The fix c710c3a3 has been forgotten while applying https://github.com/odoo/odoo/pull/43768 closes odoo/odoo#60492 X-original-commit: c5d355444a3dde2635025e5452360e853afca099 Signed-off-by:
Laurent Smet <smetl@users.noreply.github.com> Signed-off-by:
wan <william-andre@users.noreply.github.com>
-
- Oct 21, 2020
-
-
IEL authored
TLDR: the videos doesn't work anyway, but nobody noticed it for years; at the same time there is no easy way to fix it STEPS: * create a record with html field, e.g. project.task * add an embedded video (File/Image icon) * save BEFORE: video doesn't work AFTER: there is no option to add embedded video anymore WHY: * iframe tags are removed before storing html in database, so after saving a record, embedded video doesn't work anymore * possible fixes look too tricky for stable branches: * new field attribute sanitize_iframe=False -- requires changes in core python framework which may have side effect * adding iframe on client side -- the problem is that the backend doesn't have mechanism to use animation in html fields like it's done in website: https://github.com/odoo/odoo/blob/ced500e9bcbb5c84033463689d135ad4c7dc4f39/addons/website/static/src/js/content/snippets.animation.js#L623-L632 * adding iframe on server side -- parsing html fields in _read... Doesn't look good either * double selector is required to make it work both in frontend and backend: $editable.closest('.o_editable, .note-editor') * we don't need hardcoded exception for mailing.mailing, mail.compose.message because those fields marked as sanitized (default value) https://github.com/odoo/odoo/blob/c92f058571b0656451f24e24154dd1bdb3bdb48a/odoo/fields.py#L1589-L1590 https://github.com/odoo/odoo/blob/c92f058571b0656451f24e24154dd1bdb3bdb48a/addons/mail/wizard/mail_compose_message.py#L115 https://github.com/odoo/odoo/blob/61734cdaf1cf6857125b1ece63928ab080359c6c/addons/mass_mailing/models/mailing.py#L77 * I don't apply this for Odoo 12, because js is refactored in Odoo 13 (e.g. field_html.js has another name in Odoo 12) --- opw-2353103 closes odoo/odoo#60474 X-original-commit: 2dcbac08effcedafbcf50610355752030902b16d Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by:
Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>
-
Laurent Smet authored
A tax line could have something in the `tax_ids` field. Then, these condition needs to be inversed in order to not handle them as base lines. closes odoo/odoo#60469 X-original-commit: eada9f91f3361f8335c23b3a27161803cfda6608 Signed-off-by:
oco-odoo <oco-odoo@users.noreply.github.com> Signed-off-by:
Laurent Smet <smetl@users.noreply.github.com>
-
Swapnesh Shah authored
Before this commit, Going to Website --> Configurations --> Apps was displaying Modules related to Website only but the default focus on searchpanel was on "All". (https://tinyurl.com/y5tw5uob) Now, The default focus of searchpanel is on Website Category. (https://tinyurl.com/y6984hl7 ) closes odoo/odoo#60479 Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
Jeremy Kersten authored
Courtesy of sts closes odoo/odoo#60454 X-original-commit: bc2dc85c Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
Swapnesh Shah authored
Before this commit, Field "No of Views (visits)" was editable on multi_edit mode. Field "No of Views (visits)" should be readonly for Obvious reason. closes odoo/odoo#60483 Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
Nicolas Martinelli authored
- Create companies A & B - Create a Dropship route for B - Create a product P with route 'Dropship' - Set the website under company A - As a portal user, buy the product P on the website - Do the payment The SO is confirmed but the Dropship route for B is used despite the fact that the website is under company A. This happens because `_search_rule` is called as superuser: therefore, routes from all companies are retrieved. To prevent this, we add the company in the domain. opw-2349094 closes odoo/odoo#60475 X-original-commit: 51b7960f Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Nasreddin (bon) authored
Issue - Install "Website" app - Go to "Contact us" page on website - Edit Page, then click on submit button to edit form style - Alter 'Recipient Email' by selecting a value from 'autocomplete' values Other input text options are also altered. Cause Due to chrome autocompletition, others text input fields are also altered (like it will do with a form address). In this case, the error was obvious since it alter also the 'Labels Width' who break the layout. Solution Disable autocompletition on `<input type='text'/>` options elements. opw-2361169 closes odoo/odoo#60470 X-original-commit: 978788bbdf1a4a3d563fd70e2af89fdd1fd039ec Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by:
bon-odoo <nboulif@users.noreply.github.com>
-
Victor Feyens authored
Recenlty, this method was changed to use set instead of recordsets to improve the performance of the code. But set have a non deterministic order, which means the order of the returned programs returned is not the same, modifying the resulting behavior as some programs cannot be applied together. To fix this problem, this commit replaces the set by lists to ensure the returned recordset keeps the same ordering. Also rename a potentially conflicting variable caused by the same commit. Finetuning of commit cc1bb922. closes odoo/odoo#60468 X-original-commit: 6d4da47f Signed-off-by:
Victor Feyens (vfe) <vfe@odoo.com>
-
Nasreddin (bon) authored
Issue - Install "Website" app - Go to "Contact us" page on website - Edit Page, then click on submit button to edit form style - Alter 'Recipient Email' then save - Edit Page and click on submit button 'Recipient Email' have default value. Cause If a field is required, the default value is set without checking if a value is already set. Solution Set current value if available, else default value. opw-2361169 closes odoo/odoo#60452 X-original-commit: e29d2818abf0e7902feb26c9e0b4809c9a3351c6 Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by:
bon-odoo <nboulif@users.noreply.github.com>
-
- Oct 20, 2020
-
-
Achraf (abz) authored
Issue - Change country to Mexico - Install 'CRM' - Install 'l10n_mx_edi' - Try to open any lead in 'CRM' The same error is present in l10n_pe Cause 'l10n_mx_edi' and 'l10n_pe' use 'res.partner' in 'ir.ui.view' Solution Adding a condition to prevent '_fields_view_get_address' in 'format.address.mixin' from rewritting the model and let ir.ui.view determine it opw-2361875 closes odoo/odoo#60329 Signed-off-by:
Laurent Smet <smetl@users.noreply.github.com>
-
Antoine Prieels authored
The bottom of long receipts was missing when printing through the browser printing dialog. opw-2362522 closes odoo/odoo#60375 Signed-off-by:
pimodoo <pimodoo@users.noreply.github.com>
-
- Oct 21, 2020
-
-
Nicolas Martinelli authored
This reverts commit c382e8c8. closes odoo/odoo#60428 X-original-commit: 84ec7277 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Nicolas Martinelli authored
- Create a partner outside Europe - Set a VAT number - Create an invoice for the partner - Post the invoice The `IdPaese` and `IdCodice` is obtained from the VAT number, but it is not correct for partners outside Europe: the VAT number should always be `OO99999999999`. A workaround is to set the VAT number of the partner to `XXOO99999999999`, where `XX` is the country code. However, in case of multi-company with shared partners, another company might need the proper VAT number. In case of a customer outside EU, we: - get the `IdPaese` from the country of the partner - set the `IdCodice` to `OO99999999999` We also add the `IdPaese` to customers without VAT. opw-2355842 closes odoo/odoo#60410 X-original-commit: 35267c59 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Christophe Monniez authored
The package.py script is moving the addons in odoo/addons which is not more necessary for the Debian package as it's made at the Debian packaging level. So package.py will not do that anymore. closes odoo/odoo#60421 Signed-off-by:
Christophe Monniez (moc) <moc@odoo.com>
-
- Oct 20, 2020
-
-
Benjamin Vray authored
Before this commit, we executed the request even when creating a new badge. And it thrown a traceback. After this commit, we return default values before executing the request if this is a new badge. task-2312878 closes odoo/odoo#60347 Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
- Oct 16, 2020
-
-
Thanh Dodeur authored
This commit gives to o_Dialog the same z-index as modals, before this commit, the dialog could be hidden or partially obstructed by other elements. part of task-2171884 closes odoo/odoo#60162 Signed-off-by:
Alexandre Kühn (aku) <aku@odoo.com>
-
- Oct 21, 2020
-
-
Benjamin Vray authored
Before this commit, the width of carousel blockquotes was too small to display correctly on mobile device. Part of #55857 task-2318526 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
Benjamin Vray authored
Keep the original position of the background as a percentage. In this way, we avoid converting in pixel a direction that we have not changed. Part of #55857 Related to task-2318526
-
Benjamin Vray authored
-Remove arrows on mobile because it's too big and hide the content. User will use the touch screen to make the carousel move. -Bordered style: Reduce the borders on mobile. Part of #55857 task-2318526
-
Romain Derie authored
Depending of the configuration, on the portal, anchor do not consider the header, so a part of the text is hidden by the navbar. task-2290213 closes odoo/odoo#60408 X-original-commit: 2cd9a9d12f4cd7352430c166145a7488af0c120c Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com> Signed-off-by:
Romain Derie <rdeodoo@users.noreply.github.com>
-
Raphael Collet authored
The feature was actually not working as expected. It has been fixed, and a test now ensures it does work as expected. This commit also fixes some invalid parameters, hopefully nothing critical. closes odoo/odoo#60402 Related: odoo/enterprise#14273 Signed-off-by:
Raphael Collet (rco) <rco@openerp.com>
-
- Oct 20, 2020
-
-
Achraf (abz) authored
Issue - Install "Calender" - Install "Google Calendar" - Try to sync google in "Calendar" Every created events will trigger the sending mail to attendees even if the event date is past Cause 'events' was not filtered Solution Filter 'events' to get all the events that have not yet happened opw-2358123 closes odoo/odoo#60379 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Oct 21, 2020
-
-
Olivier Dony authored
There was a problem in the Transifex translations for Spanish and all translations were overwritten by mistake with english defaults. This commit reverts all modified es.po files to their previous version while we work to restore the translations on Transifex.
-