Skip to content
Snippets Groups Projects
  1. Mar 22, 2018
    • Luis González's avatar
      [FIX] web: Make accessible with keyboard the delete button on o2m fields (#23719) · ef540eb0
      Luis González authored
      * [FIX] web: Make accessible with keyboard the delete button on o2m fields
      
      Currently, the delete button in one2many fields (trash icon) is not
      reachable when using the keyboard, because it's neither a link, nor a
      button or any other interactable HTML element, but a `<span>`.
      
      This change causes that button to be an actual HTML button keeping the
      same appearance, so it may be reached when using the keyboard.
      
      * [FIX] web: Modify test to expect button instead of span as o2m trash icon
      
      Since buttons to delete records in o2m fields (the trash icon) were
      changed from `<span>` to `<button>` to be able to access them with the
      keyboard, the test need to be modified so it expect the new element
      type and doesn't break.
      ef540eb0
    • Martin Trigaux's avatar
      [FIX] stock: translate stock traceability report · ac76a6b4
      Martin Trigaux authored
      Missing user language in the context
      
      Fixes #21332
      ac76a6b4
    • Jeremy Kersten's avatar
      [FIX] base: settings view match on label.text · 38e33925
      Jeremy Kersten authored
      Before this commit, search was broken because containsLike was searching on
      the innerHtml. (3dd93ed1)
      
      Settings use _wordHighlighter to change the background of the matching text
      into the label, so the label was not only text, but html.
      
      <label><span class="highlighter">Mul</span>ti-company</label>
          : looking for (mul)
      
      After this commit, the match is based on the text content and not on the html.
      38e33925
    • Martin Trigaux's avatar
      [FIX] *: correct bad %s translations · a8230853
      Martin Trigaux authored
      Continue work of 6292600b for languages not published on Transifex too
      Remove en_GB file that was containing too many errors (e.g. 'PoS Order'
      translated 'Sale Order')
      
      Fixes #19661
      a8230853
    • Nicolas Martinelli's avatar
      [FIX] mail: strip comments when inlining · 6b07bce0
      Nicolas Martinelli authored
      When an unread message contains conditional html statements, clicking on
      the discuss tray icon produces a JS traceback. This is due to
      `node.tagName` being undefined.
      
      When inlining, there is no need for these comments.
      
      opw-1829641
      6b07bce0
    • rco-odoo's avatar
      [FIX] models: backport of 5f660cdb · 875f8490
      rco-odoo authored
      This fix avoids wild prefetching when serializing
      onchange results.
      
      We fell on a strange situation in method `onchange`, where
      some data was missing from cache when serializing the
      result. In that case, the prefetching overwrites so
      many stuff in cache that the results of the onchanges
      are lost.
      Don't let that happen.
      
      This is a backport of 5f660cdb, with rco-odoo's blessing.
      A use case this commit solve is
        - Install the sale app.
        - Create new quotation and assign new partner
        - From inline editable listview add a new order line
        (created the product inline) then directly save.
        - Click on the order line (NOT IN EDIT MODE). This opens
        the order line in a popup.
        - Close the popup.
        - Click edit again.
        - Now change the order line description.
      When unfocusing order line field, the description is reset
      to previous one.
      
      Closes #23276
      Closes #23277
      875f8490
  2. Mar 21, 2018
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      78dced6b
    • Arnaud Baes's avatar
      [FIX] stock: run scheduler · 3c468b01
      Arnaud Baes authored
      the "company_id" value wasn't declared explicitly in the "_prepare_procurement_values" method, wich caused the procurement "run" method to set a company by default regardless of the company associated to the orderpoint.
      
      this caused issues in a multi-company config. ( see #23764 )
      3c468b01
    • Nicolas Martinelli's avatar
      [FIX] base_import: import empty date/datetime · aed8e199
      Nicolas Martinelli authored
      When a user imports a file with a datetime field set to a blank space,
      the value is computed as 1900-01-01 00:00:00. However, when converted in
      the user's TZ, this can lead to a value < 1900-01-01, which is not
      recognized at the JS level as a valid value.
      
      This makes the access to the record impossible, and possibly makes the
      access to an app impossible. It is for example the case with Purchase,
      where the order date is displayed on the default's action view (list
      view).
      
      We strip the value before testing if the value exists to avoid this
      case.
      
      opw-1826344
      aed8e199
    • Goffin Simon's avatar
      [FIX] stock_account: Cannot validate some invoices · c2b3ad18
      Goffin Simon authored
      Steps to reproduce the bug:
      
      - create an invoice
      - add one line without product but with a uom
      - validate it
      
      Bug:
      
      A traceback was raised because no product was set on the invoice line.
      
      opw:1825464
      c2b3ad18
    • Romain Derie's avatar
      [FIX] web_editor: correctly set image on double click · 32148685
      Romain Derie authored
      Commit e011d58b add the possibility to unselect images on the media dialog.
      But it introduced a collateral bug preventing double click to set the image.
      Indeed, double click event triggers not only the double click event but also
      twice the single click event.
      
      Before commit e011d58b, it would work fine and as intented on double click:
      1. It would trigger twice the single click, selecting twice the image.
      2. Then, it would trigger the double click that would save the selected image.
      
      But after the commit:
      1. It triggers twice the single click, selecting and then deselecting the image.
      2. Then, it triggers the double click that saves nothing since the image got
         unselected on second single click event.
      
      Now, before saving on double click event, we select the image.
      
      task-1815165
      32148685
    • Adrian Torres's avatar
      Revert "[FIX] base: use khmer language" · d9869de6
      Adrian Torres authored
      This reverts commit 3401e95e.
      
      Updating language code is forbidden, see commit 8628cef1
      d9869de6
    • Swapnesh Shah's avatar
    • Florent de Labarre's avatar
      [FIX] maintenance: give equipment same activities filters as other models · 0166b3dd
      Florent de Labarre authored
      Commit 34da40a4 improved all activities filters used through various
      apps. However in maintenance model maintenance equipment model was forgotten.
      This commits fixes that in order to have same filters on all models using
      activities.
      0166b3dd
    • William Henrotin's avatar
      [FIX] base: use khmer language · 3401e95e
      William Henrotin authored
      The language territory code for Cambodia is KH not KM
      3401e95e
    • Jeremy Kersten's avatar
      [FIX] web: all routes should have **kw to support utm/extra params · c17170b9
      Jeremy Kersten authored
      Without this commit, a valid route /web/content with an extra
      params eg utm or adwords will return a 500 with:
      TypeError: content_common() got an unexpected keyword argument 'extra_param_name'
      
      This commit closes #21221
      
      Task-32836 should fix for all routes in a future version
      c17170b9
    • Jairo Llopis's avatar
      [FIX] website_project_issue: No buttons for portal, customers · 9e981f65
      Jairo Llopis authored
      Customers without an user account can do nothing with the button
      in the notification, so it's better they don't have it.
      
      partial backport of #4732a1
      
      This commit closes #22487
      9e981f65
    • Highcooley's avatar
      [I18N] l10n_ch: add German translations · b3b0c02d
      Highcooley authored
      German (CH) Translations Chart of Accounts
      
      Closes #23785
      b3b0c02d
    • Highcooley's avatar
      [CLA] signature for Highcooley · 916dad80
      Highcooley authored
      Done at #23785
      916dad80
    • Christophe Simonis's avatar
      0cefaad3
    • Ward Marissen's avatar
      [FIX] website_portal: Keep country changes · 2c5fe07f
      Ward Marissen authored
      When a portal user changes his account details and presses the 'Save' button
      when a mandatory field is not set, the selected country will be reset even when
      the user did change the country in the form. This fix prevents this from
      happening and leads to an improvement for the end user.
      
      This commit closes #22439
      2c5fe07f
    • hpr-odoo's avatar
      [FIX] base: iterate on each report · ce05f3b2
      hpr-odoo authored
      If tries to compute the report_rml value on multiple reports at the same time
      
      Closes #21116 
      ce05f3b2
    • Nicolas Martinelli's avatar
      [FIX] stock: Delivery Slip · 65bad81b
      Nicolas Martinelli authored
      - Create a picking to deliver 10 units, save
      - Edit and change to 12 units
      - Print the Delivery Slip => the qty is 10
      - Validate the picking with 12 units
      - Print the Delivery Slip => the qty is still 10
      
      The use of `ordered_qty` is misleading, since it corresponds to the qty
      ordered at creation.
      
      Backport of 0a2999cd
      
      opw-1825396
      65bad81b
    • Nicolas Martinelli's avatar
      [FIX] crm: create opportunity from kanban · b200f020
      Nicolas Martinelli authored
      - Create a customer, set an address
      - Create an opportunity from the kanban view
      
      The address fields are not filled in in the opportunity.
      
      We add all fields filled in by `_onchange_partner_id_values`
      
      Complement of commit e2bbee6d
      
      opw-1816438
      opw-1826859
      b200f020
    • Rohan Patel's avatar
      [IMP] hr: check employees only alias restriction independently of record existence · 57e457c5
      Rohan Patel authored
      Commit 78ac6de5 refactored methods checking alias security on the
      routing found for a given destination address. Indeed if a routing is found
      linked to an alias a security check is performed according to the restriction
      defined on the alias itself.
      
      HR module adds the 'employees only' restriction. A bug has been introduced
      in the mentioned commit concerning employees-based aliases. Indeed a condition
      on having a recordset has been added (self.ids, changed to record.ids at
      20d80250). This condition is actually not necessary as checking the
      email author is linked to an existing employee has nothing to do with the
      alias being linked to a record or creating new record.
      
      This may causes issues notably using employees-restricted aliases in
      expense application. Indeed you could use aliases to create new expenses
      for employees and you could have issues with this condition.
      
      This commit is linked to task ID 1829860 and ID 35093. Closes #22960 .
      57e457c5
    • Goffin Simon's avatar
      [FIX] stock_account: Cannot validate a Customer Credit · 60793a8a
      Goffin Simon authored
      Steps to reproduce the bug:
      
      - Create a customer credit note
      - Add a new item
      - Don't input Product, input Description and Unit of Measure
      - Click on Validate
      
      Bug:
      
      A traceback was raised because no product was set on the invoice line.
      
      opw:1825972
      60793a8a
    • Nicolas Martinelli's avatar
      [FIX] account: unreconcile payment · 6d195ee6
      Nicolas Martinelli authored
      - Create a SO for a customer of 100 $
      - Create Invoice for the Sales Order and Register the payment
      - Create a Refund Invoice, Validate it and keep it in "Open" state
      - Create a second SO for 5 $
      - Create an invoice for this order and validate it
      - It will show you outstanding payments
      - Apply the credit and the invoice will be fulfilled => Now you have a
        credit left for 95 $
      - Create a third Sales order for the same customer for 5 $
      - Create an Invoice for it
      - It will show you outstanding credit (95 $)
      - Apply the credits
      - Now 90 $ are left
      - In the same invoice, the credit which you applied, Unreconcile it
      - It should have shown you 95 $, but it shows you 100 $ which means it
        removed the credit which we applied to second SO
      
      The unreconcile process does not filter the partial reconciliations of
      the selected invoice. All partial reconciliations on the AML are
      removed instead.
      
      opw-1819602
      6d195ee6
  3. Mar 20, 2018
    • Adrien Dieudonne's avatar
      [FIX] barcodes: barcode scanning on Chrome mobile · 3a74afd2
      Adrien Dieudonne authored
      Before this commit, the barcode value wasn't triggered on
      some Android devices with Google Chrome and using the Odoo app.
      
      In fact, the keypress event may not trigger with some devices.
      This is probably due to the fact that this event is marked as
      'Legacy'.
      See: https://www.w3.org/TR/uievents/#legacy-keyboardevent-event-types
      
      To fix this, we can use 'keydown' event but we have to handle an
      other issue: there is no way to know which key is typed.
      The auto-suggest feature on Android invalidate all the following
      properties: Keycode, charCode, key, which, keyIdentifier, code.
      This is a well-known issue:
      https://bugs.chromium.org/p/chromium/issues/detail?id=118639
      
      For more infos, please read this blog:
      https://www.outsystems.com/blog/javascript-events-unmasked-how-to-create-input-mask-for-mobile.html
      
      As a work around, we create a temporary input field that stores
      the barcode value.
      The focus is set on this input when a keydown is detected.
      Note that when an input has the focus, the android virtual keyboard
      will be opened. We can't avoid this behavior.
      The only thing we can do is to automatically close it after 800 ms.
      See: https://bugs.chromium.org/p/chromium/issues/detail?id=662386
      
      As this fix is specific for Chrome only, it's not possible
      to test it easily. Some tests will be added in master.
      3a74afd2
    • Adrien Dieudonne's avatar
      [FIX] barcodes: skip undefined keys in barcode value · 5bc29744
      Adrien Dieudonne authored
      This fixes an issue occurring with Firefox.
      Some events was buffered with an undefined value and it wasn't
      possible to build the barcode value from these events.
      See 'handle_buffered_keys' function.
      
      So now, we simply skip this kind of event.
      We consider this as 'special keys'.
      5bc29744
    • Nikunj Ladava's avatar
      [IMP] payment, sale_payment: set invoice id in payment transaction form after... · cbd395ec
      Nikunj Ladava authored
      [IMP] payment, sale_payment: set invoice id in payment transaction form after payment being done from sale order.
      
      Until now invoice_id is filled on the transaction only when we make
      payments through invoice. However if we make payments through sale order
      then invoice_id is not filled.
      
      This commit fixes that issue. As there is no common point between
      sale_payment and account_payment except payment, a void method is added
      in payment and an override done in account_payment. That was when both
      modules are installed code is correctly triggered.
      
      This commit is related to task ID 1813602. Closes #22746 .
      cbd395ec
    • Christophe Simonis's avatar
      [FIX] sale,sale_payment: remove implicit dependency of `sale` on `payment` module · b6e0f1ad
      Christophe Simonis authored
      This worked by accident only because `payment` module is auto-installed
      when `account` is installed.
      
      opw-1829812
      b6e0f1ad
    • Romain Derie's avatar
      [FIX] website_sale(_delivery): show prices according to B2B/B2C mode · b77ff40e
      Romain Derie authored
      Before this commit:
      1. The delivery price on checkout would always be shown without the taxes.
         This would make the cart total unclear since it is not indicated that this
         price is tax excluded. You could only assume that this was the price the
         delivery would cost you (and not just the untaxed delivery cost which you
         can't even find the full price anyway since taxes in subtotal is the sum of
         all products taxes).
      
      2. The sale order line in payment step of checkout are always displayed with
         taxes.
      
      Now:
      We ensure that both 1. and 2. show the delivery price with or without taxes
      according to which mode (B2C or B2B) is enabled.
      
      This fixes #12872, closes #13592 and closes #23746
      b77ff40e
    • Martin Geubelle's avatar
      [FIX] web: correctly display statusbar · 75d9a2b4
      Martin Geubelle authored
      Some status were shown in the statusbar even though they were not specified in
      the `statusbar_visible` attribute. This happened when the value was a substring
      of one specified value.
      
      Example:
      ```
      hello = fields.Selection([('hello', 'Hello'), ('hello_world', 'Hello World')])
      <field name='hello' widget='statusbar' statusbar_visible='hello_world'/>
      ```
      In this case, both status were shown ('hello' is a substring of 'hello_world').
      
      Fixes #20034
      75d9a2b4
    • Jairo Llopis's avatar
      [FIX] mass_mailing: domain translation · 6bd3bae0
      Jairo Llopis authored
      As Admin:
      - Set up 2 languages for the installation, e.g. English and French
      - Admin language is English, Demo language is French
      - Create a `res.partner.category` named 'Test English'
      - Assign the category to a newly created partner
      - Create a French translation for 'Test English', e.g. 'Test Francais'
      
      As Demo:
      - Create a Mass Mailing
      - Select a custom domain: ('category_id', '=', 'Test Francais') => it
        should match one partner
      - Save and validate
      
      Now either:
      - manually run the scheduled action "Process Mass Mailing Queue" as
        Admin
      - wait for the cron to process the mass mailing
      
      No mail will be sent since the domain will be evaluated in the Admin
      language, i.e. English. Indeed, the domain
      `('category_id', '=', 'Test Francais')` does not match any record in
      English.
      
      The solution/workaround is to use the language of the last user who wrote
      on the mass mailing.
      
      Closes #20906, Closes #15467, Closes #15445
      
      opw-778922
      6bd3bae0
    • Nicolas Lempereur's avatar
      [FIX] l10n_ch: ignore stylistic background · 3f5663e9
      Nicolas Lempereur authored
      If user choose custom report type with background, we don't want the
      background on the ISR report that is intended to be printed on
      preprinted paper.
      
      opw-1820123
      closes #23743
      3f5663e9
    • Jérome Maes's avatar
      [FIX] sale_timesheet: SO line of subtasks · 84db2dc9
      Jérome Maes authored
      When changing the so line of a task, we should update
      the ones from its children too.
      84db2dc9
    • Jérome Maes's avatar
      [FIX] sale_timesheet: default so line for subtasks · 45396f79
      Jérome Maes authored
      When creating a task in a project generated from
      an SO line, we want this to be linked to that
      sale line too.
      When creating a subtask, the sale line is forced
      to be the one of the parent, in `create` method.
      But we want to see it on the form view.
      45396f79
    • Goffin Simon's avatar
      [FIX] sale: Wrong display of taxes in PRO-FORMA · f50a08bc
      Goffin Simon authored
      Steps to reproduce the bug:
      
      -Create a tax of 21% tax included but don't select the "affect base" checkbox.
      -Create another tax of 5.2% (no tax include)
      -Create a sale order with a line that has a unit price of 121 and both taxes.
      Notice that the total amount is: 126.2 (100 base amount + 21 from 21% tax + 5.2 from 5.2 tax)
      -Click on "Print the proforma invoice"
      
      Bug:
      
      The total amount was still 126.2 and base=100, however taxes were wrong, there were 21 for the 21% tax
      and 6.29 instead of 5.2 for the 5.2 tax.
      
      opw:1819882
      f50a08bc
Loading