Skip to content
Snippets Groups Projects
  1. Jul 11, 2019
  2. Jun 24, 2019
  3. Jul 11, 2019
  4. Jul 09, 2019
  5. Jul 11, 2019
    • Ghuen Lee's avatar
      [CLA] signature for ghuenlee · dee064b0
      Ghuen Lee authored
      
      closes odoo/odoo#34721
      
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      dee064b0
    • Thibault Delavallée's avatar
      [FIX] mail: set email_from in composer only if set · d8deacfd
      Thibault Delavallée authored
      
      Some functional flows use sudo() to create records as current user is the
      public user. This user has no email. Since 1e6c3bec using sudo does
      not take superuser identity completely as it only bypasses access rights.
      It means some messages are created with public user as author, meaning no
      email_from.
      
      In this commit we fix some functional flows by setting a default email_from
      in the message composer only if a real email is found. Otherwise it will have
      to be set either by the template, either later in the process when creating
      messages or emails.
      
      closes odoo/odoo#34742
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      d8deacfd
    • Thibault Delavallée's avatar
      [FIX] mail: allow message_log to store a void email_from · 715834c6
      Thibault Delavallée authored
      Some functional flows use sudo() to create records as current user is the
      public user. This user has no email. Since 1e6c3bec using sudo does
      not take superuser identity completely as it only bypasses access rights.
      It means some messages are created with public user as author, meaning no
      email_from.
      
      In this commit we fix some functional flows by allowing message_log to store
      messages with a void email_from. Indeed message_log does not propagate any
      notifications, meaning email_from is not required in any email notification
      or to compute a reply_to.
      715834c6
    • Thibault Delavallée's avatar
      [REV] Revert "[FIX] mail: avoid crashing for users without email address" · 560e03e3
      Thibault Delavallée authored
      This reverts commit 6230f72d.
      
      Crashing when user have no valid email is the expected behavior. Flows sending
      emails must ensure either current user has valid login / email, either it
      uses an user OR author_id / email_from that has a meaning in the functional
      flow. Notably when public user is involved. Hiding functional issues is not
      what we want.
      560e03e3
  6. Jul 09, 2019
  7. Jul 08, 2019
  8. Jul 11, 2019
    • Hetal Dhanak's avatar
      [IMP] stock, mrp: company dependant scrap orders. · fa503765
      Hetal Dhanak authored
      
      This commit adds fields 'company_id' on stock.scrap model.
      The company will filter locations and stock moves linked to the scrap
      document.
      
      We add also a specific sequence by company.
      
      Task-1930055
      
      closes odoo/odoo#30498
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      fa503765
    • Robot Odoo's avatar
      [various] Clean controlpanel actions · b4f45e1f
      Robot Odoo authored
      PURPOSE
      
      The 'action' dropdown on the controlpanel is starting to get messy. Their
      labels are sometimes too long/repetitive. Some actions only make sense in
      formview, some in listview, some in both. Some actions should be stat buttons.
      
      Here are some of the 'guidelines' I've followed to clean those actions:
      If the action already has a dedicated button in the formview, do not display
      it in the formview action dropdown. Action labels always start with a verb.
      Former actions that redirected to records are changed to stat buttons
      
      SPECIFICATION
      
      The following drive file defines all the changes to be done on actions:
      https://docs.google.com/spreadsheets/d/1G0AtYs6VIXFz1vG32IoL457c_oy-OCXF9Tv19vLQdz8/edit?usp=sharing
      
      
      
      The actions are grouped by object, which are grouped by product owner. The
      ones in green are to be kept. The 'where' column specifies whether they should
      be shown in formview, listview, or both. The ones in red are to be removed or
      moved somewhere else (stat button, menu item). When an action is removed, check
      whether the action it is calling is used somewhere else. If it is not the
      case, remove it as well (clean the code).
      
      Linked to task ID 1984526
      
      closes odoo/odoo#33720
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      Unverified
      b4f45e1f
  9. Jul 10, 2019
    • Hiral Bhavsar's avatar
      [IMP] product_margin: remove actions from the controlpanel action menu · d3abf5c9
      Hiral Bhavsar authored
      Here remove the 'binding_model' attributes from 'act_window' to
      remove the action menu 'Product Margins' from the 'product.product'
      model
      
      Linked to task 1984526
      Related to PR #33720
      d3abf5c9
    • Hiral Bhavsar's avatar
      [IMP] hr(_*), website_hr: replace actions menu by stat button · b7c8cf1b
      Hiral Bhavsar authored
      * attendance, contract, fleet, holidays, maintenance, presence,
        timesheet.
      
      For the model 'hr.employee', replace the actions menu 'Archive/Restore'
      by the stat button. That's why adapted changes regarding xpath.
      
      Also rename the actions menu 'Time Off' by 'Time off'.
      
      Linked to task 1984526
      Related to PR #33720
      b7c8cf1b
    • Hiral Bhavsar's avatar
      [IMP] account(_*): clean the controlpanel actions · 2b7d8991
      Hiral Bhavsar authored
      * check_printing, voucher
      
      For the model 'account.account',
      - Replace the action menu 'Journal Items' by the stat button.
      - Hide menu 'Journal Items for Tax Audit' from actions menu.
      
      For the model 'account.invoice',
      - Set action menu 'Share' only for the form view.
      - Rename the action menu 'Confirm Draft Invoices' by 'Validate'.
      - Rename 'Register Payment' by 'Register payment'.
      - Rename 'Send' by 'Send & print'.
      
      For the model 'account.move',
      - Remove the menu 'Journal Items'.
      - Rename 'Reverse Moves' by 'Reverse' and set it only for the list
        view.
      - Rename 'Post Journal Entries' by 'Post entries' and set it only for
        the list view.
      
      For the model 'account.move.line',r ename 'Reconcile Entries' by
      'Reconcile' and 'Unreconcile Entries' by 'Unreconcile' and set it only
      for the list view.
      
      For the model 'account.payment',
      - Rename 'Send Receipt By Email' by 'Send receipt by email' and set it
        for both form and list views.
      - Rename 'Post Payments' by 'Confirm' and set it for the list view only
      - Rename 'Print Checks' by 'Print checks' and set it for the list view
        only.
      
      For the model 'account.journal', remove the menus 'Unpaid Invoices',
      'Bank statements' and 'Voucher Entries'.
      
      Linked to task 1984526
      Related to PR #33720
      2b7d8991
    • Hiral Bhavsar's avatar
      [IMP] lunch: clean the controlpanel actions · 6eef0ea0
      Hiral Bhavsar authored
      - For the model 'lunch.order', rename the actions menu
        'Lunch: Receive meals' by 'Mark as received' and 'Lunch: Cancel meals'
        by 'Cancel'.
      - For the model 'lunch.product', remove the action menu
        'Lunch: Archive/Restore products'
      
      Linked to task 1984526
      Related to PR #33720
      6eef0ea0
    • Hiral Bhavsar's avatar
      [IMP] hr_expense: clean the controlpanel action menu · 5a2c3286
      Hiral Bhavsar authored
      For the model 'hr.expense', rename the action menu 'Submit Report' by
      'Submit report' and set it only for the list view.
      
      Linked to task 1984526
      Related to PR #33720
      5a2c3286
    • Hiral Bhavsar's avatar
      [IMP] hr_timesheet: remove the action menu 'Timesheet Entries' · 32c01d18
      Hiral Bhavsar authored
      For the model 'project.task', remove the action menu 'Timesheet Entries'
      
      Linked to task 1984526
      Related to PR #33720
      32c01d18
    • Hiral Bhavsar's avatar
      [IMP] repair: rename the action menu 'Create Invoice' · cba58475
      Hiral Bhavsar authored
      Rename the action menu 'Create Invoice' by 'Create invoices' for the
      model 'repair.order'.
      
      Linked to task 1984526
      Related to PR #33720
      cba58475
    • Hiral Bhavsar's avatar
      [IMP] purchase: set the action menu 'Share' only for form view · 2456f673
      Hiral Bhavsar authored
      For the model 'purchase.order', set the action menu 'Share' only for
      the form view.
      
      Linked to task 1984526
      Related to PR #33720
      2456f673
    • Hiral Bhavsar's avatar
      [IMP] mrp(_account): clean the controlpanel action menu · 9f3d3eb8
      Hiral Bhavsar authored
      For model 'mrp.production', rename the action menu
      'Mrp: Plan Production Orders' by 'Plan orders' and set it for the list
      view only.
      
      For the model 'product.template' and 'product.product', rename the menu
      'Compute Price from BoM' by 'Compute cost from BoM' and set it for the
      list view only.
      
      Linked to task 1984526
      Related to PR #33720
      9f3d3eb8
    • Hiral Bhavsar's avatar
      [IMP] stock(_picking_batch): clean the controlpanel actions · 1574861e
      Hiral Bhavsar authored
      For the model 'stock.picking'
      - Rename the action menu 'Assign a Responsible' by 'Assign responsible'
        and set it for the list view only.
      - Rename the action menu 'Add to Batch' by 'Add to batch'
      
      For the model 'stock.warehouse', remove the action menu 'Reordering Rules'
      
      Linked to task 1984526
      Related to PR #33720
      1574861e
    • Hiral Bhavsar's avatar
      [IMP] point_of_sale: clean the controlpanel actions menu · c2bc4ee7
      Hiral Bhavsar authored
      For the model 'pos.session'
      
      - Remove the actions menu 'Put Money In', 'Take Money Out' and 'Orders'
        from the controlpanel actions menu.
      
      For the model 'pos.config', remove 'Sessions' action menu.
      
      Linked to task 1984526
      Related to PR #33720
      c2bc4ee7
    • Hiral Bhavsar's avatar
      [IMP] (website_)sale: clean the controlpanel actions · 9df284f5
      Hiral Bhavsar authored
      For the model 'sale.order'
      
      - Set the action menu 'Share' only for the form view of model.
      - Rename the action menu 'Invoice Order' by 'Create invoices' and set
        only for the list view.
      - Rename the action menu 'Send a Cart Recovery Email' by
        'Send cart recovery email' and set it only for the list view.
        Also improved tour 'shop_cart_recovery' as now action menu only
        available on the list view.
      
      Linked to task 1984526
      Related to PR #33720
      9df284f5
    • Hiral Bhavsar's avatar
      [IMP] crm, website_crm_partner_assign: clean the controlpanel actions · 701f26ce
      Hiral Bhavsar authored
      For the model 'crm.lead'
      
      - Rename the action menu 'Send an email' by 'Send email'.
      - Remove the action menu 'Mark Late Activities as Done' and
        'Mark All Activities as Done'.
      - Set 'Mark as lost' menu action only for the list view.
      - Remove the action menu 'Assign salesman of assigned partner'.
      - Rename the action menu 'Forward to Partner' by 'Forward to partner'
        and set it for both form and list view.
      
      For the model 'res.partner', remove the actions menu 'Meetings'.
      
      Linked to task 1984526
      Related to PR #33720
      701f26ce
    • Hiral Bhavsar's avatar
      [IMP] portal: rename the action menu 'Grant Portal Access' · 69cf2c0f
      Hiral Bhavsar authored
      Rename the action menu 'Grant Portal Access' by 'Grant portal access'
      for the model 'res.partner'.
      
      Linked to task 1984526
      Related to PR #33720
      69cf2c0f
Loading