closes odoo/odoo#34721

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Some functional flows use sudo() to create records as current user is the
public user. This user has no email. Since 1e6c3bec using sudo does
not take superuser identity completely as it only bypasses access rights.
It means some messages are created with public user as author, meaning no
email_from.

In this commit we fix some functional flows by setting a default email_from
in the message composer only if a real email is found. Otherwise it will have
to be set either by the template, either later in the process when creating
messages or emails.

closes odoo/odoo#34742

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Some functional flows use sudo() to create records as current user is the
public user. This user has no email. Since 1e6c3bec using sudo does
not take superuser identity completely as it only bypasses access rights.
It means some messages are created with public user as author, meaning no
email_from.

In this commit we fix some functional flows by allowing message_log to store
messages with a void email_from. Indeed message_log does not propagate any
notifications, meaning email_from is not required in any email notification
or to compute a reply_to.

This reverts commit 6230f72d.

Crashing when user have no valid email is the expected behavior. Flows sending
emails must ensure either current user has valid login / email, either it
uses an user OR author_id / email_from that has a meaning in the functional
flow. Notably when public user is involved. Hiding functional issues is not
what we want.

closes odoo/odoo#34556

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

This commit adds fields 'company_id' on stock.scrap model.
The company will filter locations and stock moves linked to the scrap
document.

We add also a specific sequence by company.

Task-1930055

closes odoo/odoo#30498

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

PURPOSE

The 'action' dropdown on the controlpanel is starting to get messy. Their
labels are sometimes too long/repetitive. Some actions only make sense in
formview, some in listview, some in both. Some actions should be stat buttons.

Here are some of the 'guidelines' I've followed to clean those actions:
If the action already has a dedicated button in the formview, do not display
it in the formview action dropdown. Action labels always start with a verb.
Former actions that redirected to records are changed to stat buttons

SPECIFICATION

The following drive file defines all the changes to be done on actions:
https://docs.google.com/spreadsheets/d/1G0AtYs6VIXFz1vG32IoL457c_oy-OCXF9Tv19vLQdz8/edit?usp=sharing



The actions are grouped by object, which are grouped by product owner. The
ones in green are to be kept. The 'where' column specifies whether they should
be shown in formview, listview, or both. The ones in red are to be removed or
moved somewhere else (stat button, menu item). When an action is removed, check
whether the action it is calling is used somewhere else. If it is not the
case, remove it as well (clean the code).

Linked to task ID 1984526

closes odoo/odoo#33720

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Here remove the 'binding_model' attributes from 'act_window' to
remove the action menu 'Product Margins' from the 'product.product'
model

Linked to task 1984526
Related to PR #33720

* attendance, contract, fleet, holidays, maintenance, presence,
  timesheet.

For the model 'hr.employee', replace the actions menu 'Archive/Restore'
by the stat button. That's why adapted changes regarding xpath.

Also rename the actions menu 'Time Off' by 'Time off'.

Linked to task 1984526
Related to PR #33720

* check_printing, voucher

For the model 'account.account',
- Replace the action menu 'Journal Items' by the stat button.
- Hide menu 'Journal Items for Tax Audit' from actions menu.

For the model 'account.invoice',
- Set action menu 'Share' only for the form view.
- Rename the action menu 'Confirm Draft Invoices' by 'Validate'.
- Rename 'Register Payment' by 'Register payment'.
- Rename 'Send' by 'Send & print'.

For the model 'account.move',
- Remove the menu 'Journal Items'.
- Rename 'Reverse Moves' by 'Reverse' and set it only for the list
  view.
- Rename 'Post Journal Entries' by 'Post entries' and set it only for
  the list view.

For the model 'account.move.line',r ename 'Reconcile Entries' by
'Reconcile' and 'Unreconcile Entries' by 'Unreconcile' and set it only
for the list view.

For the model 'account.payment',
- Rename 'Send Receipt By Email' by 'Send receipt by email' and set it
  for both form and list views.
- Rename 'Post Payments' by 'Confirm' and set it for the list view only
- Rename 'Print Checks' by 'Print checks' and set it for the list view
  only.

For the model 'account.journal', remove the menus 'Unpaid Invoices',
'Bank statements' and 'Voucher Entries'.

Linked to task 1984526
Related to PR #33720

- For the model 'lunch.order', rename the actions menu
  'Lunch: Receive meals' by 'Mark as received' and 'Lunch: Cancel meals'
  by 'Cancel'.
- For the model 'lunch.product', remove the action menu
  'Lunch: Archive/Restore products'

Linked to task 1984526
Related to PR #33720

For the model 'hr.expense', rename the action menu 'Submit Report' by
'Submit report' and set it only for the list view.

Linked to task 1984526
Related to PR #33720

For the model 'project.task', remove the action menu 'Timesheet Entries'

Linked to task 1984526
Related to PR #33720

Rename the action menu 'Create Invoice' by 'Create invoices' for the
model 'repair.order'.

Linked to task 1984526
Related to PR #33720

For the model 'purchase.order', set the action menu 'Share' only for
the form view.

Linked to task 1984526
Related to PR #33720

For model 'mrp.production', rename the action menu
'Mrp: Plan Production Orders' by 'Plan orders' and set it for the list
view only.

For the model 'product.template' and 'product.product', rename the menu
'Compute Price from BoM' by 'Compute cost from BoM' and set it for the
list view only.

Linked to task 1984526
Related to PR #33720

For the model 'stock.picking'
- Rename the action menu 'Assign a Responsible' by 'Assign responsible'
  and set it for the list view only.
- Rename the action menu 'Add to Batch' by 'Add to batch'

For the model 'stock.warehouse', remove the action menu 'Reordering Rules'

Linked to task 1984526
Related to PR #33720

For the model 'pos.session'

- Remove the actions menu 'Put Money In', 'Take Money Out' and 'Orders'
  from the controlpanel actions menu.

For the model 'pos.config', remove 'Sessions' action menu.

Linked to task 1984526
Related to PR #33720

For the model 'sale.order'

- Set the action menu 'Share' only for the form view of model.
- Rename the action menu 'Invoice Order' by 'Create invoices' and set
  only for the list view.
- Rename the action menu 'Send a Cart Recovery Email' by
  'Send cart recovery email' and set it only for the list view.
  Also improved tour 'shop_cart_recovery' as now action menu only
  available on the list view.

Linked to task 1984526
Related to PR #33720

For the model 'crm.lead'

- Rename the action menu 'Send an email' by 'Send email'.
- Remove the action menu 'Mark Late Activities as Done' and
  'Mark All Activities as Done'.
- Set 'Mark as lost' menu action only for the list view.
- Remove the action menu 'Assign salesman of assigned partner'.
- Rename the action menu 'Forward to Partner' by 'Forward to partner'
  and set it for both form and list view.

For the model 'res.partner', remove the actions menu 'Meetings'.

Linked to task 1984526
Related to PR #33720

Rename the action menu 'Grant Portal Access' by 'Grant portal access'
for the model 'res.partner'.

Linked to task 1984526
Related to PR #33720

Remove the action menu 'Invoice Membership' from the model 'res.partner'

Linked to task 1984526
Related to PR #33720

Rename the action menu 'Send Email' by 'Send email' for the
'res.partner' model.

Linked to task 1984526
Related to PR #33720

Rename the action menu 'Merge Contacts' by 'Merge' for the 'res.partner'
model.

Linked to task 1984526
Related to PR #33720

Set action menu 'Send SMS' only for list view of 'res.partner' model.

Linked to task 1984526
Related to PR #33720

message help user in case of misconfiguration.

Task-1960746

closes odoo/odoo#34000

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Previously, 'company' field in the 'contact us' form was a required field
which wasn't ideal to accommodate B2C flow.

When applied this commit will make company field optional by default. Note
that users can customize the form to make it required again if necessary.

Linked to task 1965839

closes odoo/odoo#33005

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose of this commit is to send a mail template to the user
who invited other user(s) in Odoo.

It informs the user about the details of user(s) who have been
invited by him but have still not registered after the given days
of creation (default set to -> 5days)

task-1912449
Closes #31582

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit, when granting portal access to a res.partner through the
wizard, it would show all the partner + its child_ids, including shipping
addresses partner, billing addresses, private (hr) addresses etc, which makes
no sense.

This commit hide contact-address from the list.

Fixes #32848

closes odoo/odoo#34522

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>


Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Xavier Brochard <xavier@alternatif.org>

Cateamions?

Fixes odoo/odoo#34045

closes odoo/odoo#34057

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When the system generate an activity the standard is to define it
as an exception type. Todo works as well but we would keep it for
the user and avoid a mix between exception from the system and created
manually.

Task-2007559

closes odoo/odoo#34006

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

As next activities are ordered by date, having the same date can implies
the order is not always the same.

closes odoo/odoo#34753

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

The invoice status of a sale order line depends on its product's
`invoice_policy` and `qty_delivered` fields.

`invoice_policy` is also used to compute the "anglo saxon price
unit" which is, once multipled by the invoiced quantity, the
amount we will take from the stock delivered account to put into
the cost of goods sold account if we are in anglo saxon mode.

The default `invoice_policy` is set as "ordered". In this mode and in
anglosaxon, the "anglo saxon price unit" will always be standard price
of the product, resulting in unbalanced accounts.

In this task, we chose to use the real delivered price if something was
delivered, whatever the value of `invoice_policy`. We fallback on the
standard price if nothing or not enough things were delivered.

test_dropship_fifo_perpetual_anglosaxon_ordered and
test_dropship_fifo_perpetual_anglosaxon_delivered do have the same
result now.

task-2003196

closes odoo/odoo#34644

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Let's assume an editable list with a row containing only readonly
fields. Before this rev., if the user clicked on this row and then
pressed TAB, it crashed. The crash occurred in historical code that
now seems to be useless, so we simply removed it.

closes odoo/odoo#34696

Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>

Previously to commit [1] notification emails were send using the after commit
hook (see [2] for related code move and [3] for original code). That commit
changed the parameter default value without any reason, meaning this mechanism
is not used anymore. This commit fixes that behavior.

[1] See commit 581a7414: code cleaning
[2] See commit 7a626971: code move
[3] See commit 38e181ee: use of post-commit hook in mail

closes odoo/odoo#34681

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Commit f60825b4 moved phone validation addition on res.partner model
from a specific module to crm directly. However the inherit from the validation
mixin class was forgotten, leading to a crash when changing phone from the UI.

closes odoo/odoo#34545

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Removed classes "default-label" and "label" as they weren't required and
were giving a bad look to tag.

Task-2033286

closes odoo/odoo#34646

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>