Fix the displayed end date weekday on an event's registration page. See #39698

Activate Google Synchronization, create on OE a recurrent event,
synchronize the calendar, then delete an event of the recursion on GC,
sync again on OE.

The event will be deleted from GC but not from OE after sync.

This appens because of this "rewrite" rule
https://github.com/odoo/odoo/blob/12.0/addons/calendar/models/calendar.py#L918


that occur on event creation from OE, altering the event parameters when
is marked "allday".

When an "allday" event is deleted from GC the unlink is triggered in OE with the
default time "00:00:00". During the creation of the exclusion '
_inverse_dates' will be called altering start and stop datetime but not
recurrent_id_date, so the new record will not match the event generating
the recursion and the exclusion will not occur. The problem require
particular carefulness because when a recurrent event is fetched from
google the '_inverse_dates' is not called, so in that case the default
time is fine.

opw-2060526

closes odoo/odoo#39653

X-original-commit: a468464c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In the contacts app, you can select 2 partners and merge them.

Before this commit:

    - If a partner was added by a SQL query and not directly on Odoo,
      the create_date will be empty. This causes a crash because the
      merge wizard try to sort the partners by date

After this commit:

    - If a partner do not have a create_date, it will be considered
      as 01/01/1970. The merge wizard will sort the partners by IDs too.

OPW-2091925

closes odoo/odoo#39758

X-original-commit: df09f2f73ddf917304906e98725324319c309939
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

In editable list view, moving to next cell using TAB key crash when the
following field is read-only (i.e non-focusable) and an onchange() event
is triggered.

Consider an editable tree view like this:

<form>
   <field name="o2m" onchange="1">
       <tree>
          <field name="description"/>
          <field name="date" readonly="1"/>
          <field name="type"/>
       </tree>
   </field>
</form>

1. Adding a new line will give focus to `description` field widget
   (currentFieldIndex is 0)

2. issuing a TAB keypress, will call _onNavigationMove which calls
   _selectCell() with fieldIndex of 1

3. The _selectCell() method set widget currentFieldIndex to the new value
   (currentFieldIndex is 1) add call _activateFieldWidget() to activate
   on the corresponding widget.

4. _activateFieldWidget() will fail to activate the `date` field as it's
   readonly, then try for next ones and succeed to activate the `type` field
   cell

5. When focus is given a `type`, the `description` field is blurred which
   trigger an onchange() and the controller apply those changes to the
   editable list rendererd using the confirmUpdate() method.

   The confirmUpdate() will try to get the current selection, but that
   field is actually set to the `date` field (currentFieldIndex = 1),
   which is readonly and so has no focusedElement - triggering the crash.

This commit ensure we don't try to call getSelectionRange() it current widget
has no focusable element.

OPW-2075229

closes odoo/odoo#39972

X-original-commit: 93c7ae9ba5309810c41c58fc8f2fafb3c3dac76e
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Follow up on https://github.com/odoo/odoo/commit/ac5469646cdea7c0990fbd5092eae26e7e0768ae#diff-04174b6f17e548b9a79222ae09c573db


Before this Commit, upgrade_boolean was applied on sale_coupon module while this has been moved to the community version from v13, so upgrade_boolean is not needed now

closes odoo/odoo#39985

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

closes odoo/odoo#39987

X-original-commit: 75b1d412
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Commit 775e8a9f forced channel guidelines to be sent directly. It seems
safer to use the cron queue as we do not see any evidence of daily use of
channel guidelines requiring immediate sending.

Task ID 2121319
PR #39978

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

When an incoming email on a channel is rejected, an email is sent to the
original author to inform him of the rejection. This email contains the
original email content added in a generic rejection email.

This original content was however considered as plaintext and escaped. Result
was quite hard to read. As content is sanitized we can safely append it to
the rejection email as valid html.

Task ID 2121319
PR #39978

From Sale create a new (or edit) SO. Add a note to the order with a log
line without dash or whitespace (i.e. a url). Click on "Preview".

The sale portal will try to display the long line which will overflow
the standard size of the column creating an ugly overflow with a very
long horizontal scrollbar.

Adding a "break-all" rule to fix the sale portal case.

opw-2088589

closes odoo/odoo#39966

X-original-commit: 28afbaf5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Fixes https://github.com/odoo/odoo/pull/39583


This commit adds a default value for  event_count
Assigning default value for non-stored compute fields is required in 13.0

closes odoo/odoo#39611

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

When computing time statistics, we need to look for
archived website visitors also to avoid a KeyError
if we use the default 'Archived' filter.

closes odoo/odoo#39918

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Reproduce the issue:
 - In the CRM app, create a lead/opportunity.
 - Schedule a meeting for this opportunity via
   the chatter and click on create.
 - Go back, the "Meeting" stat button is now at 1
 - Schedule a meeting for this opportunity via
   the chatter and click on edit then create.
 - Go back, the "Meeting" stat button is still at 1

Cause:
When we click directly on create, the opportunity ID is in the defaults
option but when we click on edit, there is no opportunity ID.

So, this commit use the context to retrieve the concerned opportunity
and set it if it is not already set.

I splitted the solution into a private method for a better readability.

OPW-2092920

closes odoo/odoo#39952

X-original-commit: 59d154dc
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

Without hr_recruitment it was not possible to import/export the hr.job
as they were not visible.

closes #22069

closes odoo/odoo#39914

Taskid: 2088277
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Reproduce this bug:
 - Create 2 companies: Indian and Belgian for example
 - Install accounting & l10n_in
 - Create an invoice & print it

The `<td>` dedicated to the HSN is always present so there is a
cosmetic issue for the not indian companies: the table is a *little*
bit too large. This issue is caused by a missing conditional statement
on the `<td>` who is present on the HSN `<th>`.

OPW-2090663

closes odoo/odoo#39837

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, when an event have multiples notifications, if the
first notification is not ack when the second notification is shown, not
only two are visualized but multiples notifications are raised.

Now, only the correct number of notifications are shown.

opw-2070852

closes odoo/odoo#39901

X-original-commit: 8ab0bfeaa7b6c3e1642064d123197b1cba74355d
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
Co-authored-by: Lucas Perais <lpe@odoo.com>

- Create a child company B in parent company A
- Go to company A
- Create an invoice, create a payment (less than the invoice)
- Open the payment matching widget
- Associate the invoice and the payment, add a line for the open balance

It is possible to choose accounts from company B.

This is due to an incorrect forward-port of commit fb48e497.
It was valid in v11 but needed to be changed in v12.

Fixes #39533
opw-2116411

closes odoo/odoo#39871

X-original-commit: 7d1d3fe1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The list comes from the selection values on the field license of
ir.module.module

closes odoo/odoo#39906

X-original-commit: 23f89363
Signed-off-by: Nathan Perry <servel333@users.noreply.github.com>

This commit fixes the "quiz finish" modal display by correctly hiding it when the user clicks on
the "Next" button in the modal.

Without this fix, the user could run into an issue where the "modal backdrop" would stay on the
screen, locking all actions and forcing a manual refresh.

Task#2118532

closes odoo/odoo#39894

X-original-commit: 84603c6d928e5ba9b19c4ed3e8b6edbab42a8a5b
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This commit: https://github.com/odoo/odoo/commit/0eba50dd1c33a08f8862a5718149e61b822e1b5a


introduced a 'return' in the survey.js script: return load_chart(chartConfig, '#scoring_results_chart');
This makes the rest of the script completely skipped and bypasses all the filter features.

task-2116078

closes odoo/odoo#39893

X-original-commit: b7baaf4846ba9208aeba8ba4db7de4f142e147cc
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Adapt website for 13.0 9996d04f change of LinkDialog constructor
arguments (to get back to same arguments as in 12.0).

opw-2086444
closes #39888

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

-By this commit, 'Buy credits' link should only be visible whenever
 'Lead Enrichment' feature is enable in settings of CRM.

task-2116040

closes odoo/odoo#39578

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#39223

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

PURPOSE

Fix a bug where you get a traceback when trying to join a course on a quiz
preview not in fullscreen mode.

A variable was badly named in JS (id -> channelId), leading to the ID not
being forwarded to the "Join Course" sub-widget.

LINKS

Task ID 2079476
PR #38051

closes odoo/odoo#39876

X-original-commit: b32d30b8cde85ba37f9cef975838874a08ea7c07
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

In f2969923 (12.3) part of the code of the editor `Link Dialog` was
moved to a web_editor/static/src/js/wysiwyg/plugin/link.js file/class.

In 13.0 the 12.3 editor changes were mostly reverted in 35b61822 but
part of the change of `Link Dialog` that was moved to another file/class
was not moved back, thus: it does not work as expected => eg. if we add
a link over an image, the image is removed.

In this commit we get back the missing part as it was in 12.0 version.

opw-2086444
closes #39858

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When a pos order is sent to the server, the field 'to_invoice' is never
sent to the server which lead to always having a value to 'false'.

We are now sending correctly this value to the server, and we can also
base the fact to create an invoice on the value of each order.

Because beeing offline could lead to create an order that should be
invoiced as one that should not be.

closes odoo/odoo#39843

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

closes odoo/odoo#39855

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Fixes #39688

closes odoo/odoo#39854

X-original-commit: 06a9e8aa
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

In commit: https://github.com/odoo/odoo/commit/0cc30bf08382128a77455a51d831ef45ccdfdb48#diff-fb13a23a71b7b833233add03eb5f10f7R20


confirmation_date was replaced by the date_order on sale order.

At the same time in compute method confirmation_date was too replace
but on sale.report  no such field exist so replace the date_order by
date which coming from date_order of sale order.

Task-1883428

closes odoo/odoo#39849

Closes: #39849
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The commit 3c4bb080 fixed an issue about reservation from transit location
for versions from 11.0 to 12.0 by soften the record rule on stock.move

From 12.3, we need to additionnaly soften the stock.move.line rule
to have the same result as this model has a record rule too since that version

closes odoo/odoo#39809

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Create a customer without email address, go on the accounting module
create an invoice for this customer.

Go back to the invoices list and select some of them including your
invoice for your customer without email address. Send them by mail.

You will have a traceback and the wizard will be broken.

This bug is caused by a change in the account module, there is no more
reference, they are replaced by the name of the invoice.

OPW-2085837

closes odoo/odoo#39738

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- In the sales or accounting module, create some invoices.
- Select them then click on `action > send & print`
- The wizard opens but not in the mass mail mode.

It creates some inconsistency and if you click on send,
the invoices are sent to the wrong customer.

Sometimes, the invoices are not sent at all.

I think the problem comes from the `_compute_composition_mode` method
who set the value of `composition_mode` on the wizard instead of
on the composer.

OPW-2085837

In 13.0, we use the IoTBox which handle https correctly
12.0 was still a transition version but people should have switched in
13.0

closes odoo/odoo#39832

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

A journal entry must always have the same currency as the account when
a secondary currency is set on this one.

closes odoo/odoo#39744

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

This field has been introduced by https://github.com/odoo/odoo/commit/2d1b8e9f3445ab0e1c1ac4683b7b5a25c867b2de
but is no longer used anywhere and is not a valid field on account.move.line.

Fields (and selection values) were re-labeled in multiple models but
the corresponding import templates were not updated to match, and are
now non-working (can't straight import the templates themselves which
is inconvenient).

Task 2059779

closes odoo/odoo#36119

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

* the employees file apparently never worked as the marital status was
  updated before template files were added (respectively
  0eb58775 and
  b60de0db)
* the purchase template was never updated to reflect the Big Demo Data Changes
  (58fc4e44).

Fixes #39074

Employees file update split off of task 2059779.

closes odoo/odoo#39822

X-original-commit: 80a2f687
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Co-authored-by: Prakash Prajapati <ppr@odoo.com>

Go on the accounting module, you'll find a kanban view with a few
cards including "Bank" and "Cash". Click on the Cash card.

The default import button doesn't appears because it is hidden.
The reason of this hiding is that the bank statements of type "Bank"
have a custom import method and the users where confuse. They
didn't know which is the right button for the special import so
we hid the default import button for the whole model.

But there is also a "Cash" type bank statement who doesn't have that
special import and his default import button is hidden too.

This commit checks the type of the bank statement and hide the default
import button only if the type is not "Cash".

OPW-2090477

closes odoo/odoo#39827

X-original-commit: ee45228a
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Forgotten in 
https://github.com/odoo/odoo/commit/7b3d87b905dff1212f88cc381a125590f5cb0bfe



closes odoo/odoo#39819

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Followup of #38948

When building the MS Windows package, the PYTHON_VERSION variable is not
used and the WinPython path is hard coded in the Makefile and NSI file.
This prevent the usage of a newer version of Python.

With this commit, the PYTHON_VERSION is used to compute the WinPython
Python directory. That way, this directory can be derived from
package.py command line argument --vm-winxp-python-version.

Also the less windows binaries are not packaged anymore.

closes odoo/odoo#39816

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>