Skip to content
Snippets Groups Projects
  1. Dec 04, 2018
  2. Nov 19, 2018
    • Jérome Maes's avatar
      [IMP] sale: reflection refund of invoices from SO in all cases · 255816c0
      Jérome Maes authored
      When creating a credit note from an invoice coming from a Sales Order,
      only the "modify" mode links the refund lines with the sale lines. This
      link make the invoiced quantity decreased on the sale line, which is
      a willing behavior.
      The 2 other modes ("cancel", and "create") does not do that link.
      As the behavior of the "modify" mode was introduced as bugfix years
      ago, it was time to clean that !
      
      This commit
      - extends the behavior to every mode: all refund lines are now
      linked to their origin sale lines, so the invoiced quantities
      are correctly applied
      - clean the bricolage used to determine the invoice of the
      sales order (`_get_invoiced` method) by avoiding searching
      on the document source field.
      - provides some tests. The old one was moved and extended.
      
      Task-1859308
      
      closes odoo/odoo#28471
      255816c0
  3. Dec 04, 2018
  4. Dec 03, 2018
  5. Nov 30, 2018
    • Robot Odoo's avatar
      [MERGE] hr_payroll: Introduce hr.benefit model · bdc9688d
      Robot Odoo authored
      Purpose
      =======
      
      For payroll purpose, we need to manage attendances.
      For instance, someone is working only mondays, tuesdays and fridays, but works exceptionally an other day.
      It must be recorded.
      
      Specification
      ===========
      
      The new models are used to represent attendances, extra hours and leaves (as `hr.benefit`s) in a new window called "Benefits".
      The schedule of employees for the full month is visible in that view (calendar view).
      
      First the benefits needs to be generated (via a button) based on the calendar attendances and leaves.
      The manager can then check benefits, delete or add some. Only the benefit name and type can be edited (not start and end dates).
      Once benefits are correct, they can be validated. Validation will fail if they are some leaves to approve or if some benefits overlap on the same day.
      Benefits cannot be deleted or edited once validated.
      When benefits are all validated, a button appears to generate payslips.
      
      Additional development
      ==================
      
      Most of the time we don't what is the next action that should be done when creating payslips or payslip batches.
      
      - Improve the layout, the buttons of the payroll object.
      - Refactor a little the code to reuse existing chunks of code instead of reinventing the wheel in several methods.
      - Remove the hr.rule.input model.
      - Remove an useless report.
      
      See each individual commit for more information.
      
      TaskID: 1912944, 1903239
      
      closes odoo/odoo#29065
      Unverified
      bdc9688d
    • Pratima Gupta's avatar
      [IMP]stock_account: Test case changes. · 9c2a6850
      Pratima Gupta authored
      property_cost_method is removed from product.product and product.template.
      And use property_cost_method of product.category everywhare.
      
      In This -
      Used property_cost_method of product.category instead of cost_method or property_cost_method of product.template.
      
      This commit is related to task#1866333.
      9c2a6850
    • Pratima Gupta's avatar
      [IMP]stock_account: property_cost_method is removed from · 493502bc
      Pratima Gupta authored
      product.product and product.template.
      
      And use property_cost_method of product.category everywhare.
      
      In This -
      Used property_cost_method of product.category instead of cost_method or property_cost_method of product.template.
      
      This commit is related to task#1866333.
      493502bc
    • Yannick Tivisse's avatar
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Improve payslip batch generation flow · 28a1b546
      Yannick Tivisse authored
      Same than for payslips. Improve the flow to make it clear what is the next action
      instead of displaying all the buttons.
      
      And refactor a little the code to be more efficient, and reuse existing method instead
      of using this horrible 'onchange_employee_id' method.
      28a1b546
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Hide credit_note on payslip views · 023e4e27
      Yannick Tivisse authored
      This field should be set by making a refund, it should be available
      for an end user.
      023e4e27
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Put single payslips in a batch. · f29d9dfe
      Yannick Tivisse authored
      When creating a payslip, if no batch is defined for it, put it
      automatically in a new batch.
      f29d9dfe
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Improve payslip creation/validation flow · 9bab1ed2
      Yannick Tivisse authored
      Avoid to display the buttons on each stage (compute sheet, cancel, ...).
      
      Now the next action is clear on the payslip.
      9bab1ed2
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Make 'contract_id' related on worked_days/input lines · 3cc823a6
      Yannick Tivisse authored
      No need to display this information on every worked days/input lines
      
      It makes no sense to have a different contract on different payslip lines
      too.
      3cc823a6
    • Yannick Tivisse's avatar
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Remove 'Details By Salary Rules Category' · 9cd7dbe2
      Yannick Tivisse authored
      This field brings nothing more than the payslip lines.
      
      Btw the term is badly chosen, it doesn't display the lines by salary rules category,
      it displays the payslip lines that have a category.
      
      The printed report is not very useful too. The only interesting part is the
      contribution register at the end of the report, and there is already a dedicated
      report for that.
      9cd7dbe2
    • Yannick Tivisse's avatar
      [IMP] hr_payroll: Remove hr.rule.input model · c7bbbd41
      Yannick Tivisse authored
      There are currently 2 models:
      - hr.rule.input to link some inputs to an hr.payslip.rule
      - hr.payslip.input to add some additional inputs on a payslip.
      
      The first model is actually there to automatically add inputs on the
      additional inputs on the payslip. This is problematic because these
      rules are always added (For example a salary reduction due to a
      police fine). As these inputs are always added on the payslip, the
      the related rules are always computed with an amount of 0.
      
      We decided to remove this mechanism for the following reasons:
      - If the rule is important and common, then define the needed values on
        the contract, and compute the rules from that.
      - If the rule is not so important, it should be added manually when needed.
      c7bbbd41
    • lul-odoo's avatar
      [IMP] hr_payroll: Add new models `hr.benefit`, `hr.benefit.type` · 78128760
      lul-odoo authored
      Purpose
      =======
      
      For payroll purpose, we need to manage attendances.
      For instance, someone is working only mondays, tuesdays and fridays, but works exceptionally an other day.
      It must be recorded.
      
      Specification
      =============
      The new models are used to represent attendances, extra hours and leaves (as `hr.benefit`s) in a new window called "Benefits".
      The schedule of employees for the full month is visible in that view (calendar view).
      
      First the benefits needs to be generated (via a button) based on the calendar attendances and leaves.
      The manager can then check benefits, delete or add some. Only the benefit name and type can be edited (not start and end dates).
      Once benefits are correct, they can be validated. Validation will fail if they are some leaves to approve or if some benefits overlap on the same day.
      Benefits cannot be deleted or edited once validated.
      When benefits are all validated, a button appears to generate payslips.
      
      Closes #28261
      78128760
    • lul-odoo's avatar
      [IMP] resource: Add `domain` parameter to compute attendace intervals · 5a9b8a41
      lul-odoo authored
      Purpose
      =======
      More flexibility is useful when using the _attendance_intervals method (resource.calendar) in other modules when inheriting resource.calendar
      
      Specification
      =============
      The commit adds a `domain` parameter to the _attendance_intervals method in resource.calendar, allowing
      to better control attendances from which to compute intervals.
      
      + small refactoring: extraction of duplicated code in method
      5a9b8a41
    • lul-odoo's avatar
      [FIX] hr_payroll_account: Remove journal_id: False in context · 07bec7db
      lul-odoo authored
      If the wizard to generate payslip was launched without an ´active_id´ in the context.
      A ´journal_id´ entry was set to False in the context later leading to a crash at payslip creation.
      The crash happens because, at creation time, the journal_id of a ´hr.payslip´ is set to the journal_id
      in the context if its present. Since this context entry is False and the journal_id field is required,
      creation crashes.
      07bec7db
    • Géry Debongnie's avatar
      [IMP] web: do not eval modifiers if not necessary · f6c104d2
      Géry Debongnie authored
      Before this commit, the web client evaluated all modifiers
      (readonly/invisible/required) in some cases, even if it only needed one
      of them.  This is clearly not optimal, and I even suppose that for large o2m,
      it could even have a noticeable effect on web client perceived speed
      
      This commit simply make sure that we evaluate only what we need in those
      cases.  Note that it is not really a testable improvement, hence the
      lack of tests.
      
      closes odoo/odoo#29171
      f6c104d2
    • Kirti Choudhary's avatar
      [IMP] stock: default responsible + activity responsible · ba9b5ce1
      Kirti Choudhary authored
      Traceback when the responsible is not set on an activity
      since it's a required field. In this case we will use the
      odoo system responsible for the activity.
      
      Also reintroduce the default value for the responsible as
      the user that create the product. The purpose is to avoid
      to log all the activity for the odoo system but to dispatch
      the exception between user, if a user create the product he
      will probably be responsible for it. It is always possible
      to remove the responsible or to modify it.
      
      Task ID - 1913168
      
      closes odoo/odoo#29138
      ba9b5ce1
    • Arnold Moyaux's avatar
      [REF] delivery: hs code back in delivery · 1c28ba8c
      Arnold Moyaux authored
      hs code was dropped in 12.0 however it shouldn't have been (commit 2d738f85). commit 498dbc54 created a new module in order to avoid losing hscode for existing database during migration.
      
      This commit set it back as before.
      
      closes odoo/odoo#29167
      1c28ba8c
  6. Nov 29, 2018
Loading