- Create a Sale Order with a product
- Confirm and deliver the product, create an invoice.
- Cancel that invoice, go back to the SO.
- Recreate the invoice, you have 2 of them (one cancelled).
- Post the second, and try 'Send and print' and 'Preview'.

A traceback is raised.

The traceback arises because we sort on the `invoice_date`, which is
`False` for a canceled invoice.

Actually, we should not take into account canceled invoices.

opw-2119870

closes odoo/odoo#40192

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Without this commit, if you have the hr_timesheet installed, the one2many analytic lines view (in the Journal Items form) shows the hr_timesheet_line_tree view instead, which is not desired.

closes odoo/odoo#40189

X-original-commit: 0b92bde84afac4a78512c475de3c8c822a1fa4b2
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

There is a constrains preventing writing debit/credit on an already
reconciled journal item. However, this constraint isn't aware about
monetary fields and then, was raising an error when writing amount
like 1.000001 on a debit of 1.0.

closes odoo/odoo#40182

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Make sure to update the standard price with the computed unit cost of
the candidate and not its `unit_cost` field, as the computed could
contain an extra value from a landed cost.

closes odoo/odoo#40185

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

closes odoo/odoo#40184

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Introduced by https://github.com/odoo/odoo/commit/ab483a3a6610a09391ec00e9c1c49489ca4a4f12


There was no way to exit the 'cancelled' state of an account.payment.
The new live-cycle is:
- draft -> posted -> sent -> reconciled -> cancelled
- action_draft to move the account.payment from ('cancelled', 'posted', 'sent', 'reconciled') -> 'draft'
- cancel to move the account.payment from 'draft' -> 'cancel'

closes odoo/odoo#40179

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

In 4d5c3b9f the arguments of the MenuEntryDialog widget were
altered, and one instantiation of this widget was not adapted, resulting
in the last parameter being undefined and causing a crash. This commit
adapts that call.

closes odoo/odoo#40171

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before that, draft entries were taken into account in reconciliation propositions; which made no sense.

13.0 version of https://github.com/odoo/odoo/pull/39954



closes odoo/odoo#40167

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Without the product_uom_category_id set you cannot edit this tree view. There is a domain [('category_id', '=', product_uom_category_id)] triggered from this view whcich is not fulfilled if we do not have the field set in the tree.

closes odoo/odoo#39551

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Fine tuning of this commit: f93fcaff

Steps to reproduce the bug:

- Open runbot v11
- Restrict Demo's access to Sales Manager for sales and employee for Employee
- Try to create a new quotation

Bug:
- You got Odoo server Error
Sorry, you are not allowed to access this document. Only users with the following access level are currently allowed to do that:
- Inventory/User
- Accounting & Finance/Billing
- Purchases/User
- Purchases/Manager
- Other Extra Rights/Portal
(Document model: purchase.order.line) - (Operation: read, User: 5)

opw:2120692

closes odoo/odoo#40149

X-original-commit: 1b14af28
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

self.env.user returns the current user but browsed with the superuser:
- self.env.user == current user
- self.env.user.env.user == administrator

get_context uses self.env.user to retrieve the context of the user.
Before this patch, the name of the filters was translated in the
language of the administrator instead of the current user.

Closes odoo/odoo#40086

closes odoo/odoo#40142

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

* In a pos-session with table management create a new order with products
and go back to the floor-plan.
* The order is sinced to the back-end.
* Open the table again, remove all products but keep the order.
* Go back to floorplan to trigger syncing again.
* Open the table again.

behaviour before fix:
* The empty order is not loaded in the frontend anymore.
* To close the session the order has to be manually removed in the backend.

After fix:
* The order is still visible in the frontend and can be removed or finalysed as expected.

closes odoo/odoo#40103

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Add the id of the current company to the evaluation context for ir.rule
domains

closes odoo/odoo#40035

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Commit 5fcf891e introduced optimizations for
name_search in several models.  However, that produces some counter-intuitive
searches.

In a DB with project and custom data:

    >>> Project = self.env['project.task']
    >>> Project.search([('user_id', 'ilike', 'demo')]).mapped('user_id.name')
    ['Marc Demo']

    >>> Project.search([('user_id', 'not ilike', 'demo')]).mapped('user_id.name')
    ['Marc Demo']

The projects returned with 'not ilike' are a super-set of those returned with
'ilike':

    >>> Project.search([('user_id', 'ilike', 'demo')])
    project.task(22, 21, 20, 16, 14, 13)

    >>> Project.search([('user_id', 'not ilike', 'demo')])
    project.task(22, 21, 29, 28, 27, 26, 25, 20, 16, 14, 13, 31, 30)

This commit fix this behaviour by choosing '!=' instead of '=' whenever the
operator is a negation operator.

The 'res.users' is more exposed than the other models touched by
5fcf891e, because user may search for 'Created
by' in the web client.

closes odoo/odoo#40130

X-original-commit: b3c539b0
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When assigning a default value to a computed monetary field, if self
contains records with different currencies, the assignation will fail
when trying to round the value (because self[currency_field] is a
recordset of multiple currencies).

Globally, assigning a monetary value to records in different currencies
should never happen.  The only case we want to support is defaulting a
computed monetary to 0.0.

Add clear error when trying to set monetaries in multi-currency.

closes odoo/odoo#40128

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Raphael Collet <rco@odoo.com>

In IE Edge async and await are supported, but guardedCatch is added to
polyfilled MyPromise object and async methods return original Promise so
depending of chain guardedCatch can cause en error or not.

It seems that historically, the MyPromise patching has also had issue in
firefox with it sometimes working or not.

In this changeset we completely remove it (which will have the drawback
of more error shown in console in firefox).

opw-1964486
opw-2116839
closes #39953

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When using the flamegraph module from a parent directory of odoo, the
dirname method returns a relative path, leading to a traceback.

With this commit, the odoo_path is enforced to be an absolute path.

closes odoo/odoo#40124

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

commit 89f20d2c removed thumbnail but didn't adapt the views that used it.

Adapt the view and directly use the datas and not the thumbnail.

Close #38747

closes odoo/odoo#40122

X-original-commit: e73b468135d27ce8c1e84c3ecf2d0b3af176d760
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Fixes https://github.com/odoo/odoo/issues/39358


Before this commit Internal user (With no other Rights) cannot perform any activity on Reminder Popup due to missing rights to set calendar_last_notif_ack field.
With this fix, we are now using sudo to write calendar_last_notif_ack

closes odoo/odoo#40101

X-original-commit: 91560fae
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#40000

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The self don't contain 'interface_protocol'.
The 'interface_protocol' is in self.dev because we add this in 'supported' function.

closes odoo/odoo#40118

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

In 12.3 there was a number of changes in source mode. This was reverted
before 13.0 and somehow it seems the source mode was lost between the
12.3 editor changes and its revert.

With this changeset, we introduce back source mode as it was in 12.

opw-2091649
opw-2116960
closes #40026

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Reproduce this issue

    - Install CRM & Sales
    - Create 2 sales team in CRM settings
    - Create some invoices and register payments for the 2 teams
    - Go in CRM > Sales > Team pipelines

    The invoicing amount is still 0 for both teams.

Cause

    - The `_compute_invoiced` method in `CrmTeam` models use a SQL
    query to retrieve the invoices lines but it returns an empty
    recordset because the dates are not right ordered.

    - The line balance are negatives values, doing a SUM() will always
      returns 0

This commit re-order the dates and invert the sign of line.balance.

OPW-2119819

closes odoo/odoo#40093

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- fixed some tax report lines by showing correct amounts
- corrected account types
- set default receivable/payable/advance tax accounts for tax groups

closes odoo/odoo#39191

Task: 1917932
Closes: 39191
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Purpose
=======

Steps to reproduce:

- Configure a product of type service to create a task on a
  sales order validation, without configuring a project template
- On the SO confirmation, the project is generated without any stages

Additional issue:
- go to the Kanban view of the Project
- filter on something that doesn't give any result
- The kanban switches to edit mode, even if there is
  a task

This commit solves both issues.

closes odoo/odoo#40056

X-original-commit: e2de6331f7f75c9c9b086e57b88f6d25a2cd303d
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

In case of a multi-record and multi-page (i.e. 2 pages per PDF) report
the assertion is triggered b/c we have 4 pages and only two records with
a PDF of 2 pages each, so the outline_page needs to be unique before
assertion.

len([0, 0, 2, 2]) != len([record_id1, record_id2])
len([0, 2]) == len([record_id1, record_id2])

closes odoo/odoo#40075

X-original-commit: 573e5777
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

A patched method was not unpatched. Which triggered issues in a staging
master branch trying to untie a bit mail tests.

closes odoo/odoo#40046

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Install stock and sale. Create a sale with 2+ products, save and
confirm.
Look for the created picking.

There will be no source doument, because of
cb618e9a
the behavior has changed when there are multiple source
document, possibly to avoid displaying the wrong source if they
differ.

Adding the possibility to display multiple source documents, eventually
truncating the list

opw-2117886

closes odoo/odoo#39957

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The icon of the 'Vendor Bills' stat button isn't displayed
so fix the icon class.

Task-2115206

closes odoo/odoo#40006

Closes: #40006
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#40034

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Firstly bd49f9fd did some fixes that removed a bunch of code containing 'install_mode_data'. Later, 627292f7 replaced 'install_mode_data' for 'install_filename'. Finally, 43dd9ecd reverted bd49f9fd (including 'install_mode_data' remnant).

closes odoo/odoo#40022

X-original-commit: 0c3d9256
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#40028

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Prerequisites

    - Configure a mail server (incoming)
    - Enable leads in CRM app
    - Create a sales team with a mail alias (ex: testcrm@odoo.com)
      and check "Pipeline" and "Leads"
    - Set a partner email with one of yours (ex: bob@odoo.com) /!\
    - Send a mail from bob to testcrm
    - In the incoming mail server click on "Fetch"

Reproduce the issue:

    - Convert the generated lead to an opportunity
    - Choose "Existing customer" and set another one than the actual
    - The opportunity is created but the customer is the old one

Cause:

    The given partner_id is overriden by the old one in the
    `handle_partner_assignation` method.

This commit gives the priority to the new partner_id.

OPW-2089404

closes odoo/odoo#40023

X-original-commit: e1833936
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

The third parameter to assertAlmostEqual is a precision (places), not the
assertion message. This goes unnoticed when using two objects which are
strictly equal because assertAlmostEqual shortcuts if the two inputs are equal,
before falling back on approximation.

Since the parameters here are two integers, they're always going to be either 
identical or completely different, therefore the issue is only visible if the assertion 
fails, hiding the assertion error.

* pass the message by keyword
* replace assertAlmostEqual by assertEqual as the inputs are integers and integers
  can't really be "almost" equal

closes odoo/odoo#40015

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Since the deployement of the forward-port bot, chances to merge code
with conflict markers has greatly increased.

With this commit, a new test is added to grep for those markers in most
common code files.

closes odoo/odoo#39994

X-original-commit: 80f22f98
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Updates to the customer display were sent too often:
 - Twice when creating a new order
 - Twice when removing a payment line
 - Every time the status of a payment line with a terminal changed

closes odoo/odoo#39179

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

closes odoo/odoo#40008

Signed-off-by: Fabien Pinckaers <fpodoo@users.noreply.github.com>

Usecase to reproduce:
- Create a purchase requistion with type Call For Tender
- Update a line and set the price to zero.

UserError 'You cannot confirm the blanket order without price.' raised.
It happens because the write don't process the same check than create
and don't check if the purchase_requistion is a blanket order or a call
for tender. It also doens't check the current state of the
purchase_requisition.

closes odoo/odoo#39973

Task: 2120211
X-original-commit: 7d69f014
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When the user changed the parallax option, it was only updated on save.
So, the user was not able to have a preview of what he chose.

Note: this commit is made in saas-12.3 but does not fully solve the
problem there... and unfortunately I don't know why. It fully solves
the problem in 13.0 though and this is more important.

closes odoo/odoo#39991

X-original-commit: 4b633949cd4fd1cae807b95d233879ac4adc01ce
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>