When you try to create two users with the same login, the shown error message is
the Postgresql integrity error instead of a nice (translated) validation error.
This happens since bf88f3e3 which changed the way error messages are translated.

The reason is the manually created unique index `res_users_login_key_unique_website_index`.
The error handling and translation mechanisms don't know it exists.
The index was created for performance reasons in commit b5a12b4a where the
original python constraint was replaced with this custom SQL index.

In this commit, the python constraint is re-introduced to remove the index hack,
but the implementation now uses a single SQL query, which should be quite fast.

closes odoo/odoo#38737

X-original-commit: 817a811e
Signed-off-by: Christophe Simonis <chs@odoo.com>

Go to hr.applicant view form, Edit and change something.
Each time you change a field, the Attachment box in the chatter is toggled
(as if you were clicking on the small attachment button each time).
This a wrong behavior of the `open_attachments` option of the `mail_thread`
widget.
Opening the attachment box should be done at the widget initialisation,
not at every render.

closes odoo/odoo#38720

X-original-commit: 400a1f7b
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

When you try to delete a floor, an error is raised if a pos config has
an opened session. Even if the floor is not used in the opened pos
config.

The real goal of this constraint is to avoid deleting a floor plan
linked to a pos config having an opened session.

Github issue: https://github.com/odoo/odoo/issues/38581



closes odoo/odoo#38719

X-original-commit: 9ec5a4c0
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Creating a location without name does not make sense, it is the only
field of the model
Fixes odoo/odoo#38571

Adapt in master to make the field required at the model

closes odoo/odoo#38718

X-original-commit: 0823062e
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, some images would display incorrectly orientated.

This typically happens for images taken from a non-standard orientation
by some phones or other devices that are able to report orientation.

The specified transposition is applied to the image before all other
operations, because all of them expect the image to be in its final
orientation, which is the case only when the first row of pixels is the top
of the image and the first column of pixels is the left of the image.

Moreover the EXIF tags will not be kept when the image is later saved, so
the transposition has to be done to ensure the final image is correctly
orientated.

closes odoo/odoo#38717

X-original-commit: 0f8e132e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

- Create a sales order for a company with a contact name.
- Click the Preview button.
- The company and contact names appear on the same line, only separated by a
comma.

Before this commit:

it's not possible to easily override this behavior.

After this commit:

it's possible to override `Partner._get_contact_name` to change the format of
contact name.

Beware that this method is used in `_get_name` which is called from various
places. A check on the context may be necessary.

closes odoo/odoo#38712

Opw: 2077294
X-original-commit: 0b8f3f93a2cb05cc9c940964fe80acd23b86b8a0
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, in base we use bus to notify the user but bus module
is not always installed and so we can't call it.

After this commit, now we use a client action to notify the success test.

Steps to reproduce:
* install a Odoo with no apps
* go in debug mode
* go to "Outgoing Mail Servers" technical settings
* create a valid SMTP record
* click on "Test Connection" button (BUG)

closes odoo/odoo#38709

X-original-commit: ea411374
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit, it was not possible to show a message using a client
action. (e.g. show a success message only with core in Python)

Now, it's possible using a client action. This client action call
displayNotification and so we can use the same options also.

A test is added to be sure that this action do not change the current action

Note: in the future a custom registry may be created in a refactoring
to specific function action registry.

X-original-commit: 8775fd67

Before this commit, if we use some client action like: reload, logout, ...
in the console a warning is show, because the action are function and not
AbstractAction.

After this commit, if the client action is not an function and not
a AbstractAction the warning is show.

X-original-commit: 122b7659

Purpose of this commit is to reorganize mail.message file in order to
better understand its content. It is done according to guidelines

  * computed fields;
  * CRUD and search / check access overrides;
  * actions (discuss, moderation, fetch / failure);
  * tools;

Even if this commit generates a big diff, there only some main blocks code
move. Nothing is changed and functionally as well as technically nothing
changes.

closes odoo/odoo#38695

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

-Define "g" as the default UoM for a product.
-Make a purchase order with that product.
-Select the "kg" UoM in the order line and a price of 50.
-Check the Purchase tab of the product.

Before this commit:

the UoM of the price created is the default UoM for the product, "g".
This is because it's a related field.
However, the price wasn't converted to the default UoM, it's still 50.

After this commit:

the price is converted to the default UoM, it's 0.05 per "g".

closes odoo/odoo#38688

Opw: 2076722
X-original-commit: 341b5687
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Fixes https://github.com/odoo/odoo/issues/38233



New Invoices shouldn't be created from Payment screen.

closes odoo/odoo#38687

X-original-commit: 44226ec4
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Fixes #38574
Assigning default value for non-stored compute fields is required in
13.0

closes odoo/odoo#38685

X-original-commit: 7fa80370
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

OPW 2082843
The communication on the register payment took the vendor reference or
the invoice name by default. Now, it first looks at the payment reference
value.

closes odoo/odoo#38683

X-original-commit: 6e1a8218
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Since https://github.com/odoo/odoo/commit/ea3a2ab6788980a8961d9b9a3f88bc13c15a3c46
the website name appears in the view names if the user has the multi
website group or in special cases on some form views.

We don't want it to be displayed in snippet names in the editor UI.

Part of https://github.com/odoo/odoo/pull/38495


task-2083198

closes odoo/odoo#38549

X-original-commit: 3ad50aa5
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

When an option group is opened, all the other opened option groups were
closed. The problem is that an option group may contain other option
groups, so when trying to open a sub-group the main parent group was
closed first.

Note: this case only occurs for one option in themes for now.

Part of https://github.com/odoo/odoo/pull/38495
task-2083198

X-original-commit: 102151da

* website_form

To support old theme options, a hack had to be made to allow access to
left panel UI. This will be improved in master.

Part of https://github.com/odoo/odoo/pull/38495
task-2083198

X-original-commit: 5ac6a7a5

Only invoices/bills should create their equivalent credit notes when reversed (with tax tags coming from the related repartition lines), other kinds of journal entries should be reversed as misc entries, to negate them entirely in the accounting

closes odoo/odoo#38547

X-original-commit: cdb3ccf8
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

We should always ensure to assign something in a compute method

Since sms_template_id is not required, we have to check that it is set
before trying to render the template

Also make sure to have a default value in case you don't have a res_id

closes odoo/odoo#38546

X-original-commit: b96bb2a0
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

sms_composer could crash in case you didn't pass it the active_id,
active_ids context keys or don't call the default_get

In that case it would try to access `self.env[False]` which would crash
in the `_compute_recipients_count`

We also have to ensure that we have a default value for `self.res_ids`
because `literal_eval(False)` will crash

closes odoo/odoo#38545

X-original-commit: 7ed0bd25
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Initially a forward-port of 5aecd365, which needed f407e60a to work.

The do_in_onchange was removed inbetween, but it is not needed anymore here.
The issue was caused by the fact that the cache values given for each
environment, whereas in the new ORM the values are now shared across all.

The other potential issue caught by this test was that the company of the taxes
could be incorrect. This is problematic for the end user, since relational that
violates inter-company rules mean that they won't be able to read or write
the records without sudo. However the model now has _check_company_auto,
handled by the ORM, so the issue should not arise anymore.

closes odoo/odoo#38543

X-original-commit: 30cf4b37
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Because of 4b1cb41c, we might try to read
the field 'active' on a record on which we can't read fields besides the name.
This thus triggers an access error where there should not have been.

In particular, this is the case for portal users: most often the records they
can access point to records that they can't read
(e.g. the partner of the internal user assigned to the ticket).
As a result, clicking on any link creates an ACL, and thus redirects to the
home page.

It turns out that filtered_domain was primarily used on already loaded records,
typically for the write, so it was assumed that the records could be read
in the first place.
However in the use-case of the portal, there is an explicit check on the read
rights with the portal user, explaining the discrepancy.

Since in the general case filtered_domain should be able to read all fields
to evaluate the domain, we put it in sudo.

fix co-authored with @rco

closes odoo/odoo#38540

X-original-commit: cff5cc8c
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Computed fields need to always be assigned a value now.

X-original-commit: a5fc616c

The RUT is the Registro Único Tributario;
the NIT is the Número de Identificación Tributaria.

The number that is used is thus the NIT.

opw 2082599

closes odoo/odoo#38533

X-original-commit: 1db209ac
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Install l10n_co,contacts. Open contacts.

Several crash messages will popup because the override in l10n_co of
res_partner is not computing the 'l10n_co_verification_code' field for
every record. Changing the implementation to be sure to store some value
for every record fix the issue.

opw-2082583

closes odoo/odoo#38473

X-original-commit: 2489c405
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, when we have a list (editable top) in a form
with some mandatory fields and some existing rows. If we click on
'add a line', a new empty line appear on the top, then we click on
the last row, the empty row will disappear and we will have a
traceback.

After this commit, if we repeat this scenario, we click on the last
row, we will be able to edit this last row.

closes odoo/odoo#38471

X-original-commit: 996f77b0
Signed-off-by: jbm-odoo <jbm-odoo@users.noreply.github.com>

Reconcile the stock output lines of the pos.order invoice
for products with real-time valuation. This is to be more
consistent with the sales module.

closes odoo/odoo#38437

Task-id: 2048668
X-original-commit: 1eaea47c
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Rename `signature.js` to `signature_tests.js`.
Rename `special_fields.js` to `special_fields_tests.js`.

closes odoo/odoo#29501

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Example of workflow to reproduce the issue:
- Add a selection field 'Test' to `project.task` with Studio
- Go to Projects > Planning > By Project
- Switch to list view
- Add the newly created field to the view 'Task > Test'

The interface loops indefinitely because the server is stuck in an
infinite loop.

The loop is the following:

https://github.com/odoo/odoo/blob/89270ee39c0daa46ae8e2e3e57d7e512a1a65ddf/odoo/models.py#L5624-L5625



The root cause of the issue comes from an incorrect object ID added in
the list of fields to recompute. Since the method is set in a
`post_init`, the object `field` is different from `recs[field_name]`.

To prevent the error, we retrieve the object directly in the
`mark_fields_to_compute` method.

opw-2083852

closes odoo/odoo#38550

X-original-commit: 446cd3f3
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Denis Ledoux <dle@odoo.com>

Fields created with Studio are case-sensitive, so we need to properly
quote the query.

opw-2083852

closes odoo/odoo#38544

X-original-commit: 2c50b663
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Install timesheets and studio.
- In timesheets add a time of -0.5 (minus half an hour).
- Enter studio
- Switch to the Reports tab, and click Timesheet Entries.

Before this commit:

The time is displayed as 00:30.

After this commit:

The time is displayed as -00:30.

closes odoo/odoo#38542

Opw: 2036188
X-original-commit: b12374a2
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Computed fields that depend on the context now have to be declared as such.

To reproduce the issue:
- go on the form view of any view
- update the arch of the view
- save
- click on action "reset view architecture"
- select hard reset
- no diff is shown

Expected: a diff should be shown

`arch_base` depends on `arch`, so even though no current flow actually uses it
when the context is changed, update its `depends_context` as well to be safe.

closes odoo/odoo#38536

Pr: #37363
X-original-commit: be658bb8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

This is necessary when writing view fields from a page record because the
generic page will put the given values on its cache but in reality the values
were only meant to go on the specific page. Invalidate all fields and not only
those in vals because other fields could have been changed implicitly too.

Pr: #37363
X-original-commit: 83f9a3e2

-Import a subscription with end date beyond 200 in the future (ex: 2500-01-01).
-Open the subscription and click the Edit button.

Before this commit:

A stacktrace appears indicating that a date is not valid. It's not possible to
edit the subscription.

After this commit:

The maxDate of the date picker has been increased to 31/12/9999, allowing the
user to edit subscriptions whose end date is that far in the future.

A test `toggle datepicker far in the future` for this case has been created.

closes odoo/odoo#38527

Opw: 2079696
X-original-commit: 32b6131c04fef7a542a0ccbdb924d177627bfe38
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

We didn't check the status of the response of the server when getting
the url of the display. If the status was different from 200, we tried
to use the error response as URL.

closes odoo/odoo#38554

X-original-commit: 8854f910
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

As the responsible can be assigned directly in the list view, the assign
responsible wizard is now useless. The Country will not forget what you
did for us wizard, thank you.

closes odoo/odoo#38365

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Fixes #38313

closes odoo/odoo#38555

X-original-commit: 843c22fc
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

...Only on mobile device.

closes odoo/odoo#38469

X-original-commit: 484e7bdc
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Before this commit, on mobile, when you make a delivery for a tracked
product you can't find already existing production lot for this product.
The issue was the `company_id` wasn't passed in the context and we use a
domain related on this field.

How to reproduce the issue:
    - Create a product tracked by lot number;
    - Add some quantities for this product by creating a production lot;
    - From a delivery order, try to specify the LN which are part of the
      picking, none are visible (records not found).

X-original-commit: dd49f405

Same size, smaller, better placed buttons.

X-original-commit: 280bd7c4